jmp
jmp
PostsComments
DHDistant Horizons
Created by jmp on 10/3/2024 in #help-me
Incompatibility with Moonrise on Fabric
Please feel free to ping me with any replies
4 replies
DHDistant Horizons
Created by jmp on 10/3/2024 in #help-me
Incompatibility with Moonrise on Fabric
PlatformHooks#chunkSyncSave is also where Moonrise calls NeoForge's ChunkDataEvent.Save event (which I assume DH-NeoForge uses) on that platform, so I'm pretty sure that injecting there will allow it work work as it does on Neo.
4 replies
DHDistant Horizons
Created by jmp on 8/22/2024 in #help-me
Compatibility with upcoming optimization mod 'Moonrise'
Ah ok nice. Another thing that is less important: do you know if there's a reason DH calls chunkMap.worker.loadAsync instead of just chunkMap.read? 
    public CompletableFuture<Optional<CompoundTag>> read(ChunkPos chunkPos) {
        return this.worker.loadAsync(chunkPos);
    }
    public CompletableFuture<Optional<CompoundTag>> read(ChunkPos chunkPos) {
        return this.worker.loadAsync(chunkPos);
    }
We normally null out the worker field since it's private, but we've added a dummy implementation to allow DH to work without changes.
10 replies
DHDistant Horizons
Created by jmp on 8/22/2024 in #help-me
Compatibility with upcoming optimization mod 'Moonrise'
Yes, vanilla now has 90% of the gains that Starlight used to have, but Starlight still provides invariants that vanilla's engine doesn't which are needed for other optimizations in Moonrise
10 replies
DHDistant Horizons
Created by jmp on 8/22/2024 in #help-me
Compatibility with upcoming optimization mod 'Moonrise'
for reference: 
    public static void loadLightHook(final Level world, final ChunkPos pos, final CompoundTag tag, final ChunkAccess into) {
    public static void loadLightHook(final Level world, final ChunkPos pos, final CompoundTag tag, final ChunkAccess into) {
10 replies