Incompatibility with Moonrise on Fabric
Hello, I'm looking into compatibility with Moonrise again, and everything is fine on NeoForge, however, there's a Mixin conflict on Fabric. This inject won't work with Moonrise as the method it's injecting to is no longer used and just throws UnsupportedOperationException. We try and maintain all public and some protected members (by wiring them into our new systems), but this one is private to ChunkMap. After looking through the code a bit, I'm not sure if this is fixable without injecting to Moonrise, specifically here: https://github.com/Tuinity/Moonrise/blob/f32a08738ea92618a1e1d1146275da956a2b7f21/fabric/src/main/java/ca/spottedleaf/moonrise/fabric/FabricHooks.java#L108. I saw that DH already has some Mixins for compat with other mods, so I'm hoping this isn't too much trouble to implement.
1 Reply
PlatformHooks#chunkSyncSave is also where Moonrise calls NeoForge's ChunkDataEvent.Save event (which I assume DH-NeoForge uses) on that platform, so I'm pretty sure that injecting there will allow it work work as it does on Neo.
Please feel free to ping me with any replies