caoimhe
caoimhe
PostsComments
TIPThe Iris Project
Created by Wesley1808 on 12/6/2023 in #iris-issues
1.20.3 crash with Sodium: UnsupportedOperationException
Can confirm that Essential no longer crashes either, thanks for the quick fix IMS
20 replies
TIPThe Iris Project
Created by Wesley1808 on 12/6/2023 in #iris-issues
1.20.3 crash with Sodium: UnsupportedOperationException
Wonderful, thank you ✨
20 replies
TIPThe Iris Project
Created by Wesley1808 on 12/6/2023 in #iris-issues
1.20.3 crash with Sodium: UnsupportedOperationException
I just noticed that, yeah. We use different mappings, so the method names started throwing me off when I was trying to find it in your mixin
20 replies
TIPThe Iris Project
Created by Wesley1808 on 12/6/2023 in #iris-issues
1.20.3 crash with Sodium: UnsupportedOperationException
In the correct case, BufferBuilder will end up containing: 
    @MixinMerged(
        mixin = "me.jellysquid.mods.sodium.mixin.core.render.immediate.consumer.BufferBuilderMixin",
        priority = 1000,
        sessionId = "96c7028b-6220-41eb-8f34-0dfca1d6eadc"
    )
    public VertexConsumer light(int u, int v) {
        return this.light(packU16x2(u, v));
    }
    @MixinMerged(
        mixin = "me.jellysquid.mods.sodium.mixin.core.render.immediate.consumer.BufferBuilderMixin",
        priority = 1000,
        sessionId = "96c7028b-6220-41eb-8f34-0dfca1d6eadc"
    )
    public VertexConsumer light(int u, int v) {
        return this.light(packU16x2(u, v));
    }
in the incorrect case: 
    @MixinMerged(
        mixin = "net.coderbot.iris.mixin.vertices.MixinBufferBuilder",
        priority = 1000,
        sessionId = "4d787d32-0be4-46e6-9b31-060e715effdb"
    )
    @NotNull
    public VertexConsumer light(int var1, int var2) {
        return super.light(var1, var2);
    }
    @MixinMerged(
        mixin = "net.coderbot.iris.mixin.vertices.MixinBufferBuilder",
        priority = 1000,
        sessionId = "4d787d32-0be4-46e6-9b31-060e715effdb"
    )
    @NotNull
    public VertexConsumer light(int var1, int var2) {
        return super.light(var1, var2);
    }
20 replies
TIPThe Iris Project
Created by Wesley1808 on 12/6/2023 in #iris-issues
1.20.3 crash with Sodium: UnsupportedOperationException
Both mixin methods end up having equal priority in this situation, but usually the correct path is chosen 
[12:49:28] [Render thread/WARN]: Method overwrite conflict for method_22921 in sodium.mixins.json:core.render.immediate.consumer.BufferBuilderMixin from mod sodium, previously written by net.coderbot.iris.mixin.vertices.MixinBufferBuilder. Skipping method.
[12:49:28] [Render thread/WARN]: Method overwrite conflict for method_22921 in sodium.mixins.json:core.render.immediate.consumer.BufferBuilderMixin from mod sodium, previously written by net.coderbot.iris.mixin.vertices.MixinBufferBuilder. Skipping method.
20 replies
TIPThe Iris Project
Created by Wesley1808 on 12/6/2023 in #iris-issues
1.20.3 crash with Sodium: UnsupportedOperationException
@IMS if there's any more info that you need I'll be around all day
20 replies
TIPThe Iris Project
Created by Wesley1808 on 12/6/2023 in #iris-issues
1.20.3 crash with Sodium: UnsupportedOperationException
That's my analysis from the problem anyways, I'm unsure of the specifics of the new changes between Iris and Sodium so I can't offer a solution to the devs, but I'm sure they'll have something 😅
20 replies
TIPThe Iris Project
Created by Wesley1808 on 12/6/2023 in #iris-issues
1.20.3 crash with Sodium: UnsupportedOperationException
Hi 👋 I'm having this issue too, originally thought it was something to do with our mod, Essential, but it turns out that that may not be completely true. It appears that because MixinBufferBuilder extends VertexConsumer, a default uv2/light implementation is generated, which seems to go down a code-path that eventually calls one of the methods stubbed out by Sodium's createBlockedUpcallException.
20 replies