TelepathicGrunt Comments - Answer Overflow

TelepathicGrunt

Posts Comments

DHDistant Horizons

•Created by Ommelette on 4/17/2024 in #help-me

Repurposed Structures log spam

I'll remove the logging on my end too since there hasn't been a basalt issue since that one time that drove me nuts.

59 replies

DHDistant Horizons

•Created by Ommelette on 4/17/2024 in #help-me

Repurposed Structures log spam

So I got irritated and added the chunkstatus check with logging to track down the problem mods/datapacks which worked and got them fixed. So ideally if you return chunkstatuses that matches the center chunk, it should prevent issues with people who may not have the chunkstatus check but are calling structureManager.getStructureAt

59 replies

DHDistant Horizons

•Created by Ommelette on 4/17/2024 in #help-me

Repurposed Structures log spam

The reason I had the chunkstatus check originally was because Terralith or some other worldgen datapack mod was using basalt features. But messed up the placement modifiers so the basalt feature was trying to generate outside the 3x3 chunk area. Which causes my structureManager.getStructureAt call to crash (or was it a deadlock? Can't remember)

59 replies

DHDistant Horizons

•Created by Ommelette on 4/17/2024 in #help-me

Repurposed Structures log spam

I could just not log anymore to stop the spam. But I don't know what the future consequences could be of ignoring that the surrounding chunks could be in the wrong chunk status as lots of features and mods could be making assumptions about those side chunks that Empty status could possibly break.

59 replies

DHDistant Horizons

•Created by Ommelette on 4/17/2024 in #help-me

Repurposed Structures log spam

I inject at head of canPlaceAt to detect when the basalt feature is about to be in bounds of my structure to cancel its generation. https://github.com/TelepathicGrunt/RepurposedStructures/blob/8c0e38008be4ed2984a151437bb3928741bb6cfd/common/src/main/java/com/telepathicgrunt/repurposedstructures/mixins/features/NoBasaltColumnsInStructuresMixin.java#L31 Vanilla's basalt feature does count on every layer which has a 0-15 spread built-in https://github.com/misode/mcmeta/blob/d24ffa5d56a7859f960914f256fb1694b8e8dbaa/data/minecraft/worldgen/placed_feature/large_basalt_columns.json#L5 And the basalt feature itself has a 2 to 3 spread https://github.com/misode/mcmeta/blob/d24ffa5d56a7859f960914f256fb1694b8e8dbaa/data/minecraft/worldgen/configured_feature/large_basalt_columns.json#L9 So technically the canPlaceAt can be given a position up to 2 to 3 blocks outside the currently generating chunk. In vanilla worldgen, this is ok as the surrounding 8 touching chunks (3x3 chunk area centered on generating chunk) are all at or past the CARVERS chunkstatus iirc. Vanilla has to do that because stuff like trees or ores or anything bigger than 1 block wide ends up bleeding into side chunks due to the 0-15 block x/z randomization most placed features have can put them right on the edge of the currently generating chunk.

59 replies

DHDistant Horizons

•Created by Ommelette on 4/17/2024 in #help-me

Repurposed Structures log spam

In this case, it should be DhLitWorldGenRegion region

59 replies

DHDistant Horizons

•Created by Ommelette on 4/17/2024 in #help-me

Repurposed Structures log spam

it's the levelaccess that is passed to the placedfeature's generate methods

59 replies

DHDistant Horizons

•Created by Ommelette on 4/17/2024 in #help-me

Repurposed Structures log spam

like same instance

59 replies

DHDistant Horizons

•Created by Ommelette on 4/17/2024 in #help-me

Repurposed Structures log spam

Is the chunk you're updating, the same chunk from LevelAccessor when given the same chunk pos

59 replies

DHDistant Horizons

•Created by Ommelette on 4/17/2024 in #help-me

Repurposed Structures log spam

The logging worked as it was pointing out a possible bug/issue

59 replies

DHDistant Horizons

•Created by Ommelette on 4/17/2024 in #help-me

Repurposed Structures log spam

The bug is Distant Horizon is generating the chunks through their stages but the chunk's chunkstatus is not being updated as it does so.

59 replies

DHDistant Horizons

•Created by Ommelette on 4/17/2024 in #help-me

Repurposed Structures log spam

@Hencoat (Renowned Author) pulling you here so you dont need to check other discords for updates

59 replies

DHDistant Horizons

•Created by Ommelette on 4/17/2024 in #help-me

Repurposed Structures log spam

59 replies

DHDistant Horizons

•Created by Ommelette on 4/17/2024 in #help-me

Repurposed Structures log spam

The logging code

59 replies

DHDistant Horizons

•Created by Ommelette on 4/17/2024 in #help-me

Repurposed Structures log spam

59 replies

DHDistant Horizons

•Created by Ommelette on 4/17/2024 in #help-me

Repurposed Structures log spam

To the dev of distant horizon, how exactly does that mod work. Did you put something out a week or more ago that is somehow generating features in chunks without promoting the chunk status of the chunk? If so, why? That shouldn’t be possible and greatly concerning to me.

59 replies

DHDistant Horizons

•Created by Ommelette on 4/17/2024 in #help-me

Repurposed Structures log spam

This means this should never be able to be triggered https://github.com/TelepathicGrunt/RepurposedStructures/blob/8c0e38008be4ed2984a151437bb3928741bb6cfd/common/src/main/java/com/telepathicgrunt/repurposedstructures/mixins/features/NoBasaltColumnsInStructuresMixin.java#L37

59 replies

DHDistant Horizons

•Created by Ommelette on 4/17/2024 in #help-me

Repurposed Structures log spam

Minecraft worldgen is done in a specific way that no features should generating in chunks BEFORE the chunk passes the structure start phase

59 replies

DHDistant Horizons