Gambet
Gambet
Tidy5e Upgrade for Dnd5e 2.2.X and Bug fixing
Yeah I like his suggestion of defaulting it to white/grayed out by default, but allowing it to be configurable.
2296 replies
Tidy5e Upgrade for Dnd5e 2.2.X and Bug fixing
That's a great idea.
2296 replies
Tidy5e Upgrade for Dnd5e 2.2.X and Bug fixing
No description
2296 replies
Tidy5e Upgrade for Dnd5e 2.2.X and Bug fixing
@kgar Another small suggestion. I noticed you changed the icon color for attuned items. In the original module an attuned item would be white if Attuned, and Orange if Not Attuned. In your version, Orange is now Attuned, and grayed out is Not Attuned. I think this is confusing for two reasons. For one, it's essentially the exact opposite of the original module, although you're certainly welcome to be different from it, but I imagine lots of people switching over to your module will have a moment like I just did, where they think all of their players' attuned items were suddenly unattuned in the module switch. The other reason this is confusing though is that orange/red is usually intuited as a stop/bad/deactivated color. It also is the only icon to behave differently than the rest of the inventory icons. Favoriting and Equipping items for instance go from grayed out to white, and all of the active buttons are white. This attunement icon is the only one that follows different rules, which I think just makes it kind of stand out in a bad way. My suggestion would be to go back to either how the other module did it, with orange being Unattuned, and White being Attuned, or make it uniform with the other buttons, and have it Grayed Out for Unattuned, and White for Attuned. That said, if you just like it this way, it's not that hard to get used to, but I do think it's unintuitive, which is generally not ideal in UX design IMHO! But just my two cents!
2296 replies
Tidy5e Upgrade for Dnd5e 2.2.X and Bug fixing
That all makes perfect sense! Thank you!
2296 replies
Tidy5e Upgrade for Dnd5e 2.2.X and Bug fixing
@kgar Might be a stupid question, but is there a reason why modules that add a tab to the default Foundry Sheet, and the old Tidy5e sheet, doesn't work with your version? I use an older module that hasn't been updated in months, but still works fine on the most up to date version of Foundry/DnD5e system, called Crash's Tracking & Training, but either it's not compatible with your module or I haven't figured out how to enable it yet. Here's the link to the module if that helps at all: https://github.com/crash1115/5e-training
2296 replies
Tidy5e Upgrade for Dnd5e 2.2.X and Bug fixing
That's really it, honestly. It's a testament to all your hard work that the only things I can point out at this point are very minor things that might just come down to personal preference!
2296 replies
Tidy5e Upgrade for Dnd5e 2.2.X and Bug fixing
No description
2296 replies
Tidy5e Upgrade for Dnd5e 2.2.X and Bug fixing
No description
2296 replies
Tidy5e Upgrade for Dnd5e 2.2.X and Bug fixing
No description
2296 replies
Tidy5e Upgrade for Dnd5e 2.2.X and Bug fixing
It's only just been released to Alpha. My understanding is he intends to do a beta too before considering it fully released, so we've probably got a bit more of a wait.
2296 replies
Tidy5e Upgrade for Dnd5e 2.2.X and Bug fixing
IMO one of the most important things for this rework is to not commit the same mistakes of the original, and adding in a bunch of feature creep that makes it less and less maintainable.
2296 replies
Tidy5e Upgrade for Dnd5e 2.2.X and Bug fixing
Honestly it should probably be done by core, but I basically agree it has no business being stored in this module. At best the Journal entry area gives you the ability to sloppily write them down for future use, but that's about as far as it should go IMO.
2296 replies
Tidy5e Upgrade for Dnd5e 2.2.X and Bug fixing
@kgar Finally had a chance to check out your module. I LOVE how fast it seems to run. It is noticeably smoother than the original, which feels really good! Great job! Couple minor things I've noticed: 1. When the sheet is locked, you're still able to click on the circle or check marks next to the skill list and change the proficiency on them, which IIRC we had talked about a month or two ago and I thought you said you fixed. Maybe I'm misremembering but I just thought I'd mention it. 2. The formatting gets a bit wonky when an item has Attunement. The icon for Attunement seems to shift all the icons for equipping, favoriting, editing, deleting, etc., crushing them together a bit. Not really a big deal, but kind of messy. 3. Having the Sheet Settings directly on the character sheet feels like a mistake to me. I feel like players are gonna mess with the settings because they're so easily accessible, mess it up, and not know how to fix it. I recognize that this might just be my own paranoia, but it also seems weird that you can't access the settings through the actual main Settings Page. 4. Pact Magic is showing a button for preparing the spell, but there's no reason for that, in the same way you wouldn't have this for Innate Spellcasting or At Will Spellcasting. There's probably more things, but so far they all seem minor. There are big things like module compatibility but I know that's further down the road. Great job!
2296 replies
Tidy5e Upgrade for Dnd5e 2.2.X and Bug fixing
Minor feature request @kgar that might already be implemented. In the original Tidy5e, NPC inventories don't show the number of items unless you hover over the specific item or open it up into its own window. It'd be really nice if the Inventory always showed how many items an NPC had, the same as it does with PC sheets. It really helps for keeping track of things like Arrows and what not, for those of us who do that.
2296 replies
Tidy5e Upgrade for Dnd5e 2.2.X and Bug fixing
Personally no. In 3 years of playing on Foundry 2-3 times a week I have never had a character possess more than half a dozen effects on their token. And I use a lot of modules that really add a lot of effects, and it's just never been an issue finding them.
2296 replies
Tidy5e Upgrade for Dnd5e 2.2.X and Bug fixing
Appreciate you!
2296 replies
Tidy5e Upgrade for Dnd5e 2.2.X and Bug fixing
Sounds good!
2296 replies
Tidy5e Upgrade for Dnd5e 2.2.X and Bug fixing
And just have the sections be invisible unless it has at least 1 item in it, the same way the Legendary Resistances counter doesn't show unless it's being used.
2296 replies
Tidy5e Upgrade for Dnd5e 2.2.X and Bug fixing
Photoshop, lol
2296 replies