dibbo Comments - Answer Overflow

dibbo

•Created by dibbo on 1/26/2025 in #questions

Intersection/Union Validation Errors

Yeah very true. The in-editor experience can be great when the branching kicks in, but I suppose it's all about balance. Thanks David!

11 replies

Aarktype

•Created by dibbo on 1/26/2025 in #questions

Intersection/Union Validation Errors

Yeah I think using a single object would make life a lot easier in this scenario.

Honestly avoiding those kind of unions is actually good practice in every context both for runtime validation and within TS itself

Is this for performance or maintenance/our own sanity reasons?

11 replies

Aarktype

•Created by dibbo on 1/26/2025 in #questions

Intersection/Union Validation Errors

Ah, that makes sense, thanks for clarifying. Slightly related: this came about because of errors I was seeing while using the react-hook-form resolver for ArkType - the error from rhf wasn't specifying any key at all for errors in a (sort of) complex union/intersection type which was concerning. I noticed the resolver is using an outdated version of ArkType - do you think the lack of keys in the error feedback is because of the outdated library, or is there a chance the type is too complex to work out what's going wrong? I appreciate there's a lot of unknowns in there, just thought I would raise it/ask 😄

11 replies

Aarktype

•Created by dibbo on 12/18/2024 in #questions

Best way of sharing/compiling types?

Thats cool though, thanks for the reply! A monorepo might make more sense for this setup.. I'll draw up some pros and cons and see where I land haha

7 replies

Aarktype

•Created by dibbo on 12/18/2024 in #questions

Best way of sharing/compiling types?

Close enough! 😄

7 replies

Aarktype

•Created by dibbo on 11/3/2024 in #questions

Generic middleware validator

Thank you!

10 replies

Aarktype

•Created by dibbo on 11/3/2024 in #questions

Generic middleware validator

Hey @ssalbdivad I've updated https://github.com/bgribben/type-issue to use my own recursive type for the middleware

type Chain<T = APIGatewayProxyEventV2> = {
  (event: APIGatewayProxyEventV2): Promise<void>;
  use: <K extends Middleware>(
    middleware: K
  ) => Chain<
    keyof ReturnType<K["before"]> extends keyof T
      ? Omit<T, keyof ReturnType<K["before"]>> & ReturnType<K["before"]>
      : T & ReturnType<K["before"]>
  >;
  handler: (fn: HandlerFn<T>) => void;
};

type Chain<T = APIGatewayProxyEventV2> = {
  (event: APIGatewayProxyEventV2): Promise<void>;
  use: <K extends Middleware>(
    middleware: K
  ) => Chain<
    keyof ReturnType<K["before"]> extends keyof T
      ? Omit<T, keyof ReturnType<K["before"]>> & ReturnType<K["before"]>
      : T & ReturnType<K["before"]>
  >;
  handler: (fn: HandlerFn<T>) => void;
};

and I'm still seeing the issue with the following usage

const validate = <T extends Type>(
  validator: T
): Middleware<{ body: T["infer"] }> => ({
  before: (event) => {
    if (!event.body) return { statusCode: 400 };
    const result = validator(event.body);
    if (result instanceof type.errors) {
      throw new Error(result.summary);
    }
    event.body = result;
    return event;
  },
  after: () => {},
});

const handleCreatePet = chain()
  .use(validate(createPetPayload))
  .handler(async ({ body }) => {});

const handleUpdatePet = chain()
  .use(validate(updatePetPayload))
  .handler(async ({ body }) => {});

const validate = <T extends Type>(
  validator: T
): Middleware<{ body: T["infer"] }> => ({
  before: (event) => {
    if (!event.body) return { statusCode: 400 };
    const result = validator(event.body);
    if (result instanceof type.errors) {
      throw new Error(result.summary);
    }
    event.body = result;
    return event;
  },
  after: () => {},
});

const handleCreatePet = chain()
  .use(validate(createPetPayload))
  .handler(async ({ body }) => {});

const handleUpdatePet = chain()
  .use(validate(updatePetPayload))
  .handler(async ({ body }) => {});

The strange thing is if I move handleUpdatePet above handleCreatePet, the error disappears At a glance, would you know why the order of the calls impacts the output of TS? Apologies for the direct ping, but if you get a second to check out the error in the repo, it would be greatly appreciated. Thanks!

10 replies

Aarktype

•Created by dibbo on 11/3/2024 in #questions

Generic middleware validator

This might be an issue with the middy library, or at least how I'm using it. One call to use seems to impact the other e.g.

const handleCreatePet = middy()
  .use(validateBody(createPetPayload))
  .handler(async ({ body }) => {});

const handleUpdatePet = middy()
  .use(validateBody(updatePetPayload))
  .handler(async ({ body }) => {});

const handleCreatePet = middy()
  .use(validateBody(createPetPayload))
  .handler(async ({ body }) => {});

const handleUpdatePet = middy()
  .use(validateBody(updatePetPayload))
  .handler(async ({ body }) => {});

in this instance, commenting out the handleCreatePet gets rid of the Type instantiation is excessively deep and possibly infinite error in handleUpdatePet. I have no idea how they could impact each other, gonna do some digging to see if I'm even using the library correctly 🙃

10 replies

Aarktype

•Created by dibbo on 11/3/2024 in #questions

Generic middleware validator

I think that should show the issue, thanks for looking into this

10 replies

Aarktype

•Created by dibbo on 11/3/2024 in #questions

Generic middleware validator

https://github.com/bgribben/type-issue

10 replies

Aarktype

•Created by dibbo on 11/3/2024 in #questions

Generic middleware validator

Sure. I've moved the call outside of the middleware chain i.e.

const test = validateBody(schema);

const test = validateBody(schema);

and I'm still seeing the error so I think we can rule out use/handler interfering with it. Here are the other types

// From @middy/core
declare type MiddlewareFn<
  TEvent = any,
  TResult = any,
  TErr = Error,
  TContext extends LambdaContext = LambdaContext,
  TInternal extends Record<string, unknown> = {}
> = (request: Request<TEvent, TResult, TErr, TContext, TInternal>) => any

export interface MiddlewareObj<
  TEvent = unknown,
  TResult = any,
  TErr = Error,
  TContext extends LambdaContext = LambdaContext,
  TInternal extends Record<string, unknown> = {}
> {
  before?: MiddlewareFn<TEvent, TResult, TErr, TContext, TInternal>
  after?: MiddlewareFn<TEvent, TResult, TErr, TContext, TInternal>
  onError?: MiddlewareFn<TEvent, TResult, TErr, TContext, TInternal>
  name?: string
}

// My own ValidatedBody type 
type ValidatedBody<T> = Omit<APIGatewayProxyEventV2, "body"> & {
  body: T;
};

// From @middy/core
declare type MiddlewareFn<
  TEvent = any,
  TResult = any,
  TErr = Error,
  TContext extends LambdaContext = LambdaContext,
  TInternal extends Record<string, unknown> = {}
> = (request: Request<TEvent, TResult, TErr, TContext, TInternal>) => any

export interface MiddlewareObj<
  TEvent = unknown,
  TResult = any,
  TErr = Error,
  TContext extends LambdaContext = LambdaContext,
  TInternal extends Record<string, unknown> = {}
> {
  before?: MiddlewareFn<TEvent, TResult, TErr, TContext, TInternal>
  after?: MiddlewareFn<TEvent, TResult, TErr, TContext, TInternal>
  onError?: MiddlewareFn<TEvent, TResult, TErr, TContext, TInternal>
  name?: string
}

// My own ValidatedBody type 
type ValidatedBody<T> = Omit<APIGatewayProxyEventV2, "body"> & {
  body: T;
};

Here's a CodeSandbox link to the ark schemas and their usage

10 replies

Aarktype

•Created by PIat on 9/17/2024 in #questions