Nathan
Nathan
PostsComments
FFilament
Created by Nathan on 11/17/2023 in #❓┊help
Column grow doesn't work outside of Split/Stack
Marking this as done, as it was rolled into v3.1.
21 replies
FFilament
Created by Nathan on 11/17/2023 in #❓┊help
Column grow doesn't work outside of Split/Stack
Thank you
21 replies
FFilament
Created by Nathan on 11/17/2023 in #❓┊help
Column grow doesn't work outside of Split/Stack
PR was accepted an merged; just waiting on a new release to include it.
21 replies
FFilament
Created by Nathan on 11/17/2023 in #❓┊help
Column grow doesn't work outside of Split/Stack
PR submitted
21 replies
FFilament
Created by Nathan on 11/17/2023 in #❓┊help
Column grow doesn't work outside of Split/Stack
Unfortunately, I'm not familiar enough with the code to tell if this change negatively impacts anything else, nor if it's comprehensive enough to apply everywhere it needs to.
21 replies
FFilament
Created by Nathan on 11/17/2023 in #❓┊help
Column grow doesn't work outside of Split/Stack
https://github.com/nmalinoski/filament-grow-column-not-working This is the example project I put together for my bug report https://github.com/filamentphp/filament/issues/9933; and this is my branch of 3.x with the change that makes column grow work for me: https://github.com/filamentphp/filament/compare/3.x...nmalinoski:filament:9933-apply-column-grow-to-html-column
21 replies
FFilament
Created by Nathan on 11/17/2023 in #❓┊help
Column grow doesn't work outside of Split/Stack
I'll see about putting together the kind of example the bug report form asks for.
21 replies
FFilament
Created by Nathan on 11/17/2023 in #❓┊help
Column grow doesn't work outside of Split/Stack
I guess I'm not understanding why adding the grow classes on the HTML table works if it's not compatible
21 replies
FFilament
Created by Nathan on 11/17/2023 in #❓┊help
Column grow doesn't work outside of Split/Stack
And Split doesn't support label
21 replies
FFilament
Created by Nathan on 11/17/2023 in #❓┊help
Column grow doesn't work outside of Split/Stack
Ok, well, that works, but now I don't have column headings 🤦‍♂️
21 replies
FFilament
Created by Nathan on 11/17/2023 in #❓┊help
Column grow doesn't work outside of Split/Stack
I dug into what grow is supposed to apply, and I found that it simply determines whether a layout component for a column gets flex-1 w-full classes; and, if I manually apply those to the th element of the column I want to grow, it has the effect I want.
21 replies
FFilament
Created by Nathan on 11/17/2023 in #❓┊help
Column grow doesn't work outside of Split/Stack
I'll try encapsulating everything in a Split, then.
21 replies
FFilament
Created by Nathan on 11/17/2023 in #❓┊help
Column grow doesn't work outside of Split/Stack
No, they do, through the parent and the CanGrow concern
21 replies
FFilament
Created by Nathan on 11/17/2023 in #❓┊help
Column grow doesn't work outside of Split/Stack
Do TextColumns not support grow?
21 replies