toasty Comments - Answer Overflow

I think its best to pin to a specific version, since new versions usually come out with a new max version. So they'll never be backwards compatible (until Mojo hits a level of stability)

494 replies

MModular

•Created by Jack Clayton on 5/11/2024 in #community-showcase

Lightbug HTTP: Mojo web framework

Great! 👍

494 replies

MModular

•Created by Jack Clayton on 5/11/2024 in #community-showcase

Lightbug HTTP: Mojo web framework

try pinning to "=0.1.16" instead?

494 replies

MModular

•Created by Jack Clayton on 5/11/2024 in #community-showcase

Lightbug HTTP: Mojo web framework

It does look like @a2svior already updated the recipe 🤔 can you show the versions of lightbug_http and max you’re using?

494 replies

MModular

•Created by Jack Clayton on 5/11/2024 in #community-showcase

Lightbug HTTP: Mojo web framework

Part of the build and deploy process for the package into the conda channel

494 replies

MModular

•Created by Jack Clayton on 5/11/2024 in #community-showcase

Lightbug HTTP: Mojo web framework

Ohh the recipe file was probably missed again, I’ll open a pr to update it later today if that was the problem

494 replies

MModular

•Created by Jack Clayton on 5/11/2024 in #community-showcase

Lightbug HTTP: Mojo web framework

@a2svior Looks like the recipe needs to be updated: https://github.com/Lightbug-HQ/lightbug_http/blob/main/recipes/recipe.yaml#L22

494 replies

MModular

•Created by Jack Clayton on 5/11/2024 in #community-showcase

Lightbug HTTP: Mojo web framework

Nope that’s right! I changed the versioning scheme

494 replies

MModular

•Created by Jack Clayton on 5/11/2024 in #community-showcase

Lightbug HTTP: Mojo web framework

Yeah, your installation for some reason is pulling a version of small_time that’s old. I’m assuming it’s still 0.1.6, which is from mojo 24.6. If you create a new project and add in lightbug, do you get the same behavior?

494 replies

MModular

•Created by Jack Clayton on 5/11/2024 in #community-showcase

Lightbug HTTP: Mojo web framework

@a2svior I pushed a new version with a looser version pin

494 replies

MModular

•Created by Jack Clayton on 5/11/2024 in #community-showcase

Lightbug HTTP: Mojo web framework

I will update it to a version range between >25.1.0,<25.2.0 later. In the meantime you should be good if you use 25.1.0?

494 replies

MModular

•Created by Jack Clayton on 5/11/2024 in #community-showcase

Lightbug HTTP: Mojo web framework

Ah, max version 25.1.1? And small-time’s latest version is 0.1.8. I pinned it to 25.1.0 only, so that’s why you’re seeing an issue

494 replies

MModular

•Created by Jack Clayton on 5/11/2024 in #community-showcase

Lightbug HTTP: Mojo web framework

I have not yet, but if you run magic list what version of lightbug, max, and smalltime are present in your env?

494 replies

MModular

•Created by Jack Clayton on 5/11/2024 in #community-showcase

Lightbug HTTP: Mojo web framework

We should check if content-length > 0 before trying to read the body, and we should also skip any leading \r\n before reading the body. There was a leading \r\n that consumed 2 bytes that was expected in the body itself, so that's why you saw go truncated off the end.

494 replies

MModular

•Created by Jack Clayton on 5/11/2024 in #community-showcase

Lightbug HTTP: Mojo web framework

I think I fixed the bug, I will open a PR for it

494 replies

MModular

•Created by Jack Clayton on 5/11/2024 in #community-showcase

Lightbug HTTP: Mojo web framework

I was mistaken, HTTPrequest does not implement repr at the moment, but I'm trying to run print(repr(req.get_body())) to check on the newlines present. I ran it with no body and it looks fine, I see 2 CRLF (\r\n\r\n) which is correct, but I need to test it with a request that has a body. I don't think we have an unit tests for request parsing that includes a body yet.

494 replies

MModular

•Created by Jack Clayton on 5/11/2024 in #community-showcase

Lightbug HTTP: Mojo web framework

If you repr the request, are there 3 \r\n before the request body?

494 replies

Gaming

Programming