slim (jamesc)
Special characters in server function error may crash app
Can someone verify this please? I could not get my version of Firefox to work with stackblitz, but I see this in two different versions of chromium.
Observe that navigating back and forth ("About" / "Index") works, then uncomment the throw error with special characters in the string, then try navigating back and forth. reproduction
Observe that navigating back and forth ("About" / "Index") works, then uncomment the throw error with special characters in the string, then try navigating back and forth. reproduction
5 replies
Second component instantiation has no owner when under vinxi start in a npm linked component
Anyone tried linked components? I have a reproduction where
https://github.com/nksaraf/vinxi/issues/473 I'm simply using
getOwner() goes null and this happens in an application I'm upgrading from solid-start 0.3.11 (worked under pnpm link). Seems like this would be something in vinxi, but I'm not sure. Could there be an issue in Solid-Js?https://github.com/nksaraf/vinxi/issues/473 I'm simply using
npm i --save ./cmp which saves the folder as a file link "file:cmp" in package.json. Then (in the reproduction), I installed solid-js in cmp and create a component that logs getOwner() and then I included that component in the parent solid starter route/index.tsx.12 replies
vxini seems to be packaging and shipping all server code to the client
I'm trying to upgrade from solid-start 0.3.11 to the latest @solidjs/start. My smallest page load went from 1MB to 63MB. Under the browser's source tab, I can see that
vinxi dev seams to be sending every JavaScript file in my project, probably even code accessed only from "use server" functions (although I can't be 100% sure yet). I understand I should wrap code in isServer conditions which, prior, I only used when necessary and I'm confused why there is such big change to cause so much code to load. This is all in one page load as well.
Adding more isServer functions for tree-shaking will be a lot of changes, I would like to know a bit about what is going on first and make sure I'm doing everything I can using app.config.js. The first thing that raised a red flag was all the rollup warnings about externalizing many node packages which mostly went away when I added rollupOptions.external: [/^node:/] .. How did solid-start 0.3.11 know not to import all of the node packages without this external pattern? Is there something I can do or something I can disable to get things running more like solid-start 0.3.11 so I can slowly transition into more of a isServer tree-shaking approach? It seams that 0.3.11 was doing a better job, although I'm sure there are good reasons for changing this. But with 0.3.11 I never encountered any issues with missing client-side code.
Thank you for any insight that would help me better navigate how to tackle this one!40 replies
Server functions returning page not found
After trying to upgrade to solid-start 0.3.11, I picked up a bug that did not exist in 0.3.10. The strange thing is, downgrading did not fix it. There are server-functions that, instead of running, return my 404 not found page. Any idea how to debug this? My app is not usable.
Could this be related to pnpm workspaces? This server function still works and it is in my main package: https://code.local:3000/_m/src/services/fetchMember.tsx/0/fetchValidatorMembers But this one, imported from another package in the repo, returns a 404 not found html page: https://code.local:3000/_m/home/james/dev/ipall/nol-core/src/stores/cause.tsx/0/fetchCauses In the later, should it really have use the path from the "/" root (with /home/james/dev) in it? "ipall" is the work-space root. Again, this was working for a long time and I did have to hack it. I don't really the exact path though. I have never deployed the app, so I must have gotten it to work somehow then after messing with things this broke. No code changed, I just tried upgrading to 0.3.11 to get this issue and the downgrade does not fix it. I tried various pnpm things like removing the node_modules everywhere, force install, cache clear. I'll should probably start building the 0.3.10 branch and figure out how the server-functions work. If you have any advice on getting setup and debugged server-functions I would appreciate it.
Could this be related to pnpm workspaces? This server function still works and it is in my main package: https://code.local:3000/_m/src/services/fetchMember.tsx/0/fetchValidatorMembers But this one, imported from another package in the repo, returns a 404 not found html page: https://code.local:3000/_m/home/james/dev/ipall/nol-core/src/stores/cause.tsx/0/fetchCauses In the later, should it really have use the path from the "/" root (with /home/james/dev) in it? "ipall" is the work-space root. Again, this was working for a long time and I did have to hack it. I don't really the exact path though. I have never deployed the app, so I must have gotten it to work somehow then after messing with things this broke. No code changed, I just tried upgrading to 0.3.11 to get this issue and the downgrade does not fix it. I tried various pnpm things like removing the node_modules everywhere, force install, cache clear. I'll should probably start building the 0.3.10 branch and figure out how the server-functions work. If you have any advice on getting setup and debugged server-functions I would appreciate it.
5 replies