Micha Comments - Answer Overflow

import { Hono } from 'hono';
import { createBunWebSocket } from 'hono/bun';
import { WSContext } from 'hono/dist/types/helper/websocket';

const { upgradeWebSocket, websocket } = createBunWebSocket();

const app = new Hono();
const webSocketClients: WSContext[] = [];

app.get('/', upgradeWebSocket(() => {
  let _ws: WSContext;
  
  return {
    onOpen(_, ws: WSContext) {
      _ws = ws;
      webSocketClients.push(ws);
    },
    onMessage(event) {
      webSocketClients.forEach(webSocketClient => { // broadcast
        if (webSocketClient === _ws) { return; } // possible to check, if current `webSocketClient` is sender
        webSocketClient.send(`${event.data}`);
      });
    },
    onClose() {
      const disconnectedWebSocketClientIndex = webSocketClients.indexOf(_ws);
      if (disconnectedWebSocketClientIndex === -1) { return; }
      
      webSocketClients.splice(disconnectedWebSocketClientIndex, 1);
    }
  };
}));

Bun.serve({
  fetch: app.fetch,
  websocket
});

import { Hono } from 'hono';
import { createBunWebSocket } from 'hono/bun';
import { WSContext } from 'hono/dist/types/helper/websocket';

const { upgradeWebSocket, websocket } = createBunWebSocket();

const app = new Hono();
const webSocketClients: WSContext[] = [];

app.get('/', upgradeWebSocket(() => {
  let _ws: WSContext;
  
  return {
    onOpen(_, ws: WSContext) {
      _ws = ws;
      webSocketClients.push(ws);
    },
    onMessage(event) {
      webSocketClients.forEach(webSocketClient => { // broadcast
        if (webSocketClient === _ws) { return; } // possible to check, if current `webSocketClient` is sender
        webSocketClient.send(`${event.data}`);
      });
    },
    onClose() {
      const disconnectedWebSocketClientIndex = webSocketClients.indexOf(_ws);
      if (disconnectedWebSocketClientIndex === -1) { return; }
      
      webSocketClients.splice(disconnectedWebSocketClientIndex, 1);
    }
  };
}));

Bun.serve({
  fetch: app.fetch,
  websocket
});

25 replies

HHono

•Created by blurSkye 🇵🇸🍉 on 6/7/2024 in #help

websocket issue

25 replies

HHono

•Created by blurSkye 🇵🇸🍉 on 6/7/2024 in #help

websocket issue

@blurSkye 🇵🇸🍉 I guess, I found a workaround. I tried to store the ws object in a local variable _ws to create a closure like behavior. _ws can then be used later on in every other event like onMessage or onClose. It doesn't seem like a general good solution, because we just omit the provided ws object in the other events. But as a workaround, it works 😄

25 replies

Gaming

Programming