Fisban Regner Posts - Answer Overflow

Fisban Regner

•Created by Fisban Regner on 7/8/2023 in #djs-questions

Issue adding and removing roles in same command

I have a select menu command where you select the roles you want to add/remove from a list when roles are selected it checks if the user has the roles already, what roles didn't get elected and removes the unselected roles and add the selected roles. this issue I am having is when I combine the roles.add and the roles.remove the member roles remain unchanged and no error is given.

try {
  if (rolesToAdd.length >= 1 && rolesToRemove.length >= 1) {
    await interaction.member.roles.remove(rolesToRemove);
    await interaction.member.roles.add(rolesToAdd);
  }
  if (rolesToAdd.length >= 1) {
    console.log('add roles');
    await interaction.member.roles.add(rolesToAdd).catch(console.error);
  }
  if (rolesToRemove.length >= 1) {
    console.log('remove roles');
    await interaction.member.roles.remove(rolesToRemove).catch(console.error);
  }
}
catch (err) {return console.log(err);}

try {
  if (rolesToAdd.length >= 1 && rolesToRemove.length >= 1) {
    await interaction.member.roles.remove(rolesToRemove);
    await interaction.member.roles.add(rolesToAdd);
  }
  if (rolesToAdd.length >= 1) {
    console.log('add roles');
    await interaction.member.roles.add(rolesToAdd).catch(console.error);
  }
  if (rolesToRemove.length >= 1) {
    console.log('remove roles');
    await interaction.member.roles.remove(rolesToRemove).catch(console.error);
  }
}
catch (err) {return console.log(err);}

9 replies

Gaming

Programming