Rodry
Rodry
DIAdiscord.js - Imagine an app
Created by Rodry on 6/8/2024 in #djs-questions
Readonly array in message options interface
I do have a tsconfig I can even send it here if you really want
127 replies
DIAdiscord.js - Imagine an app
Created by Rodry on 6/8/2024 in #djs-questions
Readonly array in message options interface
I didn't even picked that version I just checked whatever my test bot had
127 replies
DIAdiscord.js - Imagine an app
Created by Rodry on 6/8/2024 in #djs-questions
Readonly array in message options interface
idk what else you want me to show you, it literally does not error
127 replies
DIAdiscord.js - Imagine an app
Created by Rodry on 6/8/2024 in #djs-questions
Readonly array in message options interface
I'm sure of that
127 replies
DIAdiscord.js - Imagine an app
Created by Rodry on 6/8/2024 in #djs-questions
Readonly array in message options interface
I am
127 replies
DIAdiscord.js - Imagine an app
Created by Rodry on 6/8/2024 in #djs-questions
Readonly array in message options interface
that's probably a tsconfig rule then because it literally does not error for me as you can see right above
127 replies
DIAdiscord.js - Imagine an app
Created by Rodry on 6/8/2024 in #djs-questions
Readonly array in message options interface
when you don't do extensive testing when changing types in this manner it makes sense that it has unwanted side-effects
127 replies
DIAdiscord.js - Imagine an app
Created by Rodry on 6/8/2024 in #djs-questions
Readonly array in message options interface
None of this was even mentioned in the PR, it just said "we're adding this rule because yeah" and went on with it, no before and after or even a motivation behind the change
127 replies
DIAdiscord.js - Imagine an app
Created by Rodry on 6/8/2024 in #djs-questions
Readonly array in message options interface
feel free to prove me otherwise
127 replies
DIAdiscord.js - Imagine an app
Created by Rodry on 6/8/2024 in #djs-questions
Readonly array in message options interface
I think this is all just a bunch of theoretical correctness that doesn't translate to practicality or any actual real benefit in the real world
127 replies
DIAdiscord.js - Imagine an app
Created by Rodry on 6/8/2024 in #djs-questions
Readonly array in message options interface
No description
127 replies
DIAdiscord.js - Imagine an app
Created by Rodry on 6/8/2024 in #djs-questions
Readonly array in message options interface
you know it's true though, just open #djs-help-v14 for 5 minutes
127 replies
DIAdiscord.js - Imagine an app
Created by Rodry on 6/8/2024 in #djs-questions
Readonly array in message options interface
no I didn't. I've literally been saying it makes sense, it just doesn't add anything valuable to the DX because we don't use readonly stuff often in a discord bot and the average user in this server doesn't know what that is. I mentioned it may not be 100% correct due to some edge cases where the arrays are modified but I don't have the data or the exact lines to show you nor do I give a shit, so let's just talk about what matters shall we
127 replies
DIAdiscord.js - Imagine an app
Created by Rodry on 6/8/2024 in #djs-questions
Readonly array in message options interface
Can we stay on the topic?
127 replies
DIAdiscord.js - Imagine an app
Created by Rodry on 6/8/2024 in #djs-questions
Readonly array in message options interface
My point is that, for many methods, what you pass to djs isn't what discord receives - just look at files for example - and that's fine, but you're completely replacing what the user sent with a parsed version, that doesn't seem very readonly to me
127 replies
DIAdiscord.js - Imagine an app
Created by Rodry on 6/8/2024 in #djs-questions
Readonly array in message options interface
I am saying the principle behind the change makes sense, but it creates this issue which cannot be avoided in any way other than by forcing types, which is unsafe and you shouldn't be promoting that. Other than that, this change benefits close to no one because most people don't use the readonly keyword in a discord bot, just look at your average user here and you can see that very clearly
127 replies
DIAdiscord.js - Imagine an app
Created by Rodry on 6/8/2024 in #djs-questions
Readonly array in message options interface
once again that is not the main point I'm focusing on, I'm not trying to argue whether this change makes sense or not, I'm trying to draw attention to the issues it created and trying to find a solution
127 replies
DIAdiscord.js - Imagine an app
Created by Rodry on 6/8/2024 in #djs-questions
Readonly array in message options interface
well it's not like there's much of an alternative is there
127 replies
DIAdiscord.js - Imagine an app
Created by Rodry on 6/8/2024 in #djs-questions
Readonly array in message options interface
but that was not the main point of that message anyway
127 replies
DIAdiscord.js - Imagine an app
Created by Rodry on 6/8/2024 in #djs-questions
Readonly array in message options interface
just in the context of messages, the files are parsed and embeds and components are turned from builders to objects when applicable
127 replies