RyanWAnderson Comments - Answer Overflow

RyanWAnderson

Posts Comments

TTyphonJS

•Created by RyanWAnderson on 5/2/2023 in #typhonjs-runtime

Actor update error, TRL/Svelte Token interaction?

Yes that would work just fine. I just need to know where the render call is coming from.

45 replies

TTyphonJS

•Created by RyanWAnderson on 5/2/2023 in #typhonjs-runtime

Actor update error, TRL/Svelte Token interaction?

Will do

45 replies

TTyphonJS

•Created by RyanWAnderson on 5/2/2023 in #typhonjs-runtime

Actor update error, TRL/Svelte Token interaction?

Aaaaaand it was that easy! I made a TokenDocument class that passed options to the render function:

    /**
     * When the base Actor for a TokenDocument changes, we may need to update its Actor instance
     * @param {object} update
     * @param {object} options
     * @internal
     */
    _onUpdateBaseActor(update={}, options={}) {

        // Update synthetic Actor data
        if ( !this.isLinked && this.delta ) {
            this.delta.updateSyntheticActor();
            
// This is the only change lol
this.actor.sheet.render(false, options);
        }

        this._onRelatedUpdate(update, options);
    }

    /**
     * When the base Actor for a TokenDocument changes, we may need to update its Actor instance
     * @param {object} update
     * @param {object} options
     * @internal
     */
    _onUpdateBaseActor(update={}, options={}) {

        // Update synthetic Actor data
        if ( !this.isLinked && this.delta ) {
            this.delta.updateSyntheticActor();
            
// This is the only change lol
this.actor.sheet.render(false, options);
        }

        this._onRelatedUpdate(update, options);
    }

And in my function that updates the actor I passed options.action = 'heropointClick'; then in the ActorSheet's render function I just checked for that action and returned if I found it. Error fixed! Everything works as intended. Now if only we can get this change pushed to live. -_-

45 replies

TTyphonJS

•Created by RyanWAnderson on 5/2/2023 in #typhonjs-runtime

Actor update error, TRL/Svelte Token interaction?

Yup. I'm not sure why token treats its actor sheets separately to begin with. Actor sheet should be the actor sheet, token should be a token. I suspect it's because of the prototype/token difference. Maybe because of NPCs where you want different data for multiple duplicate tokens... I'm also getting some weird desync between player token and actor sheet data. I haven't spent the time to track that down yet but I suspect it's related.

45 replies

TTyphonJS

•Created by RyanWAnderson on 5/2/2023 in #typhonjs-runtime

Actor update error, TRL/Svelte Token interaction?

Awesome, thanks!

45 replies

TTyphonJS

•Created by RyanWAnderson on 5/2/2023 in #typhonjs-runtime

Actor update error, TRL/Svelte Token interaction?

Cool, I'll throw that their way and see what happens.

45 replies

TTyphonJS

•Created by RyanWAnderson on 5/2/2023 in #typhonjs-runtime

Actor update error, TRL/Svelte Token interaction?

They're trying to call an update of the displayed sheet data, we're the ones who are hooking that behavior.

45 replies

TTyphonJS

•Created by RyanWAnderson on 5/2/2023 in #typhonjs-runtime

Actor update error, TRL/Svelte Token interaction?

Issue persists. The functions are written differently now though. It's under

if ( !this.isLinked && this.delta ) {
      this.delta.updateSyntheticActor();
      this.actor.sheet.render(false);
    }

if ( !this.isLinked && this.delta ) {
      this.delta.updateSyntheticActor();
      this.actor.sheet.render(false);
    }

Makes me think this is intended behavior, might should be caught under

actor.sheet.render

actor.sheet.render

instead of at the token

_onUpdateBaseActor

_onUpdateBaseActor

45 replies

TTyphonJS

•Created by RyanWAnderson on 5/2/2023 in #typhonjs-runtime

Actor update error, TRL/Svelte Token interaction?

Oh wow it's all different looking now lol

45 replies

TTyphonJS

•Created by RyanWAnderson on 5/2/2023 in #typhonjs-runtime

Actor update error, TRL/Svelte Token interaction?

I don't have it set up. I'll take a look at it.

45 replies

TTyphonJS

•Created by RyanWAnderson on 5/2/2023 in #typhonjs-runtime

Actor update error, TRL/Svelte Token interaction?

Haven't had time to look at this again until now. I implemented the changes @nekrodarkmoon highlighted above, didn't seem to affect the issue. Going to try overriding token and see what that breaks now.

45 replies

TTyphonJS

•Created by RyanWAnderson on 5/2/2023 in #typhonjs-runtime

Actor update error, TRL/Svelte Token interaction?

That's what I suspected was going on. Thanks for the info! Hopefully v11 will fix it. Until then, it's workaround time!

45 replies

TTyphonJS

•Created by RyanWAnderson on 5/2/2023 in #typhonjs-runtime

Actor update error, TRL/Svelte Token interaction?

45 replies

Gaming

Programming