Hoeken Comments - Answer Overflow

Hoeken

Posts Comments

SKSignal K

•Created by ray_sabado on 9/1/2024 in #questions

Signalk Icon on B&G Zeus

@AdrianP yes it does, but it doesnt give the path to the icon which is needed in this application

80 replies

SKSignal K

•Created by ray_sabado on 9/1/2024 in #questions

Signalk Icon on B&G Zeus

@Teppo Kurki yep i pretty much copied the code from that mfd server code where it gets a list of interfaces from the os and iterates on each of them to do the udp broadcast.

80 replies

SKSignal K

•Created by ray_sabado on 9/1/2024 in #questions

Signalk Icon on B&G Zeus

As it is now, its working just fine with the API, but I'm not sure what will happen with the edge case of someone using a proxy or how widespread that even is. This should all be over the local subnet so I would think a proxy isn't really wanted.

80 replies

SKSignal K

•Created by ray_sabado on 9/1/2024 in #questions

Signalk Icon on B&G Zeus

Then also exposing the

app.config.getSslPort();

app.config.getSslPort();

and

app.config.getHttpPort();

app.config.getHttpPort();

in the config object passed to a plugin would give me all the data needed.

80 replies

SKSignal K

•Created by ray_sabado on 9/1/2024 in #questions

Signalk Icon on B&G Zeus

Probably adding a appIcon and/or webappEnabled flag would be enough information for my plugin.

80 replies

SKSignal K

•Created by ray_sabado on 9/1/2024 in #questions

Signalk Icon on B&G Zeus

If you guys are willing to make changes to the server side, I would think that adding webapp information to the app.getFeatures() call would be the best route.

80 replies

SKSignal K

•Created by ray_sabado on 9/1/2024 in #questions

Signalk Icon on B&G Zeus

For the publish information, I need the plugin name, display name, icon, and protocol/port. I'm not familiar with a proxy setup, but I think you want either the http or ssl port for this and not the proxy port? I just use the IP address of the signalk interface as in the existing code.

80 replies

SKSignal K

•Created by ray_sabado on 9/1/2024 in #questions

Signalk Icon on B&G Zeus

@Teppo Kurki mostly its #2 - I'm getting the plugin data from /skServer/webapps, but in order to do that in a generic way, I need the port and protocol to build that url for the request. if there was a way to get that internally, that would be great.

80 replies

SKSignal K

•Created by ray_sabado on 9/1/2024 in #questions

Signalk Icon on B&G Zeus

There is also no app.config.settings.port or app.config.settings.sslport

80 replies

SKSignal K

•Created by ray_sabado on 9/1/2024 in #questions

Signalk Icon on B&G Zeus

uh oh, i'm back to my original problem... the getSslPort() and getHttpPort() functions arent available in the app.config object that is passed into a plugin.

80 replies

SKSignal K

•Created by ray_sabado on 9/1/2024 in #questions

Signalk Icon on B&G Zeus

    if (app.config.settings.ssl) {
      protocol = 'https';
      port = app.config.getSslPort();
    } else {
      protocol = 'http';
      port = app.config.getHttpPort();      
    }

    if (app.config.settings.ssl) {
      protocol = 'https';
      port = app.config.getSslPort();
    } else {
      protocol = 'http';
      port = app.config.getHttpPort();      
    }

80 replies

SKSignal K

•Created by ray_sabado on 9/1/2024 in #questions

Signalk Icon on B&G Zeus

Is this better?

80 replies

SKSignal K

•Created by ray_sabado on 9/1/2024 in #questions

Signalk Icon on B&G Zeus

ahhhh okay i see what u mean

80 replies

SKSignal K

•Created by ray_sabado on 9/1/2024 in #questions

Signalk Icon on B&G Zeus

This is the plugin calling the rest api because I'm not sure how to access the meta info about plugins otherwise.

80 replies

SKSignal K

•Created by ray_sabado on 9/1/2024 in #questions

Signalk Icon on B&G Zeus

export function getExternalPort(app: WithConfig) {
  if (Number(process.env?.EXTERNALPORT) > 0) {
    return Number(process.env?.EXTERNALPORT)
  }
  if (app.config.settings.proxy_port) {
    return app.config.settings.proxy_port
  }
  return app.config.settings.ssl ? getSslPort(app) : getHttpPort(app)
}

export function getExternalPort(app: WithConfig) {
  if (Number(process.env?.EXTERNALPORT) > 0) {
    return Number(process.env?.EXTERNALPORT)
  }
  if (app.config.settings.proxy_port) {
    return app.config.settings.proxy_port
  }
  return app.config.settings.ssl ? getSslPort(app) : getHttpPort(app)
}