Filament•2w ago

SoftDeletes

I'm using SoftDeletes on my model, and I'm using tabs (all, active, archived) on the resource list, on my db I have 33 entries ( 2 with deleted_at not null). The issue that I don't understand is why when I click on the 'all' tab I got only 31 entries (the deleted ones are excluded) and when I click on 'archived' tab I didn't get any entry (even there are 2 entries on my db). Do anyone has an idea about this issue?

Solution:

The problem was there, because of the trashedFilter, it's applied automatically and it excludes the the trashed records by default. When I get ride of it, things work perfectly as expected.

Jump to solution

31 Replies

MokatchiOP•2w ago

the sql query that I'm getting what ever is the tab selected is: select * from table where table.deleted_at is null Here is my tabs code:

public function getTabs(): array
    {
        return [
           'all' => Tab::make()
                  ->label(__('projProg.all'))
                  ->modifyQueryUsing(fn (Builder $query) => $query->withTrashed()),
           'active' => Tab::make()
                  ->label(__('projProg.active'))
                  ->modifyQueryUsing(fn (Builder $query) => $query->withoutTrashed()),
           'archived' => Tab::make()
                  ->label(__('projProg.archived'))
                  ->modifyQueryUsing(fn (Builder $query) => $query->onlyTrashed()),
        ];
    }

public function getTabs(): array
    {
        return [
           'all' => Tab::make()
                  ->label(__('projProg.all'))
                  ->modifyQueryUsing(fn (Builder $query) => $query->withTrashed()),
           'active' => Tab::make()
                  ->label(__('projProg.active'))
                  ->modifyQueryUsing(fn (Builder $query) => $query->withoutTrashed()),
           'archived' => Tab::make()
                  ->label(__('projProg.archived'))
                  ->modifyQueryUsing(fn (Builder $query) => $query->onlyTrashed()),
        ];
    }

Batman•2w ago

Do you have any filters set anywhere by chance?

toeknee•2w ago

I am guessing you have soft deletes on the scope in the model to exclude them? install telescope and look at the actually reported queries. Maybe provide the the table function too

Batman•2w ago

Shouldn't the withTrashed(), onlyTrashed(), withoutTrashed() work? Aren't they there for models using soft delete?

toeknee•2w ago

They should, but they don’t override existing defines

Batman•2w ago

Ok. I guess that confuses me. I use them in a model with soft deletes and they work as expected. I also commented out my tabs and added his above (changing labels) and it also worked as expected on that model.

toeknee•2w ago

So you would need to check the query being ran and what's happening 🙂 If you setup soft deletes as per Filament's Docs it should be ok, but I suspect something has differred. Possibly the base modify query

MokatchiOP•2w ago

Actually I have another local scope on my model "scopeVisibleToUser" and I'm using it on the table query, so I can personalize the data display of each user. Here is the code of the table:

public static function table(Table $table): Table
    {
        $user = auth()->user();
        return $table
          ->query(parent::getEloquentQuery()
                    ->withoutGlobalScopes([SoftDeletingScope::class])
                    ->visibleToUser($user)->where(function (Builder $query) { ..... })
                  )
          ->columns([
                TextColumn::make('name')           
                ....
                )]
           ->filters([
                TrashedFilter::make(),
                SelectFilter::make('type')
                )];
    }

public static function table(Table $table): Table
    {
        $user = auth()->user();
        return $table
          ->query(parent::getEloquentQuery()
                    ->withoutGlobalScopes([SoftDeletingScope::class])
                    ->visibleToUser($user)->where(function (Builder $query) { ..... })
                  )
          ->columns([
                TextColumn::make('name')           
                ....
                )]
           ->filters([
                TrashedFilter::make(),
                SelectFilter::make('type')
                )];
    }

I used the withoutGlobalScopes([SoftDeletingScope::class]) to force the query to select all the entries from the db, but still not working.

toeknee•2w ago

I wouldnt do that with your query, I would replace to to a modifyQueryUsing method personally to apply the scope. Doing that query overwrites the filters etc it's not very elegant

MokatchiOP•2w ago

by the way, when I'm using the TrashedFilter results I'm gettung are right

toeknee•2w ago

see this: https://filamentphp.com/docs/3.x/panels/resources/deleting-records#handling-soft-deletes

Deleting records - Panels - Filament

MokatchiOP•2w ago

I also replaced the query () by this ->modifyQueryUsing(fn (Builder $query) => $query->withoutGlobalScopes([SoftDeletingScope::class]) but still not working

toeknee•2w ago

Remove it completed, and add:

public static function getEloquentQuery(): Builder
{
    return parent::getEloquentQuery()
        ->withoutGlobalScopes([
            SoftDeletingScope::class,
        ]);
}

public static function getEloquentQuery(): Builder
{
    return parent::getEloquentQuery()
        ->withoutGlobalScopes([
            SoftDeletingScope::class,
        ]);
}

to the resource and I would suggest you scope the model to the user by default

MokatchiOP•2w ago

How can I do this "I would suggest you scope the model to the user by default"? Is it something like this?

class UserScope implements Scope
{
    public function apply(Builder $builder, Model $model)
    {
        if (Auth::check()) {
            $builder->where('user_id', Auth::id());
        }
    }
}

class UserScope implements Scope
{
    public function apply(Builder $builder, Model $model)
    {
        if (Auth::check()) {
            $builder->where('user_id', Auth::id());
        }
    }
}

toeknee•2w ago

yep if building a scope yes. Or you can add it to the boot method if you are not using the scope anywhere else with:

protected static function booted(): void
{
        static::addGlobalScope('UserScope', function ($query) {
            $query->where('user_id', Auth::id());
        });
}

protected static function booted(): void
{
        static::addGlobalScope('UserScope', function ($query) {
            $query->where('user_id', Auth::id());
        });
}

MokatchiOP•2w ago

I tried your suggestion, but still get the same results, the deleted records aren't displayed

toeknee•2w ago

Have you check the query yet with telescope to see what's actually happening?

MokatchiOP•2w ago

not yet, I'm seeing how to use it. I'm only using the dd() for the moment Using telescope, I found the following

select
  count(*) as aggregate
from
  `table`
where
  `table`.`deleted_at` is not null
  and (`table`.`deleted_at` is null)

select
  count(*) as aggregate
from
  `table`
where
  `table`.`deleted_at` is not null
  and (`table`.`deleted_at` is null)

I don't know why the last line is added on all queries (all, active or archived)

toeknee•2w ago

Can you provide your resource class, your list class and your model please.

MokatchiOP•2w ago

okay, can I do it privately? to your account directly? I sent them to your account privately

toeknee•2w ago

Thank you, its because the tabs query works differently to the table. So I believe you need to add the without scopes soft delete class to the tabs queries too.

MokatchiOP•2w ago

I tried several solutions, but the issue still persists. Isn'it something about the core or new update? Because that was working before on January 24th 2025 !? @toeknee @Dan Harrin @Dennis Koch @Hassan Zahirnia @Saade

Carl-bot•2w ago

mymokatchi has been warned, this is their first warning.

Saade•2w ago

Stop pinging people.

toeknee•2w ago

please read the #✅┊rules There's not much we can do, if you want to create a reproduction repo then we can look. But your code is doing something duplicating the queries because the not null.. You could try removing the is trashed etc and just add your own where(deleted not null etc.

MokatchiOP•2w ago

Thank you so much about your concern, but I already tried this solution too and nothing worked. the strange thing is that my code was working correctlly on the date mentionned above, but lately it dosn't work.

Dennis Koch•2w ago

If it's due to a change in Filament, please test which version broke it and file an issue on GitHub.

MokatchiOP•7d ago

The problem wasn't about version updates as I was thinking,

Solution

Mokatchi•7d ago

The problem was there, because of the trashedFilter, it's applied automatically and it excludes the the trashed records by default. When I get ride of it, things work perfectly as expected.

Dennis Koch•7d ago

Yeah, that's the expected behaviour, because SoftDeletes are ... somewhat deleted 😅

MokatchiOP•7d ago

yep, but it took me several days to know that the tabs and trashedFilter are conflicted. I didn't know that the filter was applied automatically.

Gaming

Programming

SoftDeletes

Did you find this page helpful?