Does the plugin work with any client version?
Hey, so I'm running a server that allows many many client versions to join through via version. It's running on 1.16.5, so is supported by DH. My question is, will newer clients work? Or do the versions have to match?
Solution:Jump to solution
Okay cool. All you have to to is toggle the
dhs.read-forge-byte property in the pom.xml file that represents your Minecraft version95 Replies
the versions have to match
it may work between small point releases but no more than that
Unfortunate.
Will it at least not cause problems?
Like I could imagine the newer clients sending data that will cause problems
im not sure
Ok. So I guess I gotta try
DH and DHS for 1.16.5 up to and including 1.20.2 should work together.
And 1.20.4 up to and including 1.21.4 should work together.
The reason is that there is a difference in the network protocol between versions 1.20.2 and 1.20.4
Ah interesting.
I've been putting off updating the server past 1.17 due to the world height issues
I guess I have to do that now
@пшш Can comment on how solvable the protocol difference issue is.
I know this is asking much, but would it be feasible to explicitly support that?
was i thinking of the mod version or was i just spouting nonsense?
I'm not sure about that specifically, but I know the plugin does things the same way for every version below 1.20.4 - and the same way for every version from 1.20.4 and up
What do you mean? I can make the plugin for 1.16.5 explicitly only work for 1.20.4 and up - is that what you're asking?
Protocol wise, one byte of difference (not counting minecraft shenanigans)
But overall, it's gonna get messy very quickly and probably not worth the time supporting it
No, sorry I meant that the plugin is able to support both protocol versions. Maybe through ViaVersions help
Fair
Thanks for your time
I did not expect to get such authorative answer this quickly
While you're here I want to express my extreme gratitude for your amazing mod. This is genuinely the best mod MC has ever seen.
If I was able to make it work for both version ranges, then I would already be doing so ;(
But if you don't have players that use MC 1.20.2 or older, then we could probably make a custom version just for you
The one thing I'd ask is that clients with an incompatible don't mess anything up
I could actually use that. I don't think anyone even uses 1.20 at all anymore. It's just that updating the server is an extreme hassle
Alright. Are you familiar with Java compiling at all, or would you need me to do it?
I'm a MC dev myself. I'm intimately familar with it
Solution
Okay cool. All you have to to is toggle the
dhs.read-forge-byte property in the pom.xml file that represents your Minecraft versionThen build
Ah lol. That's easy. Thanks ^^
Let me know how it goes. I'm kinda curious =P
Ok. Will do
I'm curious as well ^^
Btw, with this update it would make sense to completely clear the multiplayer DH data, right?
No need. It doesn't change the stored LODs. Only the "header" of each message sent between the server and client
Hm. Interesting, because when joining the server it did have to recreate them all
The only reason DHS will ever recreate a LOD is if one or more of the underlying chunks change
And I do have quite the large data set of them on my disk from manually flying around xD
Hm. Weird. Though as mentioned when joining the other server after installing the plugin, none of my previous data was there anymore
Right, that's probably because the plugin sends a key that identifies the server/world pair, and the previously autogenerated key is not the same. If you look in the DH folder on your client, I think you'll find you have two folders per world now
One will be your old LODs, and the folder name will probably be pretty weird
While the other will have a more sane name and contain your new ones from the plugin
Yeah
I genuinely don't feel like manually sorting that, so wiping it is xD
Yeah. The server would probably end up sending you replacement LODs for all of your old ones anyway, since their timestamps will be older than the server's
Alright
One more question. Is there an option to reload the config?
*command
Sorry, no ;( Let me check if I can make that happen real quick though
^^
Okay yeah, I think I can make that happen pretty easily
Luckily I messed up my previous changes that I was about to revert, so no need for me at this very moment
One side note, just because I just spotted that
ARe these messages normal
Ah yes, you should compile the develop branch instead of master
The message simply means that an update was triggered for an area where no LOD exists already, so it couldn't delete the old LOD
Makes sense from a programming point of view, but really pointless in practice
So develop has that fixed?
Yes
Awesome
Instead of blindly trying to delete something it doesn't know if exists, it'll check first
So the warning is still there, but won't trigger for this scenario
👍🏼
Another aside, does the plugin respect the world border?
No, but you can specify a border in the plugin too, beyond which it will reject LOD requests. It'll also communicate this border to the clients so that they don't actually request a bunch of stuff that will end up rejected anyway
This way you can set the DH border a bit beyond the "real" world border, if you'd like
Would it be possible to respect the border (including changes to it)?
Manually configuring stuff like that is extremely tedious
Hm, probably. But are you changing the world border very frequently?
A setting to specify how many chunks beyond that could work for the previous scenario
I do have worlds where they are semi regularily are expanded
And people being able to see beyond them defeats the purpose
Alright. Can you create a ticket with that request?
Sure
Pushed the command now. Haven't tested it, but it Should Just Work ™️
It's just
/dhs reload
Required permission is distant_horizons.adminLet me see
I should probably make it clear out the loaded config before reloading though, in case any vars are removed
Hang on
lol. I just noticed that I already have my server updated...
I don't know where I kept reading that old version...
You have no idea how stupid I feel right now
lol
Just give me a ping when the fixed reload is done
Now I think
Again, untested
I get this error
During startup that is
Stack overflow
lol
Guess that's what I get for trying to play video games and code at the same time
I feel you
Ah, I accidentally overrode a method, which is called outside of my own code
Classic
yeah
There we go
Thanks ^^
Sorry about that
No worries
I do have one issue now however
That being that with the snapshot no LODs are being loaded. Only the ones I have on my client
One of the changes in the snapshot is to check a permission to let people use DH. I might have messed up that logic
Can I know that permission, so I can quickly debug it?
distant_horizons.worlds.<world name>Also I hope it's set up properly on servers without permissions plugins
All true for me
Seems like messed up logic
(for reference)
Yeah I'm really dealing with a tristate here, since not having the permission should resolve as true, but I cannot rely on the native permission logic for that, since it didn't exist in older version of Minecraft
and I did indeed mess it up
Pushed a fix now
Alright
Joining the server and hearing my fans spin up is a good sign xD
It works now
Nice
Thanks for the patience
You're welcome
I know how it is
I can't stress enough how amazing this mod is
Haha I agree. The only reason I made the plugin is because I wanted it for my own server =P
I know that motivation so well
It was originally a stand-alone porject, not officially affiliated with DH
And then the thought: "Ah well, other people might like it too"
May I ask what projects you've worked on btw? Anything I would know?
The biggest I'd say is BungeeChat
Ah, that's pretty OG, no?
Pretty sure I've used it like 10 years ago
Well, I made version 2
Took it over from the original author
Ah
That's a pretty good thing to do
Loads of abandoned projects out there
Indeed
Been doing that for quite some time as well
Hey @Jckf . Don't mean to necro this thread, but I don't have access to the dev channel yet, so I thought this was the best way to reach you.
If you'd like to discuss my MR in a more direct manner, I'm up for a chat
Oops, didn't see this until now
No worries
Did you notice my comment about the scaling? I literally noticed it seconds after you merged
Coordinate scaling is only relevant for clients, but is semi-broken in its current state in DH itself. The center coordinate has to be scaled according to the world's scale factor before sending it to the client, other than that we don't need to care about it
I'll ask how much of a contribution is required to get the Discord role 👍
Ah ok. Then let me quickly fix that.
And thanks
Do you need to change anything though?
Yes. The scaling would need to happen after getting the values. Else the scaling is lost
The values I expect from the WorldInterface methods is the real coordinates as observed by the player in-game. I think that's what you return, also when tracking the vanilla border?
Then I really don't understand the purpose
Let me check the old code and try to understand it to see what it originally did and if anything needs to be done
What it does is in practice a workaround for what I consider a bug in DH
Fair. Though I think if it's a workaround it should be kept
Oh, you removed it from the config handler?
I didn't catch that
Ok.
So old logic is
- read dhs config for border center
- scale it
- set it to keep value
New logic ignores the scaling completely
No it's not kept. It just happens before reading the config values
and the value is discarded.
I think I have a fix, one second
Now it keeps the scaling for the client config
Yeah, the "keep value" is the one we send back to the client, and the border center we send back must be scaled. But we don't use the value afterwards, even though it sticks around inside the player config
It's only for the client to "fix" the weirdness in DH
Fair
New MR should fix that as well
Sorry for the oversight
No worries. I should have caught it