validation in importer

Why do i keep getting this error? "The name field is required."

ImportColumn::make('name')
    ->requiredMapping()
    ->rules(['required', 'string', 'max:255']),

ImportColumn::make('name')
    ->requiredMapping()
    ->rules(['required', 'string', 'max:255']),

    public function resolveRecord(): ?Collection
    {
        try {
            // Find or create collection based on ID
            $collection = Collection::firstOrNew([
                'id' => $this->data['id']
            ]);

            // Set additional fields
            $collection->name = $this->data['name'];
            $collection->slug = $this->data['slug'] ?? null;
            $collection->description = $this->data['description'] ?? null;
            $collection->images = $this->data['images'] ?? ['/images/default_image.png'];
            $collection->media_id = $this->data['media_id'] ?? null;
            $collection->parent_id = $this->data['parent_id'] ?? null;
            $collection->is_visible = $this->data['is_visible'] ?? true;
            $collection->tags = $this->data['tags'] ?? null;
            $collection->data = $this->data['data'] ?? null;

            return $collection;
        } catch (\Exception $e) {
            Log::error('Collection import error', [
                'data' => $this->data,
                'error' => $e->getMessage()
            ]);
            return null;
        }
    }

    public function resolveRecord(): ?Collection
    {
        try {
            // Find or create collection based on ID
            $collection = Collection::firstOrNew([
                'id' => $this->data['id']
            ]);

            // Set additional fields
            $collection->name = $this->data['name'];
            $collection->slug = $this->data['slug'] ?? null;
            $collection->description = $this->data['description'] ?? null;
            $collection->images = $this->data['images'] ?? ['/images/default_image.png'];
            $collection->media_id = $this->data['media_id'] ?? null;
            $collection->parent_id = $this->data['parent_id'] ?? null;
            $collection->is_visible = $this->data['is_visible'] ?? true;
            $collection->tags = $this->data['tags'] ?? null;
            $collection->data = $this->data['data'] ?? null;

            return $collection;
        } catch (\Exception $e) {
            Log::error('Collection import error', [
                'data' => $this->data,
                'error' => $e->getMessage()
            ]);
            return null;
        }
    }

50 Replies

Dennis Koch•4w ago

Probably because the name field is empty?

raheel3031OP•4w ago

No it is not empty

Dan Harrin•4w ago

why are you setting all the fields in resolveRecord()? thats not the point

raheel3031OP•4w ago

Ok but I am not getting the error because of that

Dan Harrin•4w ago

sure but you're not using the importer properly, so I don't know what else you're doing wrong that might be causing the problem so please read the docs, fix the implementation and then come back if the error is still there

raheel3031OP•4w ago

thanks. these errors i get "The id field must be an integer. The name field is required." in the excel the data is there. https://gist.github.com/raheelms/fe9ab1c7efc63a78eb716720d3f4f048

Gist

gist:fe9ab1c7efc63a78eb716720d3f4f048

GitHub Gist: instantly share code, notes, and snippets.

toeknee•4w ago

Provide the failed importing csv please.

Dan Harrin•4w ago

you prob also need to pass ->integer() to the ID column so it gets cast to a real integer

Dan Harrin•4w ago

https://filamentphp.com/docs/3.x/actions/prebuilt-actions/import#casting-state

Import action - Actions - Filament

raheel3031OP•4w ago

this is the failed

import-161-export-13...

Dennis Koch•4w ago

What's the data you are importing? Because the failed data looks corrupt

raheel3031OP•4w ago

this is the exported data

export-136-collectio...

raheel3031OP•4w ago

this is the export file

CollectionExporter.p...

raheel3031OP•4w ago

this is the importer file

CollectionImporter.p...

Dennis Koch•4w ago

I can't even open that file in Number/Excel. The leading " on every line seems off to me

raheel3031OP•4w ago

but what is causing it?

Dennis Koch•4w ago

I just said: The " looks off to me. How did you create that CSV?

raheel3031OP•4w ago

i have shared the code here above. the CollectionExporter is the name

raheel3031OP•4w ago

Collection.php

raheel3031OP•4w ago

this is the collection model

raheel3031OP•4w ago

collectionresource

CollectionResource.p...

raheel3031OP•4w ago

I have provided the file any help?

toeknee•4w ago

What on gods earth is going on here. You are talking about import validation issues then export, stick to one topic. Provide the csv that you are tyring to import

Dennis Koch•4w ago

He did above Because apparently he is importing a file that he exported through Filament I haven't used the export/import feature so I'm out of ideas.

toeknee•4w ago

Yeah if that is the import he is trying to import will fail as Dan pointed out it is as

ID,Name,Slug,Description,Images,Media,Parent,Visibility,Tags,Data,error
"1,Laptops,laptops,"

ID,Name,Slug,Description,Images,Media,Parent,Visibility,Tags,Data,error
"1,Laptops,laptops,"

so id is 1,Laptops,laptop I'd like to see the actual exported file without being editted 100% raw export because looking at the CollectionExporter it is good enough to have a standard export

raheel3031OP•4w ago

@toeknee, i have shared the exported file. and i am modifying that file and importing. but apparently i have to divide the data in columns first in excel then i can import it.

Dennis Koch•4w ago

and i am modifying that file and importing

You didn't say anything about that. What are you modifying? I thought this is straight from the export

Dan Harrin•4w ago

the CSV file definitely doesnt look right

raheel3031OP•4w ago

i will share the file that is created after export. in the CollectionExporter u can see the code. this file is not edited.

export-140-collectio...

raheel3031OP•4w ago

this is the CollectionExporter

CollectionExporter.p...

toeknee•4w ago

That is a perfect export with a standard , comma delimiter So after the export what are you doing that causes it to mess up.

raheel3031OP•4w ago

i am changing the content in the csv and try to import that data. even if i don't change that file and import the file. i get errors like the id is required and name field is required

Dennis Koch•4w ago

So how are you modifying this? Because after your modifications the file is invalid

toeknee•4w ago

So how you are saving/opening the CSV is the issue

raheel3031OP•4w ago

Yes, apparently i have to divide the columns and save it as a csv. then importing works yes i think this was the case. But what i still am figuring out is this. image data is being imported as this ["["collections\/01JMYENZR4ZXWJV9DKCV6H95KF.png"]"]

toeknee•4w ago

So the problem isn't filament, its how you are manipulating the file. You can change the delimiter if you please,see: https://filamentphp.com/docs/3.x/actions/prebuilt-actions/export#changing-the-csv-delimiter

Export action - Actions - Filament

toeknee•4w ago

That's because that is the image data

raheel3031OP•4w ago

image data is being imported as this ["["collections/01JMYENZR4ZXWJV9DKCV6H95KF.png"]"] why is this happening? i didn't change that

toeknee•4w ago

You did? the export is that? ["[\collections\/01JMYENZR4ZXWJV9DKCV6H95KF.png"]""]" the \ is removed as standard

raheel3031OP•4w ago

no i didn't change anything there

Dennis Koch•4w ago

I think the export is actually the same as the import

raheel3031OP•4w ago

yes almost. i changed only the content and name to see if it imports correct but didn't change anything in the image field

Dennis Koch•4w ago

I guess that comes from ->listAsJson()?

raheel3031OP•4w ago

yes but how else should i handle it this is in the migration file

        Schema::create('collections', function (Blueprint $table) {
            $table->id();
            $table->string('name');
            $table->string('slug')->unique();
            $table->longText(column: 'description')->nullable();
            $table->json('images')->nullable();
            $table->foreignId('media_id')->nullable()->constrained('media')->nullOnDelete();
            $table->boolean('is_visible')->default(true);
            $table->foreignId('parent_id')
                ->nullable()
                ->constrained('collections')                
                ->cascadeOnDelete();
            $table->json('tags')->nullable();
            $table->json('data')->nullable();
            $table->timestamps();
        });

        Schema::create('collections', function (Blueprint $table) {
            $table->id();
            $table->string('name');
            $table->string('slug')->unique();
            $table->longText(column: 'description')->nullable();
            $table->json('images')->nullable();
            $table->foreignId('media_id')->nullable()->constrained('media')->nullOnDelete();
            $table->boolean('is_visible')->default(true);
            $table->foreignId('parent_id')
                ->nullable()
                ->constrained('collections')                
                ->cascadeOnDelete();
            $table->json('tags')->nullable();
            $table->json('data')->nullable();
            $table->timestamps();
        });

Dennis Koch•4w ago

I'm not sure what's the correct Export. I never used that feature. But your import is exactly what was exported.

raheel3031OP•4w ago

is it possible for the team to make tutorials? because sometimes it is not clear how to write the code.

toeknee•4w ago

For what though? You are exporting the data correctly... then importing it correctly. What is it you are expecting

raheel3031OP•4w ago

no the import i have to modify i meant the tutorials in general. for filament

toeknee•4w ago

Laraveldaily does make tutorials. But it is fairly basic stuff import/export. You have built the exporters and the importers which work. so if you have to modify the import... you modify it however you want and then import it...

Dennis Koch•4w ago

Even if we did we couldn't cover everything

Gaming

Programming

validation in importer

Did you find this page helpful?