Distant Horizons•3mo ago

Significant surface features artifacts on DH 2.2

Minecraft version: 1.20.1 Distant Horizons version: 2.2.0-a Mod loader: Fabric Loader 0.16.2 Installed mods: Lithium, Distant Horizons Bug: There are large areas with few or no trees, but when you go there it's a forest. And Log file is bloating. Steps to reproduce the bug: Generate LODs (seed: 3730872696997453204) Log: https://mclo.gs/HUapFuH

mclo.gs

Vanilla Client Log [#HUapFuH]

25000 lines

58 Replies

AnonOP•3mo ago

Too Short; Will Read: See for how this bug was found → https://discord.com/channels/881614130614767666/1277391201980518561

AnonOP•3mo ago

344mb log file 💀

AnonOP•3mo ago

I created a GitLab issue: https://gitlab.com/jeseibel/distant-horizons/-/issues/790

GitLab

Significant surface features artifacts on DH 2.2 (#790) · Issues · ...

Check off each item in this list before submitting: Check the...

AnonOP•3mo ago

Log is full of this error

Miki_P98•3mo ago

Can you give the seed?

AnonOP•3mo ago

I already gave the seed I would really appreciate it if you can reproduce this bug

Puhpine•3mo ago

ill take a look to see if i can reproduce

Puhpine•3mo ago

imma see if i can reproducce it with less mods does NOT happen without entity culling, ferritecore and lithium

AnonOP•3mo ago

Watch out for your log file too man it adds up quick

Puhpine•3mo ago

ill delete the instance once im done anyway still happens without sodium and indium lithium is the issue

AnonOP•3mo ago

Should i update the issue on installed mods as lithium and distant horizons

Puhpine•3mo ago

yes please

AnonOP•3mo ago

Thx dude it was really late for me so i just couldn't dig into enough and left as it is

Puhpine•3mo ago

np! @James Seibel (GMT-6) this may be a significant bug. lots of people use lithium

AnonOP•3mo ago

@Puhpine (GMT +2) does log bloating still happens with only lithium

Puhpine•3mo ago

not sure because i deleted the instance, but i think it did yea

Miki_P98•3mo ago

Here are chunk, world and generation Lithium settings I dag up:

this.addMixinRule("chunk", true);
this.addMixinRule("chunk.block_counting", true);
this.addMixinRule("chunk.entity_class_groups", true);
this.addMixinRule("chunk.no_locking", true);
this.addMixinRule("chunk.no_validation", true);
this.addMixinRule("chunk.palette", true);
this.addMixinRule("chunk.section_update_tracking", true);
this.addMixinRule("chunk.serialization", true);

this.addMixinRule("gen", true);
this.addMixinRule("gen.biome_noise_cache", true);
this.addMixinRule("gen.cached_generator_settings", true);
this.addMixinRule("gen.chunk_region", true);
this.addMixinRule("gen.fast_island_noise", true);
this.addMixinRule("gen.fast_layer_sampling", true);
this.addMixinRule("gen.fast_multi_source_biomes", true);
this.addMixinRule("gen.features", true);
this.addMixinRule("gen.perlin_noise", true);

this.addMixinRule("world", true);
this.addMixinRule("world.block_entity_retrieval", true);
this.addMixinRule("world.block_entity_ticking", true);
this.addMixinRule("world.block_entity_ticking.support_cache", false); //have to check whether the cached state bugfix fixes any detectable vanilla bugs first
this.addMixinRule("world.chunk_access", true);
this.addMixinRule("world.chunk_task_system", true);
this.addMixinRule("world.chunk_tickets", true);
this.addMixinRule("world.chunk_ticking", true);
this.addMixinRule("world.explosions", true);
this.addMixinRule("world.inline_block_access", true);
this.addMixinRule("world.inline_height", true);
this.addMixinRule("world.mob_spawning", true);
this.addMixinRule("world.player_chunk_tick", true);
this.addMixinRule("world.tick_scheduler", true);

this.addMixinRule("worldfixer", true);

this.addMixinRule("chunk", true);
this.addMixinRule("chunk.block_counting", true);
this.addMixinRule("chunk.entity_class_groups", true);
this.addMixinRule("chunk.no_locking", true);
this.addMixinRule("chunk.no_validation", true);
this.addMixinRule("chunk.palette", true);
this.addMixinRule("chunk.section_update_tracking", true);
this.addMixinRule("chunk.serialization", true);

this.addMixinRule("gen", true);
this.addMixinRule("gen.biome_noise_cache", true);
this.addMixinRule("gen.cached_generator_settings", true);
this.addMixinRule("gen.chunk_region", true);
this.addMixinRule("gen.fast_island_noise", true);
this.addMixinRule("gen.fast_layer_sampling", true);
this.addMixinRule("gen.fast_multi_source_biomes", true);
this.addMixinRule("gen.features", true);
this.addMixinRule("gen.perlin_noise", true);

this.addMixinRule("world", true);
this.addMixinRule("world.block_entity_retrieval", true);
this.addMixinRule("world.block_entity_ticking", true);
this.addMixinRule("world.block_entity_ticking.support_cache", false); //have to check whether the cached state bugfix fixes any detectable vanilla bugs first
this.addMixinRule("world.chunk_access", true);
this.addMixinRule("world.chunk_task_system", true);
this.addMixinRule("world.chunk_tickets", true);
this.addMixinRule("world.chunk_ticking", true);
this.addMixinRule("world.explosions", true);
this.addMixinRule("world.inline_block_access", true);
this.addMixinRule("world.inline_height", true);
this.addMixinRule("world.mob_spawning", true);
this.addMixinRule("world.player_chunk_tick", true);
this.addMixinRule("world.tick_scheduler", true);

this.addMixinRule("worldfixer", true);

One (or more) of them is most likely incompatible Disabling all of gen optimizations fix this It is 1 of the first 4 Found it: mixin.gen.chunk_region There are still holes in the world...

Miki_P98•3mo ago

They've got fixed after I've flew over them . . The fix to the OP's problem is disabling mixin.gen.chunk_region Lithium option The line: mixin.gen.chunk_region=false Should be added to lithium.properties config file . . @Puhpine (GMT +2) Can you add this to #faq-mod-support or confirm?

Puhpine•3mo ago

i cant, as i cant edit james' messages

Miki_P98•3mo ago

You can write a new one

Puhpine•3mo ago

dont know if james would want that, and maybe the bug can be fixed, so that you dont need to edit anything

Miki_P98•3mo ago

It can always be deleted later, but OK

Puhpine•3mo ago

oh and i dont even have permissions to write in #faq-mod-support

Miki_P98•3mo ago

Puhpine•3mo ago

this also works for me

Miki_P98•3mo ago

This is this option description:

mixin.gen.chunk_region (boolean, default: true) If true, an optimized chunk cache will be used for world population features which avoids array indirection and complex logic.

BackSun•3mo ago

I'll take a look at the bug when I have time.

Puhpine•3mo ago

nice!

AnonOP•3mo ago

you are awesome

hardester•3mo ago

This bug feels like one of those classic seed-sensitive Minecraft bug where it only occurs on certain seeds. This world seed just so happens to trigger it.

hardester•3mo ago

Can't reproduce this on 1.21.1, however, other things I noticed is that there are many features that appears to be sliced at chunk borders. All screenshots are zoomed in with the spyglass. Same setup with OP with the exception of Minecraft version being 1.21.1.

hardester•3mo ago

Also, man this speed-up sure helps a lot with getting LODs quickly.

hardester•3mo ago

One question, is the button placement messed up in the main menu 1.20.1?

hardester•3mo ago

Nevermind, it resets itself once I joined a world.

hardester•3mo ago

This is already concerning.

BackSun•3mo ago

That's a known and long standing world gen issue that isn't planned on being fixed. That's caused because each DH world gen reqeust only works with 4x4 chunks at a time so anything outside of that will likely be cut off. Usually the issue is very minor and/or far away so it isn't a big problem.

Miki_P98•3mo ago

~~Is this after of before the fix?~~ The cuts are there but aren't noticable for me

BackSun•3mo ago

Either increase your CPU load and/or reduce your vanilla render distance.

hardester•3mo ago

I have reasons to believe it's not related to the CPU load setting. I immediately launch the world without much adjusting other settings. I... probably should look at the logs... harold emoji

BackSun•3mo ago

The CPU load setting increases the max number of chunks that can be queued, so increasing it will reduce/fix this problem when first loading into a world. Currently you have 1 thread set for LOD updating, which only allows 500 chunks to be queued, every thread you add increases that number by 500.

hardester•3mo ago

Let me try adjusting that. Theory debunked, the feature placement bug appears to happen with other world seeds.

AnonOP•3mo ago

Fix works for modded gen as well, thank you

Miki_P98•3mo ago

No problem 😸

BackSun•3mo ago

I'm not seeing this issue in MC 1.21.1 and Lithium 0.13.0. I'm now testing MC 1.20.1 and Lithium 0.11.2... I am able to reproduce the issue in MC 1.20.1 and Lithium 0.11.2

BackSun•3mo ago

Apparently it was removed from Lithium as of MC 1.21 (Lithium 13): https://github.com/CaffeineMC/lithium-fabric/commit/b7cfd53a1ed0197e1d13dea2799b898eb52ecab3

GitHub

Remove incompatible gen.chunk_region optimization · CaffeineMC/lith...

Miki_P98•3mo ago

Can you force disable it with a mixin on game start, or add the workaround to the FAQ?

BackSun•3mo ago

We’ll see, I’m still looking into it. I just pushed a fix for this if someone is willing to test it out.

Miki_P98•3mo ago

I might have done something wrong, but after downloading newest nightly couple minutes ago, and removing the lithium config workaround the bug still happens

BackSun•3mo ago

So just DH and MC 1.20.1 causes that? Did you try a new world? I've been able to generate fresh 1.20.1 worlds without issue.

Miki_P98•3mo ago

I have faster random and Noisium too I can try only lithium + DH DH on its own does not cause this

BackSun•3mo ago

If you can determine which mods cause the problem that’d be super helpful 👍

Miki_P98•3mo ago

Redownloaded DH nightly, mods: - DH 2.2.1 dev - Fabric API 0.92.2 - Lithium 0.11.2 (no manual fix) - ModMenu (All newest for MC 1.20.1 on Modrinth) Works as intended

BackSun•3mo ago

Good to hear

Miki_P98•3mo ago

Added: - Noisium 2.3.0 - Faster Random 5.1.0 - Dynamic FPS 3.6.3 Works as intended Added: - Fabric Language Kotlin - ImmediatelyFast - YACL - Zoomify Works as intended The previous nightly I downloaded must have been without the fix?... IDK It works now

BackSun•3mo ago

Well I’m glad to hear it’s working as intended 🎉

Gaming

Programming

Significant surface features artifacts on DH 2.2