LOD Clouds render always
This bug report is for the in-dev lod cloud rendering.
Currently the clouds always render, even if the vanilla rendering is skipped. This causes issues with shaders, and also other mods that disable or mess with vanilla clouds (like mine, better-clouds). Mostly that clouds appear twice.
A solution would be to inject into the
LevelRenderer#renderClouds methods and set a flag that is has been called in the current frame. Not sure if thats the best solution tho.17 Replies
Using dh nightly 13363ff3 (1.21)
If you want to disable DH cloud rendering please use the API to disable them via the config.
DhApi.Delayed.configs.graphics().genericRendering().cloudRenderingEnabled().setValue(false);
(Note you will need the latest nightly build that I just pushed 30 seconds ago)Thanks, but I think that this feature will cause quite a lot of perceived (because you can obviously just disable them) incompatibilities with other mods
I've been thinking more about this. Settings the
cloudRenderingEnabled value to false might not be in the interest of the user if it changes the config permanently. But it's not a big issue.The method I shared doesn’t modify the config file or UI.
Using the API to modify DH’s config only changes the value in memory. (The Java docs have more info)
Oh, okay. Btw will the upcoming api version be 2.1.3 or 3.0.0 ?
3.0.0, there’s been several breaking changes.
By the way, thank you for being so active and looking into my issues
I've noticed two issues with the current build: Setting this to false does also change it on the settings page. And also it cannot manually be enabled again (by pressoing the button in the settings) unless the game is restarted.
Ah my mistake, it does update the UI.
Although the fact the user can't change it via the UI is intentional. Since you've overridden it via the API you have control over what the user has set.
Oh ok, maybe you should let the user know about the via the tooltip. Something like "Another mod has disabled this feature", idk
Exactly which version of DH did this change in? I noticed upon updating from 2.1.2-a-1.20.4 to 2.2.1-a-dev that vanilla clouds are rendered quite high in the skies. Is this:
- Cloud/Beacon rendering - This broke previous Iris compatability, please be patient while waiting for Iris to update.?
2.1.3a a.k.a. 2.2
Thanks. I'll try to just ignore them and hope they'll go away after a few mod updates.
You can disable them somewhere in dh's settings
I can? Doesn't Iris have to do it with the API?
Don't think so. It's under graphics, generic rendering or something like that
Ah. Thanks! Way better now.
👍