SolidJS•16mo ago

Missing Http method returns 200 status code on api route

I am trying to generate API routes. In the docs I read that 405 is returned for non existing routes but when I create one let's say /api/logout and only define a DELETE method , if I call put on it it returns code 200 and html. Is this correct or have I missed something? Do I have to define all the methods I do not use and return 405 on them myself? /api/logout.ts code below

import { APIEvent } from 'solid-start/api'

export async function DELETE({ request, params }: APIEvent) {
  //...api stuff here

  return new Response('')
}

import { APIEvent } from 'solid-start/api'

export async function DELETE({ request, params }: APIEvent) {
  //...api stuff here

  return new Response('')
}

12 Replies

vibeman1987•16mo ago

we're gonna need more of the code dawg

SilverdaggerOP•16mo ago

I believe it is pretty straightforward I have only defined DELETE on this route -> when PUT is called it returns html and what i expected to happen is return 405.

vibeman1987•16mo ago

ohhh nevermind I gotchu yeah lemme check if you want something custom:

export const POST = ()=>{return new Response("Error: POST not supported", {status : 405})}

export const POST = ()=>{return new Response("Error: POST not supported", {status : 405})}

I haven't found anything in the docs that gives an alternative @silverdagger

SilverdaggerOP•16mo ago

yeah this is what I do atm -> create catch all routes and return 405 on all of them myself -> Just thought that maybe I missed something to "enable" this feature to do it for any undefined routes

vibeman1987•16mo ago

wait @silverdagger in what folder are your endpoints?

If a handler is not defined for a given HTTP method, SolidStart will return a 405 Method Not Allowed response.

If a handler is not defined for a given HTTP method, SolidStart will return a 405 Method Not Allowed response.

SilverdaggerOP•16mo ago

routes/api/endpoint.ts

vibeman1987•16mo ago

Have you wrapped anything in your Index file?

SilverdaggerOP•16mo ago

not sure what you mean

vibeman1987•16mo ago

https://github.com/solidjs/solid-start/blob/f351f42ba8566cbfa72b483dd63d4debcb386230/packages/start/fs-router/router.js#L176

GitHub

solid-start/packages/start/fs-router/router.js at f351f42ba8566cbfa...

SolidStart, the Solid app framework. Contribute to solidjs/solid-start development by creating an account on GitHub.

vibeman1987•16mo ago

Turns out it's not even in the code \o/

Edivado•16mo ago

Ok strange... opened a PR. ~~Should cover it.~~ It's a bit more complicated than I thought. https://github.com/solidjs/solid-start/pull/1041

vibeman1987•16mo ago

weird that it's in the docs, as if it's implemented

Gaming

Programming

Missing Http method returns 200 status code on api route