C#•15mo ago

✅ Some terrible code

Soooooooooooooooo, I have no clue how to make HTTP requests. Can anyone advise a nice guide? Like, that's what i have built with ChatGPT's help. I just need some advice, except to stop coding 🙂

38 Replies

Angius•15mo ago

This looks good enough, what's the problem? Unless you just want to make it better in general?

wwwwOP•15mo ago

Yep, something like this. Maybe anyone has some good guides about this topic cuz core 7 is kinda new as i get, and finding something useful is a bit harder then other things

Angius•15mo ago

Well, one obvious improvement would be using dependency injection to get the database context instead of newing it up Far as guides go, Microsoft's docs are good enough for beginners

wwwwOP•15mo ago

like this one?

wwwwOP•15mo ago

https://learn.microsoft.com/en-us/aspnet/core/tutorials/web-api-javascript?view=aspnetcore-7.0

Tutorial: Call an ASP.NET Core web API with JavaScript

Learn how to call an ASP.NET Core web API with JavaScript.

Angius•15mo ago

For example, yes

Angius•15mo ago

And this one, since you're using Minimal APIs on the backend: https://learn.microsoft.com/en-us/aspnet/core/tutorials/min-web-api?view=aspnetcore-7.0&tabs=visual-studio

Tutorial: Create a minimal API with ASP.NET Core

Learn how to build a minimal API with ASP.NET Core.

wwwwOP•15mo ago

So, what do you mean? Are you suggesting that I could create custom middleware which, upon creation, initializes an instance of the database using a class constructor?

Angius•15mo ago

No I mean what I said Use dependency injection Register the context in the services And inject it via a parameter in your lambda

wwwwOP•15mo ago

like this?

Angius•15mo ago

Almost EF has its own method of registering in the services

builder.Services.AddDbContext<MyCoolDbContext>();

builder.Services.AddDbContext<MyCoolDbContext>();

Then you inject it like you have it here, yes But with MyCoolDbContext not any interface

wwwwOP•15mo ago

Oh, now it even works. Thank you very much!

Developful•15mo ago

also why Persosn

Angius•15mo ago

Also, why do you read the data from the httpcontext? You can just bind it

Developful•15mo ago

is that a typo?

Angius•15mo ago

No need to use request and response directly, it's not Node.js lol

wwwwOP•15mo ago

fixed lmao

wwwwOP•15mo ago

its only way i found how to do that

Angius•15mo ago

async ([FromBody] Person person, UserBaseContext db) =>
{
    // ...
    if (...)
    {
        // ...
        return TypedResults.Ok(user);
    }
    else
    {
        return TypedResults.NotFound("ERROR");
    }
}

async ([FromBody] Person person, UserBaseContext db) =>
{
    // ...
    if (...)
    {
        // ...
        return TypedResults.Ok(user);
    }
    else
    {
        return TypedResults.NotFound("ERROR");
    }
}

There

wwwwOP•15mo ago

wwwwOP•15mo ago

app.MapPost("/login", async ([FromBody] Person person, UserBaseContext db) =>
{
    if (person != null)
    {
        User? user = db.Users.FirstOrDefault(u => u.Username == person.Username);
        if (user != null)
        {
            if (user.Password == person.Password)
            {
                user.Password = new string('*', user.Password.Length);
                return TypedResults.Ok(user);
            }
        }
    }
    else
    {
        return TypedResults.NotFound("ERROR");
    }
});

app.MapPost("/login", async ([FromBody] Person person, UserBaseContext db) =>
{
    if (person != null)
    {
        User? user = db.Users.FirstOrDefault(u => u.Username == person.Username);
        if (user != null)
        {
            if (user.Password == person.Password)
            {
                user.Password = new string('*', user.Password.Length);
                return TypedResults.Ok(user);
            }
        }
    }
    else
    {
        return TypedResults.NotFound("ERROR");
    }
});

im so dumb lmao rly can't get whats a problem here

Angius•15mo ago

Well, you don't run any async code here So that await is kinda useless You should change FirstOrDefault() into FirstOrDefaultAsync() and await that

wwwwOP•15mo ago

yep, thx :), but this thing is still here

Angius•15mo ago

Where does this error happen?

wwwwOP•15mo ago

Angius•15mo ago

That's... very weird I guess you could try explicity addng a return type to this lambda...?

async Task<Results<Ok<User>, NotFound<string>>> ([FromBody ...

async Task<Results<Ok<User>, NotFound<string>>> ([FromBody ...

wwwwOP•15mo ago

more errors lmao

wwwwOP•15mo ago

nmv about that Thank you very much again I'll come up with something

Angius•15mo ago

Task<IResult> maybe Not as type-safe but still Regardless, even the initial error, about RequestDelegate not taking 2 arguments, should not be a thing

wwwwOP•15mo ago