JanL
CCoder.com
•Created by JanL on 1/16/2023 in #help
OIDC with Gitlab
Sorry for the late feedback, I got distracted this morning. The patch works perfect. Thank you!
45 replies
CCoder.com
•Created by JanL on 1/16/2023 in #help
OIDC with Gitlab
I'll test it first thing tomorrow morning, I've turned my device off already. Is it alright to cherry-pick just this commit on top of the last release? Then I don't need a separate release for just this change.
45 replies
CCoder.com
•Created by JanL on 1/16/2023 in #help
OIDC with Gitlab
Oh wow, thank you so much!
45 replies
CCoder.com
•Created by JanL on 1/16/2023 in #help
OIDC with Gitlab
For this case, I think it's acceptable to do this extra work on the coder side becuase this code is only hit if someone provided a valid oidc callback anyway - so I don't see much potential for dos
45 replies
CCoder.com
•Created by JanL on 1/16/2023 in #help
OIDC with Gitlab
I'll definitely open an issue on the GL side
45 replies
CCoder.com
•Created by JanL on 1/16/2023 in #help
OIDC with Gitlab
yes. I'm not sure if they created this situation deliberately or if it happened just because someone did not fully read the documentation of the library they used 😉
45 replies
CCoder.com
•Created by JanL on 1/16/2023 in #help
OIDC with Gitlab
that is not true, gitlab strange enough sends teh direct group memberships and the user email in the id_token claim
45 replies
CCoder.com
•Created by JanL on 1/16/2023 in #help
OIDC with Gitlab
ah, you mean, fetch user info if no claims are attached?
45 replies
CCoder.com
•Created by JanL on 1/16/2023 in #help
OIDC with Gitlab
This specification defines a set of standard Claims. They can be requested to be returned either in the UserInfo Response, per Section 5.3.2, or in the ID Token, per Section 2.
45 replies
CCoder.com
•Created by JanL on 1/16/2023 in #help
OIDC with Gitlab
I cannot really tell if that is always true, the OIDC standard says, it can be in either or. For gitlab this is true - but this is only one provider
45 replies
CCoder.com
•Created by JanL on 1/16/2023 in #help
OIDC with Gitlab
Shall I create a PR anyway?
45 replies
CCoder.com
•Created by JanL on 1/16/2023 in #help
OIDC with Gitlab
The only thing is - now the unittests need to be fixed and I have no capacity in at the moment to understand the http client mocking
45 replies
CCoder.com
•Created by JanL on 1/16/2023 in #help
OIDC with Gitlab
The id token is apparently the only MUST part in the standard
45 replies
CCoder.com
•Created by JanL on 1/16/2023 in #help
OIDC with Gitlab
I'll in parallel open an issue at gitlab to provide basic information within the id token maybe. Not sure it was a deliberate decision on their side to only make this available within the user info ep
45 replies