Alex Kontos
CDCloudflare Developers
•Created by Alex Kontos on 5/7/2024 in #pages-help
Help debugging 500 errors?
I raised a P1 ticket because even using the last commit that was working now returns a 500 and the team is looking into it.
5 replies
CDCloudflare Developers
•Created by Alex Kontos on 3/4/2024 in #pages-discussions
Pages `bun install` by default? Why.
Agreed; straight from Cloudflare support:
We have updates from the Pages engineering team:
Given that Bun is relatively new, and is the only tool we've had reports like this on, we are leaning towards this being a Bun issue.
It looks like Bun's v1.0.29 release added reliability improvements to bun install, so I'd suggest you to try that version (or whatever is latest): https://bun.sh/blog/bun-v1.0.29
Additionally, if you would like to customize your bun install command (eg. to remove --frozen-lockfile or add --verbose), you can add the following environment variable to skip the automatic dependency installation:
SKIP_DEPENDENCY_INSTALL=true{}
Which to me implies they either shouldn’t be running bun install —frozen-lockfile
at all - or at least be keeping it up to date, per CS so the user doesn’t have to.28 replies
CDCloudflare Developers
•Created by Alex Kontos on 3/4/2024 in #pages-discussions
Pages `bun install` by default? Why.
Your point isn't really relevant to this discussion anyway; it's bad DX to run a command that can't be modified, that is broken and fixed in a later release on a product that doesn't push out breaking changes in patch releases.
28 replies
CDCloudflare Developers
•Created by Alex Kontos on 3/4/2024 in #pages-discussions
Pages `bun install` by default? Why.
But there aren't breaking changes in Bun patch releases?
28 replies
CDCloudflare Developers
•Created by Alex Kontos on 3/4/2024 in #pages-discussions
Pages `bun install` by default? Why.
Who's saying it is? It is their fault they're running a command a user can't change
28 replies
CDCloudflare Developers
•Created by Alex Kontos on 3/4/2024 in #pages-discussions
Pages `bun install` by default? Why.
Which is the point of the discussion
28 replies
CDCloudflare Developers
•Created by Alex Kontos on 3/4/2024 in #pages-discussions
Pages `bun install` by default? Why.
So then it's a fundamentally broken feature?
28 replies
CDCloudflare Developers
•Created by Alex Kontos on 3/4/2024 in #pages-discussions
Pages `bun install` by default? Why.
As is literally the issue because the user can't change the command that runs by default
28 replies
CDCloudflare Developers
•Created by Alex Kontos on 3/4/2024 in #pages-discussions
Pages `bun install` by default? Why.
And if the tool is broken...?
28 replies
CDCloudflare Developers
•Created by Alex Kontos on 3/4/2024 in #pages-discussions
Pages `bun install` by default? Why.
Also the issue is that it will work in your local env in 1.0.1 but won't in production on Pages because of the extra flag..
28 replies
CDCloudflare Developers
•Created by Alex Kontos on 3/4/2024 in #pages-discussions
Pages `bun install` by default? Why.
But is the assumption in this scenario that users will only redeploy an existing site with no changes? Because there's a good chance they may run into the
--frozen-lockfile
bug patched in 1.0.19: https://community.cloudflare.com/t/error-lockfile-had-changes-but-lockfile-is-frozen/582525
https://discord.com/channels/595317990191398933/1182972894003863552/118297289400386355228 replies
CDCloudflare Developers
•Created by Alex Kontos on 3/4/2024 in #pages-discussions
Pages `bun install` by default? Why.
For something that's set and running as default and considering Bun doesn't seem to push out breaking changes in patch releases, it really should be kept up to date.
28 replies
CDCloudflare Developers
•Created by Alex Kontos on 3/4/2024 in #pages-discussions
Pages `bun install` by default? Why.
But the
--frozen-lockfile
command has issues (in that it wasn't working correctly in certain scenarios) that were patched in 1.0.19 and also considering the reports are of users having timeouts even using the default Bun version, isn't really a testament to stability and not breaking things. In fact, Between 1.0.1 -> 1.0.30, there have been 13 release fixing bugs with the bun install
command: https://bun.sh/blog28 replies
CDCloudflare Developers
•Created by Alex Kontos on 3/4/2024 in #pages-discussions
Pages `bun install` by default? Why.
I don't see the relevance to allowing you to set a "latest" version just as you can with Node on Pages. And the current version of Bun being set as well as the forced usage of
--frozen-lockfile
IS breaking peoples sites. Regardless, there should be no breaking changes in Bun 1.0.x
. There will be in the transition to 1.1 though: https://github.com/oven-sh/bun/issues/882128 replies
CDCloudflare Developers
•Created by Alex Kontos on 3/4/2024 in #pages-discussions
Pages `bun install` by default? Why.
But the point of an old Bun still stands, if you're using Node/npm for example.
28 replies
CDCloudflare Developers
•Created by Alex Kontos on 3/4/2024 in #pages-discussions
Pages `bun install` by default? Why.
Yes, I currently set it manually, but have put in a suggestion for a "latest" version: https://discord.com/channels/595317990191398933/920749372256419930/1214197247177400353
28 replies
CDCloudflare Developers
•Created by Alex Kontos on 3/4/2024 in #pages-discussions
Pages `bun install` by default? Why.
Pages also defaults to Bun
1.0.1
- but there have been many updates since that release relating to the install
command, and a few specifically targeting fixes for issues with bun install --frozen-lockfile
. The most crucial being Bun 1.0.19
https://bun.sh/blog/bun-v1.0.19#fixed-lockfile-had-changes-but-is-frozen-bug
The code path used by --frozen-lockfile to detect whether a lockfile changed sometimes incorrectly reported that the lockfile changed when it didn't. This would cause errors like:
error: lockfile had changes, but is frozen
To fix this, we've changed how we define "frozen". Instead of relying on input from the filesystem which can potentially change for unrelated reasons, we've switched it to using a hash of the package names and their versions sorted alphabetically with their version numbers. We think this is a more reliable approach.
28 replies