yujonglee
yujonglee
Explore posts from servers
SMSoftware Mansion
Created by yujonglee on 3/1/2024 in #membrane-help
MP3 output is audible, but test not pass
Hi everyone. I made small changes in membrane_mp3_lame_plugin to support other input config (the original repo only support 44100/32/1). (patch branch: https://github.com/yujonglee/membrane_mp3_lame_plugin/commits/patch/) After the change, I run the test, but test does not pass. But when I play the generated output file, it is audible and feels same as ref.mp3. (To get generated audio, I commented out https://github.com/yujonglee/membrane_mp3_lame_plugin/blob/patch/test/integration/integration_test.exs#L27 and run test) I wrote a README on how I create new test audio file: https://github.com/yujonglee/membrane_mp3_lame_plugin/blob/patch/README.md Can anyone share some insight on this?
5 replies