tpottinger
tpottinger
PostsComments
CCoder.com
Created by tpottinger on 7/18/2024 in #help
github enterprise auto upload publish SSH key
And finally, an easy addition would be a note on https://registry.coder.com/modules/github-upload-public-key for Github Enterprise: adding the github_api_url parameter in the example tf module usage is needed.
35 replies
CCoder.com
Created by tpottinger on 7/18/2024 in #help
github enterprise auto upload publish SSH key
Also, the docs on https://registry.coder.com/modules/github-upload-public-key reference CODER_EXTERNAL_AUTH_0_SCOPES but I suspect that's only required for GitHub Oauth Apps? GitHub Apps need to configure permissions, and the docs on https://coder.com/docs/admin/external-auth#github includes a screenshot for "Permissions & events" that I think replaces the need for the _SCOPES env var. I'm not 100% sure
35 replies
CCoder.com
Created by tpottinger on 7/18/2024 in #help
github enterprise auto upload publish SSH key
@Atif the docs on https://coder.com/docs/admin/external-auth#github say "it's easier to configure a GitHub OAuth app!" but the screenshots are from a "GitHub App" not a GitHub "Oauth App". I suspect both are able to work, but the instruction "Install the App for your organization" only applies for GitHub Apps, not GitHub Oauth Apps. I wasn't able to convince our GHE admins to install the GitHub App, so idk if/what that step is necessary for.
35 replies
CCoder.com
Created by tpottinger on 7/18/2024 in #help
github enterprise auto upload publish SSH key
Finally got it to work! I learned a couple things: * https://docs.github.com/en/apps/oauth-apps/building-oauth-apps/differences-between-github-apps-and-oauth-apps I originally had created a github app. Looking back at this, I think I might be able to get the github app to work, but 🤷 I have an oauth app working now * When I posted last night I was missing github_api_url completely. I initially tried https://github.example.com but this afternoon I realized I needed to use https://github.example.com/api/v3
35 replies
CCoder.com
Created by tpottinger on 7/18/2024 in #help
github enterprise auto upload publish SSH key
It's still not quite working, but the error code (406) makes more sense than what I was seeing before (401) because I can manually get a 406
35 replies
CCoder.com
Created by tpottinger on 7/18/2024 in #help
github enterprise auto upload publish SSH key
Looks like I forgot to set the github_api_url variable when I used the module! 🤦‍♂️
35 replies
CCoder.com
Created by tpottinger on 7/18/2024 in #help
github enterprise auto upload publish SSH key
@Atif I think that's for using github for authenticating to coder (i.e. https://coder.com/docs/admin/auth ) vs their external auth (https://coder.com/docs/admin/external-auth ) ? I'm currently using https:// in all the env vars that get set in our k8s argocd appset yaml file.
35 replies
CCoder.com
Created by tpottinger on 7/18/2024 in #help
github enterprise auto upload publish SSH key
@Phorcys do you mean the main.tf from our template? I can't share that since it includes a bunch of internal setup. Or do you mean the main.tf referenced from https://registry.coder.com/modules/github-upload-public-key ? I followed the example towards the bottom of that page and added that to our template
35 replies
CCoder.com
Created by tpottinger on 7/18/2024 in #help
github enterprise auto upload publish SSH key
During workspace startup, I see the following at the top of our startup logs 
Fetching GitHub token...
Fetching public key from Coder...
Fetching public keys from GitHub...
Failed to fetch Coder public SSH key with status code 401!
{
  "message": "Bad credentials",
  "documentation_url": "https://docs.github.com/rest",
  "status": "401"
}
...
Fetching GitHub token...
Fetching public key from Coder...
Fetching public keys from GitHub...
Failed to fetch Coder public SSH key with status code 401!
{
  "message": "Bad credentials",
  "documentation_url": "https://docs.github.com/rest",
  "status": "401"
}
...
35 replies