Henil Shah
TTCTheo's Typesafe Cult
•Created by Muhct on 6/20/2024 in #questions
Best practices for typing a reusable button?
I think with components arch, the best part is you decide what and how much connection you want.
IMO, if you have 3 / 4 button types (Default, Outline, Success, Danger, etc) then this code makes sense.
But if you almost have the same button types across your app then this can be avoided.
6 replies
TTCTheo's Typesafe Cult
•Created by Giuliopime on 6/17/2024 in #questions
Dialog shadcn not showing up as a dialog but just as content
TLDR: Worked for me, can you pull up a sandbox?
Sorry dude, Unfortunately, It's working for me.
Maybe you can pump up a sandbox for this??
Although I have some thoughts on the issue you submitted which I'm putting here and not on github to NOT pollute the repo.
Positive Remarks:
1. Awesome screenshots (makes me understand the problem in seconds)
2. Good thing to add DOM from the browser tools.
Constructive Remarks:
1. Folder structure screenshot is unnecessarily long. (Maybe draw the structure on https://excalidraw.com and just add the important things)
2. my page.tsx is not a good way to show up some code since every page is named page.tsx in Next.js (Just a nitpick) -> Just add the path to the file?
3. In the end of JSX (page.tsx) you're mapping through some "data" array which you haven't given along with the IxListCard component. I mean why give me errors when I'm trying to help you? The Problem is about shad components, just talk about them right?
4. Try AVOIDING creating an issue on any repo if your answer to the question How to reproduce? is this: -> It's weird 'cause I can't always reproduce it, but I can't find the issue in my case 5. As I said before, a sandbox would've been wonderful here. With all that said, I'm no expert on git Issues and PR management. Apparently Theo was live today and addressed this exact problem about how to approach open source repos and issues / prs on it. References: 1. https://www.youtube.com/watch?v=5nY_cy8zcO4 2. https://www.youtube.com/watch?v=JF8F7uaGfV8 I really want to help and I did spin up 2 separate instances of Next apps to reproduce this but couldn't. Let me know how I can assist.!
4. Try AVOIDING creating an issue on any repo if your answer to the question How to reproduce? is this: -> It's weird 'cause I can't always reproduce it, but I can't find the issue in my case 5. As I said before, a sandbox would've been wonderful here. With all that said, I'm no expert on git Issues and PR management. Apparently Theo was live today and addressed this exact problem about how to approach open source repos and issues / prs on it. References: 1. https://www.youtube.com/watch?v=5nY_cy8zcO4 2. https://www.youtube.com/watch?v=JF8F7uaGfV8 I really want to help and I did spin up 2 separate instances of Next apps to reproduce this but couldn't. Let me know how I can assist.!
6 replies
TTCTheo's Typesafe Cult
•Created by Giuliopime on 6/17/2024 in #questions
Dialog shadcn not showing up as a dialog but just as content
Yep
6 replies
TTCTheo's Typesafe Cult
•Created by Giuliopime on 6/17/2024 in #questions
Dialog shadcn not showing up as a dialog but just as content
I tried running this and it worked for me, can you give more info / reproducing steps?
I would suggest to inspect the styles on the browser (I'm sure you might have done this already)
6 replies