[-InsertNameHere-] Comments

[-InsertNameHere-]

Posts Comments

CC#

•Created by [-InsertNameHere-] on 3/9/2025 in #help

✅ Async void method testing in xUnit

Thanks for the additional info. Will definitely look into it👍

30 replies

CC#

•Created by [-InsertNameHere-] on 3/9/2025 in #help

✅ Async void method testing in xUnit

I should be good on my own though. Thank you once again for your input and hope you have a great day

30 replies

CC#

•Created by [-InsertNameHere-] on 3/9/2025 in #help

✅ Async void method testing in xUnit

It isnt what im testing but i get how it could look like that. So my codebase currently follows the MVP pattern. When Submit is clicked in the view, an event is invoked that is then subscribed to and handled by HandleSubmit_Clicked. I can just extract the code like this:

 c# 
internal async void HandleSubmit_Clicked(object? sender, EventArgs e)
  {
    await HandleSubmit_ClickedAsync(sender, e);
  }

  internal async Task HandleSubmit_ClickedAsync(object? sender, EventArgs e)
  {
      try
      {
          bool Valid = await ValidFormAsync();
          if (Valid)
          {
              _logger.LogInformation("Is valid");
              _dataForm.OnSubmissionComplete(this, new SubmissionCompletedEventArgs(_dataForm.GetData(), _dataForm.Mode));
              SubmissionCompleted?.Invoke(this, new SubmissionCompletedEventArgs(_dataForm.GetData(), _dataForm.Mode));
          }
          else
          {
              _logger.LogInformation("Is not valid");
          }
      }
      catch (Exception ex)
      {
          _logger.LogError("Submission Failed due to: {Exception}", ex.Message);
          _dataForm.ShowMessageBox("Submission Failed", "Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
      }
  }

 c# 
internal async void HandleSubmit_Clicked(object? sender, EventArgs e)
  {
    await HandleSubmit_ClickedAsync(sender, e);
  }

  internal async Task HandleSubmit_ClickedAsync(object? sender, EventArgs e)
  {
      try
      {
          bool Valid = await ValidFormAsync();
          if (Valid)
          {
              _logger.LogInformation("Is valid");
              _dataForm.OnSubmissionComplete(this, new SubmissionCompletedEventArgs(_dataForm.GetData(), _dataForm.Mode));
              SubmissionCompleted?.Invoke(this, new SubmissionCompletedEventArgs(_dataForm.GetData(), _dataForm.Mode));
          }
          else
          {
              _logger.LogInformation("Is not valid");
          }
      }
      catch (Exception ex)
      {
          _logger.LogError("Submission Failed due to: {Exception}", ex.Message);
          _dataForm.ShowMessageBox("Submission Failed", "Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
      }
  }

the async Task should be testable but it looks messy. If i try to make the handleSubmit itself async Task, i get the error "'Task DataFormPresenterTemplate.HandleSubmit_Clicked(object?, EventArgs)' has the wrong return type". Hence why i want to do a bit of research.

30 replies

CC#

•Created by [-InsertNameHere-] on 3/9/2025 in #help

✅ Async void method testing in xUnit

Could be, all good then. Ill look at how to re-design my code so the important parts are testable. Regardless, thanks for the assistance

30 replies

CC#

•Created by [-InsertNameHere-] on 3/9/2025 in #help

✅ Async void method testing in xUnit

As of now, none. Im just assuming there would be a situation somewhere and i havent seen it yet

30 replies

CC#

•Created by [-InsertNameHere-] on 3/9/2025 in #help

✅ Async void method testing in xUnit

I mean, i could but this feels like leaving the problem to the future. I assume there is atleast one case you would need to test async void? Or is that just a sign of bad code then?

30 replies

CC#

•Created by [-InsertNameHere-] on 3/9/2025 in #help

✅ Async void method testing in xUnit

in this particular instance, its just that the event is properly raised. If i remove await Task.Delay(100) from ValidFormAsync - it runs just fine but it hangs once i re-add it.

30 replies

CC#

•Created by [-InsertNameHere-] on 3/9/2025 in #help

✅ Async void method testing in xUnit

I wish. Unfortunately there is alot of places in winforms where i will need to deal with async void since there is buttons everywhere that i need to test

30 replies

Gaming

Programming