Michael
Michael
TTyphonJS
Created by TyphonJS (Michael) on 5/18/2024 in #typhonjs-runtime
Rest & Recovery 5e
Great, thanks. I'm in agreement: Everything seems to be working now, so I'm happy. I'd like to, as you mentioned, eventually move away from the bespoke elements (specifically I think the way settings are handled), but since right now I'm hitting full compatibility (as far as I can tell) in V11, V12, dnd5e 3.1.2 & dnd5e 3.2.0, those changes can wait
19 replies
TTyphonJS
Created by TyphonJS (Michael) on 5/22/2024 in #typhonjs-runtime
TRL `0.1.3` - v12 Hot Patch
And just so I know for the future, should this post have been in its own thread or was this an appropriate place for it @TyphonJS (Michael)?
11 replies
TTyphonJS
Created by TyphonJS (Michael) on 5/22/2024 in #typhonjs-runtime
TRL `0.1.3` - v12 Hot Patch
Ah yeah, looks like:
/**
* @typedef {Object} DocumentSheetRenderOptions
* @property {string} renderContext A string with the format "{operation}{documentName}" providing context
* @property {object} renderData Data describing the document modification that occurred
*/
/**
* @typedef {Object} DocumentSheetRenderOptions
* @property {string} renderContext A string with the format "{operation}{documentName}" providing context
* @property {object} renderData Data describing the document modification that occurred
*/
11 replies
TTyphonJS
Created by TyphonJS (Michael) on 5/22/2024 in #typhonjs-runtime
TRL `0.1.3` - v12 Hot Patch
Playing around a bit with V12, and for some reason when I take a peek at the updateOptions of a TJSDocument it seems to have not data but renderData - is that coming from V12 somehow?
11 replies
TTyphonJS
Created by TyphonJS (Michael) on 5/18/2024 in #typhonjs-runtime
Rest & Recovery 5e
@TyphonJS (Michael) Alright, I believe (I haven't done a ton of testing) I've got it working with 0.1.3, and svelte 4.2.17 (just based on what my package-lock is telling me - I just said ^0.1.0 and ^4.0.0 respectively). Besides running the svelte migration script (which didn't actually need to change anything), and ignoring automatic devDependencies version increases, here are the only changes I had to make to achieve the same functionality: - @typhonjs-fvtt/runtime -> #runtime in all imports - Sometimes I'd have @typhonjs-fvtt/runtime/_dist/.../index.js, replaced those (example: import { localize } from "@typhonjs-fvtt/runtime/_dist/svelte/helper/index.js" becomes import { localize } from "#runtime/svelte/helper") - One import changed path (TJSDocument went from just svelte/store to svelte/store/fvtt/document) If you can think of anything else obvious that I'd have missed and not been able to tell without more extensive testing, let me know! And then I can start to figure out how to better leverage TRL in the areas where I should be
19 replies
TTyphonJS
Created by TyphonJS (Michael) on 5/18/2024 in #typhonjs-runtime
Rest & Recovery 5e
Think I might give updating to a more recent TyphonJS today or tomorrow. Wanna get that stable and working in v11, dnd5e 3.1.2 before I start trying to account for v12 and 3.2
19 replies
TTyphonJS
Created by TyphonJS (Michael) on 5/18/2024 in #typhonjs-runtime
Rest & Recovery 5e
Gotcha, will keep that in mind
19 replies
TTyphonJS
Created by TyphonJS (Michael) on 5/18/2024 in #typhonjs-runtime
Rest & Recovery 5e
Plus it'll give me some time to familiarize myself with the docs
19 replies
TTyphonJS
Created by TyphonJS (Michael) on 5/18/2024 in #typhonjs-runtime
Rest & Recovery 5e
Sure, no rush! Will be nice to clean it up a bit, but nothing's breaking yet (🤞)
19 replies
TTyphonJS
Created by TyphonJS (Michael) on 5/18/2024 in #typhonjs-runtime
Rest & Recovery 5e
Right. I haven't done a full go-through of it all yet, mainly just fixing the areas in need of fixing
19 replies
TTyphonJS
Created by TyphonJS (Michael) on 5/18/2024 in #typhonjs-runtime
Rest & Recovery 5e
That's the main reason it needed taking over; it wasn't compatible with 3.x in a couple spots. I've noticed while making it compatible with Tidy5e that it's actually not compatible with the "New" 5e actor sheet where it injects html. But I'd imagine the only real issues with upgrading TRL would be any breaking changes on functions that are already being used
19 replies
TTyphonJS
Created by TyphonJS (Michael) on 5/18/2024 in #typhonjs-runtime
Rest & Recovery 5e
Yeah, it's fairly basic in terms of UI, most of the more complicated bits (which, even those aren't terribly complicated) are behind the scenes
19 replies
TTyphonJS
Created by TyphonJS (Michael) on 5/18/2024 in #typhonjs-runtime
Rest & Recovery 5e
Many thanks
19 replies