w00t Comments - Answer Overflow

w00t

•Created by w00t on 11/28/2024 in #questions

how to migrate from visit_mut_with to Pass?

that worked, thank you very much @kdy1 ! https://github.com/QwikDev/qwik/pull/7108/files#diff-06833470209cc7a65129df714c87d8de87c2ef2a0a13226187153ec7b9f40ba4

4 replies

SCSWC Community

•Created by w00t on 8/1/2024 in #questions

how can I mark a context?

https://github.com/QwikDev/qwik/blob/86d6378b625d43bf0bd14b35455dccd52517c97c/packages/qwik/src/optimizer/core/src/clean_side_effects.rs

6 replies

SCSWC Community

•Created by w00t on 8/1/2024 in #questions

how can I mark a context?

Me and copilot figured it out 😎 I'll drop the url soon

6 replies

SCSWC Community

•Created by w00t on 8/1/2024 in #questions

how can I mark a context?

impl VisitMut for CleanSideEffects<'_> {
    fn visit_mut_module(&mut self, node: &mut ast::Module) {
        node.body.retain(|item| match item {
            ast::ModuleItem::Stmt(ast::Stmt::Expr(expr)) => match &*expr.expr {
                ast::Expr::New(e) => {
                    if self.set.contains(&e.span()) {
                        return true;
                    }
                    self.did_drop = true;
                    false
                }
                ast::Expr::Call(e) => {
                    if self.set.contains(&e.span()) {
                        return true;
                    }
                    self.did_drop = true;
                    false
                }
                _ => true,
            },
            _ => true,
        });
    }
}

impl VisitMut for CleanSideEffects<'_> {
    fn visit_mut_module(&mut self, node: &mut ast::Module) {
        node.body.retain(|item| match item {
            ast::ModuleItem::Stmt(ast::Stmt::Expr(expr)) => match &*expr.expr {
                ast::Expr::New(e) => {
                    if self.set.contains(&e.span()) {
                        return true;
                    }
                    self.did_drop = true;
                    false
                }
                ast::Expr::Call(e) => {
                    if self.set.contains(&e.span()) {
                        return true;
                    }
                    self.did_drop = true;
                    false
                }
                _ => true,
            },
            _ => true,
        });
    }
}

6 replies

SCSWC Community

•Created by w00t on 8/1/2024 in #questions

how can I mark a context?

I cannot make it work 😭 . Sorry I'm a Rust newbie. It doesn't let me use the same mutable hashset in two visitors. Any hints on how I could restructure this?

use std::collections::HashSet;
use swc_common::{Mark, Span, Spanned};
use swc_ecmascript::ast;
use swc_ecmascript::visit::VisitMut;

pub struct Treeshaker<'a> {
    pub marker: CleanMarker<'a>,
    pub cleaner: CleanSideEffects<'a>,
}

pub struct CleanSideEffects<'a> {
    pub did_drop: bool,
    pub set: &'a mut HashSet<Span>,
}

pub struct CleanMarker<'a> {
    pub set: &'a mut HashSet<Span>,
}

impl Treeshaker<'_> {
    pub fn new() -> Self {
        let mut set = HashSet::new();
        Self {
            marker: CleanMarker { set: &mut set },
            cleaner: CleanSideEffects {
                did_drop: false,
                set: &mut set,
            },
        }
    }
}

impl VisitMut for CleanMarker<'_> {
    fn visit_mut_module_item(&mut self, node: &mut ast::ModuleItem) {
        if let ast::ModuleItem::Stmt(ast::Stmt::Expr(expr)) = node {
            match &*expr.expr {
                ast::Expr::New(e) => {
                    self.set.insert(e.span());
                }
                ast::Expr::Call(e) => {
                    self.set.insert(e.span());
                }
                _ => {}
            }
        }
    }
}

use std::collections::HashSet;
use swc_common::{Mark, Span, Spanned};
use swc_ecmascript::ast;
use swc_ecmascript::visit::VisitMut;

pub struct Treeshaker<'a> {
    pub marker: CleanMarker<'a>,
    pub cleaner: CleanSideEffects<'a>,
}

pub struct CleanSideEffects<'a> {
    pub did_drop: bool,
    pub set: &'a mut HashSet<Span>,
}

pub struct CleanMarker<'a> {
    pub set: &'a mut HashSet<Span>,
}

impl Treeshaker<'_> {
    pub fn new() -> Self {
        let mut set = HashSet::new();
        Self {
            marker: CleanMarker { set: &mut set },
            cleaner: CleanSideEffects {
                did_drop: false,
                set: &mut set,
            },
        }
    }
}

impl VisitMut for CleanMarker<'_> {
    fn visit_mut_module_item(&mut self, node: &mut ast::ModuleItem) {
        if let ast::ModuleItem::Stmt(ast::Stmt::Expr(expr)) = node {
            match &*expr.expr {
                ast::Expr::New(e) => {
                    self.set.insert(e.span());
                }
                ast::Expr::Call(e) => {
                    self.set.insert(e.span());
                }
                _ => {}
            }
        }
    }
}

ctd

6 replies

SCSWC Community

•Created by w00t on 7/20/2024 in #questions

wasm build uses old swc libraries?

Thank you so much for your help, it works now! The wasm build was because the cargo workspace was misconfigured and it had old dependencies.

6 replies

SCSWC Community

•Created by w00t on 7/20/2024 in #questions

wasm build uses old swc libraries?

Hmm, that upgraded several swc packages from .0 to .1, but now it no longer compiles:

   Compiling swc_allocator v0.1.7
   Compiling swc_atoms v0.6.7
   Compiling sourcemap v8.0.1
   Compiling swc_config v0.1.14
   Compiling napi v2.16.8
   Compiling swc_common v0.36.1
   Compiling swc_ecma_ast v0.117.1
   Compiling swc_fast_graph v0.24.0
   Compiling swc_ecma_visit v0.103.2
   Compiling swc_ecma_parser v0.148.1
   Compiling swc_ecma_codegen v0.154.1
error[E0432]: unresolved import `swc_allocator::collections`
 --> /home/wmertens/.cargo/registry/src/index.crates.io-6f17d22bba15001f/swc_ecma_codegen-0.154.1/src/text_writer/basic_impl.rs:3:21
  |
3 | use swc_allocator::{collections::FxHashSet, maybe::vec::Vec};
  |                     ^^^^^^^^^^^ could not find `collections` in `swc_allocator`

   Compiling swc_allocator v0.1.7
   Compiling swc_atoms v0.6.7
   Compiling sourcemap v8.0.1
   Compiling swc_config v0.1.14
   Compiling napi v2.16.8
   Compiling swc_common v0.36.1
   Compiling swc_ecma_ast v0.117.1
   Compiling swc_fast_graph v0.24.0
   Compiling swc_ecma_visit v0.103.2
   Compiling swc_ecma_parser v0.148.1
   Compiling swc_ecma_codegen v0.154.1
error[E0432]: unresolved import `swc_allocator::collections`
 --> /home/wmertens/.cargo/registry/src/index.crates.io-6f17d22bba15001f/swc_ecma_codegen-0.154.1/src/text_writer/basic_impl.rs:3:21
  |
3 | use swc_allocator::{collections::FxHashSet, maybe::vec::Vec};
  |                     ^^^^^^^^^^^ could not find `collections` in `swc_allocator`

6 replies

SCSWC Community