7 Replies
@AdrianP I am getting data from course-provider, but the plugin is not enabled and I am not following a course. I'm sure this is coming via n2k and following a route a few days ago via Raymarine MFD.
The notification is the annoying part. The message is "1", which of "course", means nothing when it shows on my phone and the loud alarms goes off on the boat.
The notification with "1" is a
perpendicularPassed
notification, PR #5 https://github.com/SignalK/course-provider-plugin/pull/5 fixes this message as well as a route calculation issue.
Interesting that there are values with the plugin not enabled.I think there is still a problem, that the plugin is doing work when it is not enabled?
lol. yes.
Hmm... it does spawn a worker thread to do the caclulations...it is triggered by a subscription to SK paths....
The worker is terminated when the plugin is disabled though..... very interesting.
should be in the start?
I didn't look at the code
Also I have been wondering what ALARM_STATE notifications for perpendicularPassed, ArrivalCircleEntered should have. There is no guidance in the spec so I am working on the priciple that priority is in the following order....lowest to highest
nominal, alert, warn, alarm, emergency
Also the notification is sent without an ALARM_METHOD to not trigger sound or visual.
@Scott Bender Can't seem to reproduce the issue where
calcValues
continue to get updated when the plugin is disabled.
PluginStart initialises SK path subscriptions and the worker.
PluginStop unsubscribes and terminates the worker.
The calcValues
remain in the data browser but are not updated.hmm
I am at the dock, still updating
I will debug this week