T
Task•4w ago
sedyh

Task is not tracking deleted generated files

Hello, I think I found the case to reopen this issue: https://github.com/go-task/task/issues/238 I want the Task to re-trigger gen, when I'm running clean: 
gen:
  sources:
    - protocol/**/*.proto
  generates:
    - pkg/protocol/**/*.pb.go
  cmds:
    - buf generate

clean:
  cmds:
    - rm -rf pkg/protocol/*
gen:
  sources:
    - protocol/**/*.proto
  generates:
    - pkg/protocol/**/*.pb.go
  cmds:
    - buf generate

clean:
  cmds:
    - rm -rf pkg/protocol/*
5 Replies
sedyh
sedyhOP•4w ago
Thats strange. The issue states it should track deleted files, but not edited, IIUC.
andreynering
andreynering•4w ago
@sedyh That should work. Do you confirm that it is not really working?
sedyh
sedyhOP•4w ago
Hello. I've managed to reproduce the issue. Let me show you a better example: 
version: '3'

tasks:
  gen:
    sources:
      - protocol/**/*
    generates:
      - pkg/protocol/**/*
    cmds:
      - mkdir -p pkg/protocol/google
      - touch pkg/protocol/google/important.pb.go
      - mkdir -p pkg/protocol/core
      - touch pkg/protocol/core/important.pb.go
  clean:
    cmds:
      - rm -rf pkg/protocol/core
  make:
    cmds:
      - mkdir -p protocol/google
      - touch protocol/google/important.proto
      - mkdir -p protocol/core
      - touch protocol/core/important.proto
version: '3'

tasks:
  gen:
    sources:
      - protocol/**/*
    generates:
      - pkg/protocol/**/*
    cmds:
      - mkdir -p pkg/protocol/google
      - touch pkg/protocol/google/important.pb.go
      - mkdir -p pkg/protocol/core
      - touch pkg/protocol/core/important.pb.go
  clean:
    cmds:
      - rm -rf pkg/protocol/core
  make:
    cmds:
      - mkdir -p protocol/google
      - touch protocol/google/important.proto
      - mkdir -p protocol/core
      - touch protocol/core/important.proto
ls pkg/protocol
core  google

task gen       
task: Task "gen" is up to date

task clean     
task: [clean] rm -rf pkg/protocol/core

ls pkg/protocol
google

task gen       
task: Task "gen" is up to date
ls pkg/protocol
core  google

task gen       
task: Task "gen" is up to date

task clean     
task: [clean] rm -rf pkg/protocol/core

ls pkg/protocol
google

task gen       
task: Task "gen" is up to date
The question is why task is up to date after deleting a directory with a file ( pkg/protocol/core/important.pb.go) that matches pkg/protocol/**/* pattern? Probably related: https://github.com/go-task/task/pull/1816 @andreynering (sorry for ping)
andreynering
andreynering•4w ago
@sedyh IIRC Task will just force the task to run if all generated files are deleted. It seems that yuo deleted one of the files but there is still one left there.
sedyh
sedyhOP•4w ago
Can we make the Task to restart the task in this case too? It seems to me that generated files really needs a full-fledged fingerprinting.

Did you find this page helpful?