F
Filament•5w ago
Will 🇬🇹

Prevent multiple calls to the same model

I have the following scenario 
Select::make('inventory_id')
    ->relationship('inventory', 'title')
    ->searchable()
    ->preload()
    ->live()
    ->required(),
TextInput::make('quantity')
    ->required()
    ->numeric()
    ->maxValue(fn(Get $get) => $get('inventory_id') ? Inventory::find($get('inventory_id'))->quantity : null)
    ->helperText(fn (Get $get) => $get('inventory_id') ? ['quantity' => Inventory::find($get('inventory_id'))->quantity] : null),
Select::make('inventory_id')
    ->relationship('inventory', 'title')
    ->searchable()
    ->preload()
    ->live()
    ->required(),
TextInput::make('quantity')
    ->required()
    ->numeric()
    ->maxValue(fn(Get $get) => $get('inventory_id') ? Inventory::find($get('inventory_id'))->quantity : null)
    ->helperText(fn (Get $get) => $get('inventory_id') ? ['quantity' => Inventory::find($get('inventory_id'))->quantity] : null),
Basically, I'm setting a maxValue on the quantity field. I'm also adding a helperText to give the user a more helpfull message. But I'm calling the same thing twice. Any recommendations to avoid doing this?
Solution:
I guess that's up to you to decide. I just said that because sometimes an extra find query is no big deal. In any case, if you're in laravel 11+, have a look at this too https://flanger.dev/blog/post/avoid-duplicate-queries-in-filament-closures-for-eloquent-records...
Jump to solution
4 Replies
ChesterS
ChesterS•5w ago
Not with built-in stuff AFAIK. You can set use a computed property but I'm not sure if it's worth the hassle. Something like 
public int $selected_inventory_id = null;

#[Computed]
public function inventoryCount(): ?int {
    return $this->selected_inventory_id 
      ? Inventory::find($this->selected_inventory_id)->quantity
      : null;
}
public int $selected_inventory_id = null;

#[Computed]
public function inventoryCount(): ?int {
    return $this->selected_inventory_id 
      ? Inventory::find($this->selected_inventory_id)->quantity
      : null;
}
and 
TextInput::make('quantity')
    ->required()
    ->numeric()
    ->maxValue(fn(Get $get) => $this->inventoryCount ?? null)
    ->helperText(fn (Get $get) => $this->inventoryCount ? ['quantity' => $this->inventoryCount] : null),
TextInput::make('quantity')
    ->required()
    ->numeric()
    ->maxValue(fn(Get $get) => $this->inventoryCount ?? null)
    ->helperText(fn (Get $get) => $this->inventoryCount ? ['quantity' => $this->inventoryCount] : null),
Sooomething like that
Will 🇬🇹
Will 🇬🇹OP•4w ago
Why is not worth the hustle? Coming from a point of DRY and optimization, calling the same thing multiple times makes no sense but honestly I might be ignoring something
Solution
ChesterS
ChesterS•4w ago
I guess that's up to you to decide. I just said that because sometimes an extra find query is no big deal. In any case, if you're in laravel 11+, have a look at this too https://flanger.dev/blog/post/avoid-duplicate-queries-in-filament-closures-for-eloquent-records
Will 🇬🇹
Will 🇬🇹OP•4w ago
Appreciate you tacking the time to answer. I like to optimice my code and having stuff doing the same thing multiple time didn't make too much sense.

Did you find this page helpful?