T
TyphonJS•2mo ago
Wasp

TJSConextMenu throwing error about its activeWindow optional parameter

Heyo - I was notified of a bug in Item Piles relating to right clicking on vault items, and its context menu not working; https://github.com/fantasycalendar/FoundryVTT-ItemPiles/issues/710 Not sure what caused this issue to become a problem with the new TRL versions. This is what I'm doing; 
TJSContextMenu.create({
    x: event.detail.x,
    y: event.detail.y,
    zIndex: 1000000000000,
    transitionOptions: { duration: 0 },
    items: contextMenu
})
TJSContextMenu.create({
    x: event.detail.x,
    y: event.detail.y,
    zIndex: 1000000000000,
    transitionOptions: { duration: 0 },
    items: contextMenu
})
The error seems to be coming from here (image 1), and I took a look at the if statement's function call (image 2), but that doesn't result in [object Window], but rather [object Function]. What gives?
No description
No description
2 Replies
Wasp
WaspOP•2mo ago
Ah, it seems that if I do not give TJSContextMenu.create an activeWindow property with the value window, it defaults to Window, which is a different thing altogether and thus errors. Seems unintentional? 😄
TyphonJS (Michael)
TyphonJS (Michael)•4w ago
I'll take a look and have an answer Saturday and may push out another 0.2.x release. To handle cross window checks not all JS engines are the same so I introduced a utility class [CrossWindow[(https://typhonjs-fvtt-lib.github.io/api-docs/classes/_runtime_util_browser.CrossWindow.html#iswindow) that does explicit to more duck type checking and this may be a case where that fails to work as intended. So... Instead of passing x / y try passing the event itself. It does look like your usage of TJSContextMenu was constructed from an earlier implementation in TRL. 
TJSContextMenu.create({
    event,
    duration: 0, // If you really need to change duration.
    items: contextMenu
})
TJSContextMenu.create({
    event,
    duration: 0, // If you really need to change duration.
    items: contextMenu
})
This block of code is assigning the activeWindow parameter from the event which allows it to function cross window IE say when popped out: https://github.com/typhonjs-svelte/standard-base/blob/main/src/application/menu/TJSContextMenu.js#L100-L106 It's also worth looking at the create signature. There is no transitionOptions, but there is duration if you actually want to change that. Also you don't need to explicitly assign a zIndex as Number.MAX_SAFE_INTEGER - 100 is the default. I can probably refine how various arguments to create are handled a bit in 0.3.0, but if passing the event solves your current usage I don't think an additional 0.2.x release is necessary. The only immediate improvement I can see is perhaps allowing x & y to actually be considered (line 118/119): 
{
 x: x ?? focusSource.x,
 y: y ?? focusSource.y,
}
{
 x: x ?? focusSource.x,
 y: y ?? focusSource.y,
}

Did you find this page helpful?