Filament•2mo ago

Are anonymous functions evaluated before ->assertFormField*?

The user being tested does not have permissions to edit $testUser's email. It works correctly via front end. If ->disabled() is set without the anonymous function the test passes. But with the anonymous function it always fails. I am assuming that the test is ran before the anonymous function executes, or am I doing something wrong. Test:

 livewire(EditUser::class, [$testUser->id])
        ->assertFormFieldIsDisabled('email');

 livewire(EditUser::class, [$testUser->id])
        ->assertFormFieldIsDisabled('email');

Field being tested:

TextInput::make('email')
  ->disabled(fn (User $user) => ! Auth::user()->can('update-email', $user))

TextInput::make('email')
  ->disabled(fn (User $user) => ! Auth::user()->can('update-email', $user))

17 Replies

awcodes•2mo ago

The user is not passed in with tests, you need define the user outside the livewire component and assert with the pest actingAs() helper. Ie, in test you define a user, then they will apply for that test.

BatmanOP•2mo ago

For brevity, I did not include that part of the test. But, yes that is done.

awcodes•2mo ago

But your code is passing in a user to the livewire component, which doesn’t make sense.

BatmanOP•2mo ago

I only included necessary part.

it('shows correct user fields for edit', function () {
    asAdmin();

    $testUser = User::factory()->create()->assignRole(Roles::REGISTERED_USER);

    livewire(EditUser::class, [$testUser->id])
        ->assertFormFieldIsVisible('name')
        ->assertFormFieldIsVisible('email')
        ->assertFormFieldIsVisible('bio')
        ->assertFormFieldIsVisible('avatar_url')
        ->assertFormFieldIsVisible('enabled')
        ->assertFormFieldIsVisible('email')
        ->assertFormFieldIsDisabled('email')
        ->assertFormFieldDoesNotExist('password')
        ->assertFormFieldDoesNotExist('password_confirmation');
});

it('shows correct user fields for edit', function () {
    asAdmin();

    $testUser = User::factory()->create()->assignRole(Roles::REGISTERED_USER);

    livewire(EditUser::class, [$testUser->id])
        ->assertFormFieldIsVisible('name')
        ->assertFormFieldIsVisible('email')
        ->assertFormFieldIsVisible('bio')
        ->assertFormFieldIsVisible('avatar_url')
        ->assertFormFieldIsVisible('enabled')
        ->assertFormFieldIsVisible('email')
        ->assertFormFieldIsDisabled('email')
        ->assertFormFieldDoesNotExist('password')
        ->assertFormFieldDoesNotExist('password_confirmation');
});

awcodes•2mo ago

Right, but there should be no need to pass test user into the component. Unless that is not the authenticated user.

BatmanOP•2mo ago

Even if I return false directly from an anonymous function is fails.

->disabled(fn () => false)

->disabled(fn () => false)

The admin (acting as) does not have permissions to edit this user's email. Therefor the email field is disabled. That is the point of the test. I have helper functions that set the necessary user for the test.

function asAdmin(): TestCase
{
    $admin = User::role(Roles::ADMINISTRATOR)->first();

    return test()->actingAs($admin);
}

function asAdmin(): TestCase
{
    $admin = User::role(Roles::ADMINISTRATOR)->first();

    return test()->actingAs($admin);
}

awcodes•2mo ago

Are admins also registered users? I could be wrong, sounds like the policy might be off.

BatmanOP•2mo ago

No, there are only single roles in this application. The anonymous functions are not being evaluated before the form test. This still fails:

->disabled(fn () => true)

->disabled(fn () => true)

awcodes•2mo ago

Maybe it’s because you are asserting twice that the form field isVisible for the email, based on the code you shared?

BatmanOP•2mo ago

I tried both, even if I only evaluate

->assertFormFieldIsDisabled('email')

->assertFormFieldIsDisabled('email')

it fails

awcodes•2mo ago

Maybe it’s not actually disabled. Something could be overriding it. That’s why I’m asking so many questions. Just trying to help with the limited insight I have to the code.

BatmanOP•2mo ago

The front end is working as expected. That's why I'm trying to figure out why the tests are not. 🤷‍♂️
In the image about, the email field is disabled.

awcodes•2mo ago

Don’t get me wrong, could be a bug just not seeing it at the moment.

BatmanOP•2mo ago

I'm having the same issue with testing readonly settings also. That is why I was wondering if there was something I didn't have correct, like waiting for the form to render first so the functions were able to execute.

awcodes•2mo ago

Not sure. Sorry. Haven’t come across anything being off as long as the user and permissions are set up correctly. If you have repo I can see I can explore further.

BatmanOP•2mo ago

I'm trying to make sure something didn't get out of sync between dev and testing database Yeah, I'm seeing some differences between the two repositories which I'm sure will help some of these anomalies. I'm still trying to figure out why ->disabled(fn () => true) isn't returning as disabled. So, if I uncomment $this->withoutVite(); in TestCase->setup() everything works correctly. Not sure why that would interfere, but there is a difference.

awcodes•2mo ago

Hard to say. Something could be overriding it.

Gaming

Programming

Are anonymous functions evaluated before ->assertFormField*?

Did you find this page helpful?