Better Auth•2mo ago

Adding Members to Organization with Teams Enabled

I am using the organization plugin with teams enabled and am trying to add members to the organization/team via the addMember API call:

await auth.api.addMember({
    body: {
      organizationId: <org_id>,
      userId: <user_id>,
      role: "admin",
      teamId: <team_id>, // this is not working
    },
  });

await auth.api.addMember({
    body: {
      organizationId: <org_id>,
      userId: <user_id>,
      role: "admin",
      teamId: <team_id>, // this is not working
    },
  });

I am trying this but when I inspect my database table, I do not see the teamId being recorded into the database column. What am I missing?

15 Replies

Netrifier•2mo ago

It seems the addMember function currently doesn't include the ability to specify a teamId. Hey @Ping , I'd be glad to make a pr to add teamId to addMember. Would that be okay?

Ping•2mo ago

cc @bekacru

bekacru•2mo ago

yeah go for it

Netrifier•2mo ago

Hey, I modified the findTeamById function in the org adapter to take in additional arguments. Does this look good to you, or would it be better to revert back to the original?

findTeamById: async <IncludeMembers extends boolean>({
            teamId,
            organizationId,
            includeTeamMembers,
        }: {
            teamId: string;
            organizationId?: string;
                        // Only return members if required
            includeTeamMembers?: IncludeMembers;
        }): Promise<
            (Team & (IncludeMembers extends true ? { members: Member[] } : {})) | null
        > => {

findTeamById: async <IncludeMembers extends boolean>({
            teamId,
            organizationId,
            includeTeamMembers,
        }: {
            teamId: string;
            organizationId?: string;
                        // Only return members if required
            includeTeamMembers?: IncludeMembers;
        }): Promise<
            (Team & (IncludeMembers extends true ? { members: Member[] } : {})) | null
        > => {

Netrifier•2mo ago

pr is ready for review, Let me know if the adapter method change looks good or if it should be reverted.

GitHub

feat(organization): Add teamId in addMember by Netrifier · Pull Req...

Added teamId option to addMember await auth.api.addMember({ body: { organizationId: <org_id>, userId: <user_id>, role: "admin", ...

MaveriX89OP•2mo ago

Thank you for the PR!

Sanjay Kholiya•2mo ago

is this member table schema from docs correct? If we are adding a member to a team, don't we need to specify the teamId in the member table as well?

Netrifier•2mo ago

yes, you need to add teamId in the member and invitation schema

Sanjay Kholiya•2mo ago

Cool, thanks. I had one more query, If I create a team inside an org, will org members be able to see all the teams or just the teams that they are a member of? I want that team should ONLY be visible to the members of that team. Other org members should not be able to see the teams they are NOT a part of. Is this possible with current implementation?

Netrifier•2mo ago

that would need to be handled at the application level as better-auth will only manage the auth You can query the team which includes the user and display this to the user.

Sanjay Kholiya•2mo ago

will try that, thanks

Netrifier•2mo ago

if you are using nextjs then you can check the team in the page component which will run on the server and pass the team to the rest of the components.

Jacob•4w ago

I would love to see support for multiple teams with another schema table. I just added a request to update the docs for missing team id in the invitation table so I will add the member table update there. We also need an update member to apply a new team. I think it’s only update role.

sethtjf.•4w ago

I’d like to see this too. I was attempting to implement today before realizing I’d need some custom code.

Jacob•4w ago

https://github.com/better-auth/better-auth/issues/2002

GitHub

Organization Plugin - Add/Update Members Team · Issue #2002 · bet...

Is this suited for github? Yes, this is suited for github Is your feature request related to a problem? Please describe. There is an update member role function, but we need a function to update th...

Gaming

Programming

Adding Members to Organization with Teams Enabled

Did you find this page helpful?