CTD after exiting Flashlight Settings
@SirDigby {Mod Name}
Crash report -->
FactoryGameSteam_FlashlightSettings_Win64_Shipping!TSet<TTuple<FString,UConfigProperty *>,TDefaultMapHashableKeyFuncs<FString,UConfigProperty ,0>,FDefaultSetAllocator>::FindIndexByHash<FString>() [C:\Program Files\Unreal Engine - CSS\Engine\Source\Runtime\Core\Public\Containers\Set.h:906]
FactoryGameSteam_FlashlightSettings_Win64_Shipping!SetConfigProp<float,UConfigPropertyFloat>() [C:\Code\SatisfactoryModLoader-1.0\Mods\FlashlightSettings\Source\FlashlightSettings\Private\FlashlightSettingsBPFunctionLib.cpp:22]
FactoryGameSteam_FlashlightSettings_Win64_Shipping!UFlashlightSettingsBPFunctionLib::StoreFlashlightSettings() [C:\Code\SatisfactoryModLoader-1.0\Mods\FlashlightSettings\Source\FlashlightSettings\Private\FlashlightSettingsBPFunctionLib.cpp:27]
FactoryGameSteam_FlashlightSettings_Win64_Shipping!UFlashlightSettingsBPFunctionLib::execStoreFlashlightSettings() [C:\Code\SatisfactoryModLoader-1.0\Mods\FlashlightSettings\Intermediate\Build\Win64\FactoryGameSteam\Inc\FlashlightSettings\UHT\FlashlightSettingsBPFunctionLib.gen.cpp:47]
FactoryGameSteam_CoreUObject_Win64_Shipping!ProcessLocalScriptFunction() [C:\BuildAgent\work\9fc8da665efb5ffd\UE4\Engine\Source\Runtime\CoreUObject\Private\UObject\ScriptCore.cpp:1225]
FactoryGameSteam_CoreUObject_Win64_Shipping!ProcessScriptFunction<void (__cdecl)(UObject *,FFrame &,void *)>() [C:\BuildAgent\work\9fc8da665efb5ffd\UE4\Engine\Source\Runtime\CoreUObject\Private\UObject\ScriptCore.cpp:1055]
FactoryGameSteam_CoreUObject_Win64_Shipping!UObject::execLocalVirtualFunction() [C:\BuildAgent\work\9fc8da665efb5ffd\UE4\Engine\Source\Runtime\CoreUObject\Private\UObject\ScriptCore.cpp:3234]
Happens no matter which method is used to exit the settings; pressing escape, pressing x on the UI, or re-pressing the hotbind
81 Replies
Does it happen every time?
Yup
Awesome. Thanks for the report
No worries, fingers crossed for a fix being not too bothersome
Do you have a full log?
It has been attached to this message.
-# Responding to
Crash found in FactoryGame.log triggered by @SirDigby {Mod Name}Whew
Okay, let me try to reproduce because this doesn't make any sense
@Bababooie {Class::Null} are you on SML 3.1?
3.1 or 3.10?
3.10, yeah
Can you please send the config file for the mod? e.g.
C:\Program Files (x86)\Steam\steamapps\common\Satisfactory\FactoryGame\Configs\FlashlightSettings.cfg
It's in the game installation diruno momento
I'll get another crash log now as well
Hmmm, file looks like it has all the stuff in the section
It has been attached to this message.
-# Responding to
Crash found in FactoryGame.log triggered by @Bababooie {Class::Null}i.e. it's like mine (I cannot reproduce the crash) with the only difference being the values
Have you got it on the default hotkey
I'm going to rebuild the mod and release that
Yes
Oh, I rebuilt the mod
Because I had to rebind mine because there is some weird conflict between it and the time of day control mod (cant remember the name)
SkyUI
that one
yeah
Ah yes, I just ignore the conflict
If I open SkyUI first, I can then open Flashlight Settings
Yeah, it's weird
Yeah I found that workaround as well but didn't want to keep dealing with it, could be because I rebound it
I'll go set it back to default and see if it happens again
Don't think that's the issue
i rebound it to f6 if you want to try that
still wanna rule anything out
was it right shift+L for default?
I don't wanna reset all my other binds
I actually have the same SML version as you
I thought I had built SML from dev, but no
wait leftshit+L rather
Ok, just released a new version. Please try that
:ai_antivirus_moment:
will do 👍
(it's going to take a moment due to virustotal scanning)
It's done, abut to load
I waited until the scan was done and it was actually released
Ah, then KBot is slow
It's good 👍
Tysm
It checks for updates every 15 minutes instead of using the webhook
Solution
TL;DR recompiling the mod fixed the issue
no conflict with sky ui either anymore
based
goated
lightpilled
Some lore: this is from the days when one of the AI antiviruses in VirusTotal would randomly flag stuff as malware, requiring manual intervention
lmao
I think it might still do that, but SMR now requires more than 1 AV to flag it
wait no I spoke too soon, there is still some strange interaction
gfdi
mb mb
confused noises
Okay, when you close Sky UI, something changes and stops allowing you to open flashlight settings. If you open close it again you'll be able to open flashlight settings, but only once, until you open and close SkyUI again, but, if you open and close SkyUI twice in a row, you won't be able to open flashlight settings
a bool somewhere is having a time of it
yup, definitely erroneous bool set-age
can't tell you which one
something about closing SkyUI is flipping it, allowing or disallowing the opening of Flashlight settings
The bool: (╯°□°)╯︵ ┻━┻
┬─┬ ノ( ゜-゜ノ)
-# Responding to
flip triggered by @Rex [they/them]lmfao
If you're bored, check if this runs properly (in
Comp_FlashlightSettings)
I can think of 2 problems: the input action not firing for some reason (maybe switch to Started?) and the Branch taking the wrong path (if "Contains Interact Widget Of Class" still returns true for some reason)
Also feel free to check if Th3WwiseBrowser has the same issue, as it uses the same logic to open its widget, but the widget itself is different
I tried removing the close on hotkey bit and it didn't fix it
Although I did a dumb and left the branch in
Huh?
Ah, you did it as a test
Yeah, bypassing that doesn't fix it
The only difference I see is that I'm doing the event binding on Construct instead of On Initialized (On Initialized feels more correct btw)
Does the input action get called every time?
Oh, I see a thing
I only have the first one in Th3WwiseBrowser
Huh, apparently killing the 2nd one seems to make the keybind work consistently
Okay, I tried swapping the input to "triggered" instead of "completed" and got at leaste a somewhat different result
I just need to handle the input within the widget now, to be able to close it when pressing the keybind again
flashlight settings opened reliably, but only if you let go of L after shift, but the skyui would open a second time by only pressing L after opening it normally with ctrl L
but only if you don't try to open flashlight settings in between closing it
trying "started" condition now
Now a similar thing happens, but flashlight settings opens on the solo L press, not SkyUI now
flashlight settings still opens reliably as long as L is let go after shift
Going to try "canceled" now
I think Completed is the right thing to use
Probably, yeah
Now once you've opened one, pressing L by itself will just swap which one opens after you close the other
Okay no so I was entirely right the first time with it on "completed"
when it does allow you to open flashlight settings, pressing L by itself will open skyui
and then not let you open flashlight settings until you open and close sku ui one more time
Oh yeah, it's debuggin' time
It's just straight up not registering that the action is happening after it's closed until SkyUI is opened and subsequently closed
Doesn't matter if you exit from flashlight with the ui, escape, or shiftL again
I'm gonna try it with my rebind
Now that it isn't crashing at least
I think the mapping context isn't using the right parent or something because it does nothing until you open an interact UI
e.g. build menu
Okay, yeah you're right it is any iteract ui
but pressing L solo still is opening up SkyUI
That might be on SkyUI's end
Okay I haven't rebound it but now it's just always working??? and Sky UI is always opening without having control pressed??
I don't know what is going on
Yeah, it's haunted
Wait, gotta reboot one more gain to check a thing
Opening the build menu was what fixed it
It has all those weird caveats mentioned about until you use the build gun, then it just starts working properly.
Well, SkyUI just opens whenever you press L, but flashlight settings don't need the convoluted opening skyui beforehand
And then breaks it again
using any interact UI is toggling its availability
well, toggling in between working normally, and only working in between every second skyui open and close 🙃
I was literally laying down for bed when I got pinged and now I'm absolutely wired lmao this is a lovely puzzle
You should go to sleep
using literally any other keybind than shift/ctrl+L makes it work completely normally
Might I recommend shift/ctrl+B, since that's the flashlight button
I got used to having mine on f6 so I'll probably stick with that but yeah, if you can change that as a default then there should be no further issues
I mean, it's likely just a conflict with SkyUI
there seems to be some kanj with how it's handling ctrl and shift
since it's saying the wrong thing when I go to rebind them on the L
like if I just try to set it to right shift + L, it'll always say left shift +L
and work with either
same with ctrl
That's a known thing
Then whatever is causing that issue is likely the culprit here too
Or at least somewhat involved
Maybe just a recommendation to rebind one or the other to something else if you have both mods?
If people complain about it
fair cop
alright well I will do the winding down thing for reals now, thanks for the puzzle, but more importantly getting that fix out so quick, is much appreciated 👍