HansT - @Teppo Kurki Asking here for others to ...
@Teppo Kurki Asking here for others to read/see. On GPS rollover fix, my current approach is in n2k-signalk/pgns/129029.js. The downside is that this means it will do it for any source and always. This breaks the test cases and e.g. prevents running old n2k captures through it, as it will correct them as well.
Is it possible to make it a plugin and correct the value as it comes it, that way possibly making a filter for the source id, or at least easily turning it on/off when needed? Like signalk-calibration.
But it's unclear to me if this approach will avoid the wrong date to be seen by the system or any other plugin (like set-system-time).
2 Replies
So this would need to be per source? We can pretty easily add parameters to a connection’s internals, like verify Checksum for nmea 0183
A plugin can intercept and modify incoming sk deltas, but that is a pretty awkward solution to this problem, not exactly user friendly
It doesn't have to be per source. It's more that one could want it not to happen (e.g. with old logs). So being able to switch it on/off would be nice. A 'old-gps-week-rollover-fix-plugin' doesn't sound too user unfriendly to me. But I'll go with anything that works.
How would the 'add parameters to a connection's internals' work?