C#•3w ago

Sloppy Constructors

I know I'm missing something here. There's likely a better way of doing the below?

public class SolidColorBrush : Brush
{
    public Color Color { get; set; } = System.Drawing.Color.White;

    public SolidColorBrush()
    {
        BrushType = Enums.BrushType.Color;
    }

    public SolidColorBrush(Color color)
    {
        Color = color;
        BrushType = Enums.BrushType.Color;
    }
}

public class SolidColorBrush : Brush
{
    public Color Color { get; set; } = System.Drawing.Color.White;

    public SolidColorBrush()
    {
        BrushType = Enums.BrushType.Color;
    }

    public SolidColorBrush(Color color)
    {
        Color = color;
        BrushType = Enums.BrushType.Color;
    }
}

6 Replies

blueberriesiftheywerecats•3w ago

public SolidColorBrush(Color color) : this()
    {
        Color = color;
    }
}

public SolidColorBrush(Color color) : this()
    {
        Color = color;
    }
}

Or just override BrushType

Krishna•3w ago

public class SolidColorBrush : Brush
{
    public Color Color { get; }

    public SolidColorBrush() : this(System.Drawing.Color.White)
    {
    }

    public SolidColorBrush(Color color)
    {
        Color = color ?? throw new ArgumentNullException(nameof(color), "Color cannot be null.");
        BrushType = Enums.BrushType.Color;
    }
}

public class SolidColorBrush : Brush
{
    public Color Color { get; }

    public SolidColorBrush() : this(System.Drawing.Color.White)
    {
    }

    public SolidColorBrush(Color color)
    {
        Color = color ?? throw new ArgumentNullException(nameof(color), "Color cannot be null.");
        BrushType = Enums.BrushType.Color;
    }
}

Doing so can improve below: 1. Immutability - The Color property is now read-only (get; only), making the class safer and easier to work with in multi-threaded or complex scenarios. 2. Constructor Chaining: - The parameterless constructor calls the main constructor with the default Color.White. This eliminates duplicate logic and makes it easier to maintain. 3. Validation: - A check ensures that the color is not null, preventing potential errors. 4. Simplified Initialization: - The logic to set the default color and brush type is centralized in the constructors.

:', ryte ,':•2w ago

System.Drawing.Color is a struct, is this ai generated?

SleepWellPupper•4d ago

Please refer to the $rules Specifically:

Relaying ChatGPT/AI generated answers or sending Let Me Google That For You links is heavily discouraged, use of either may not be tolerated.

MODiX•4d ago

https://cdn.discordapp.com/attachments/569261465463160900/1301151112606253148/image0.jpg

SleepWellPupper•4d ago

Sorry about the reaction image, I assumed that tag produced the rules list.

Gaming

Programming

Sloppy Constructors