SolidJS•13mo ago

Throw vs return in router’s action

Suppose I have an action that should redirect.

In the docs(https://docs.solidjs.com/solid-router/reference/data-apis/action) I found example of both returning and throwing a redirect.

Which should be used and when?

TaQuanMinhLong•11/21/24, 12:48 AM

just simply choose one that works

TaQuanMinhLong•11/21/24, 12:48 AM

:Worry_PatKEK:

TaQuanMinhLong•11/21/24, 12:48 AM

i personally go with throw redirect

TTaQuanMinhLong just simply choose one that works

bitobeatsOP•11/21/24, 2:25 AM

So you’re saying they work the same way?

Bbitobeats So you’re saying they work the same way?

TaQuanMinhLong•11/21/24, 3:03 AM

:Worry_DontKnow:

TaQuanMinhLong•11/21/24, 3:03 AM

not sure

TaQuanMinhLong•11/21/24, 3:03 AM

but i prefer to throw

TaQuanMinhLong•11/21/24, 3:03 AM

as actions are meant to return results

TaQuanMinhLong•11/21/24, 3:03 AM

i don't think redirect is a result of something

bitobeatsOP•11/21/24, 3:04 AM

Then why is it recommended in the docs?

TaQuanMinhLong•11/21/24, 3:04 AM

it should be some kind of value like {error} or {success: true} etc..

Bbitobeats Then why is it recommended in the docs?

TaQuanMinhLong•11/21/24, 3:07 AM

@Atila

TaQuanMinhLong•11/21/24, 3:08 AM

:Worry_DontKnow: i think i'll just let him handle this

bitobeatsOP•11/21/24, 3:10 AM

No worries! Thanks for trying to help and bringing someone who may have this information to the discussion

TaQuanMinhLong•11/21/24, 3:14 AM

:_Worry_Sir:

Atila•11/21/24, 9:19 AM

thanks for the mention @TaQuanMinhLong

the short answer is: you can return and throw the redirect and they'll most likely work well for you

Atila•11/21/24, 9:20 AM

the longer answer is that in JS will stop the function execution, interrupting the program and propagating this effect updwards. While will gracefully end and offer back the value.

So, as you can imagine, when it comes to a it makes little difference, but you'd be right in expecting the to be a bit more predictable and immediate in that case.

TTaQuanMinhLong but i prefer to throw

Atila•11/21/24, 9:24 AM

+1 on throw. I also think it's more idiomatic and it correlates well on how operates too

Under the hood, Suspense throws a promise to allow it to propagate towards the outer scope - essentially that's what we want with a redirect, so things click better inside my head when I'm reasoning about the control flow.

As you said, a isn't a directly related to the outcome of the , it's more of an "app state" thing. We send the user somewhere else and that interrupts the flow they were at, theoretically, it's "above the paygrade" of a simple form submission... so throwing makes more sense to me too

TaQuanMinhLong•11/21/24, 9:24 AM

:Worry_Stonk:

TaQuanMinhLong•11/21/24, 9:25 AM

then should we also fix the docs

TaQuanMinhLong•11/21/24, 9:25 AM

:Worry_Think:

Atila•11/21/24, 9:27 AM

yeah, I think for the sake of consistency it could be better to have in the code snippets - perhaps add a note about how return/throw can work would be best.

The Data Loading entries are overdue some work for sure