Scott Bender - wtf?

wtf?
No description
27 Replies
Scott Bender
Scott BenderOP3mo ago
where is "Data should be of type number" coming from? it's not the UI. Also coming from HTTP requests from meta data.
Tony
Tony3mo ago
Time for an automation suite in the GitHub action pipeline
Teppo Kurki
Teppo Kurki3mo ago
@Tony what are u talking about? @Scott Bender what do you have in basedeltas?
Tony
Tony3mo ago
More UI and api tests
Scott Bender
Scott BenderOP3mo ago
a bunch of stuff I'll play with that...
Teppo Kurki
Teppo Kurki3mo ago
Yes, we could have better test coverage, but unless you know what the problem is you are jumping the gun
Tony
Tony3mo ago
Is it possible to get to this state without making an http request or websocket message event? I understand if you don’t want to discuss, but perhaps there is a way to prevent this by ensuring both will have data boundaries
Teppo Kurki
Teppo Kurki3mo ago
at this time i have no idea what has happened here. maybe Scott accidentally copypasted Data shoudld be of type as description for stateOfCharge....
Scott Bender
Scott BenderOP3mo ago
No, I checked for that I can't find that string anywhere it's two different servers also
Teppo Kurki
Teppo Kurki3mo ago
so: is that reproducible?
Scott Bender
Scott BenderOP3mo ago
not on all path
Teppo Kurki
Teppo Kurki3mo ago
that looks like a schema validation error message
Scott Bender
Scott BenderOP3mo ago
it's on my prod server and local test server
Scott Bender
Scott BenderOP3mo ago
I can look into it this week. Just wanted to make sure it was not obvious
Teppo Kurki
Teppo Kurki3mo ago
electrical.batteries.1.capacity.timeRemaining
Scott Bender
Scott BenderOP3mo ago
a lot of paths, but not all I also planning on updating/adding displayName for everything if that is cool with you? Will help with being able to ask Siri for values.
Teppo Kurki
Teppo Kurki3mo ago
you mean update those in schema files?
Scott Bender
Scott BenderOP3mo ago
yes
Scott Bender
Scott BenderOP3mo ago
Pretty cool . I can ask Siri, “Get the boat summary”, and she will read back the info to me.
No description
Scott Bender
Scott BenderOP3mo ago
With displayName meta, she says "The Apparent Wind Speed is xxx" I can also ask "What's the Apparent Wind Speed" not sure if you are following the latest beta's? but this stuff is very neat. Automations are really interesting.
Teppo Kurki
Teppo Kurki3mo ago
something is picking up the Data should be descriptions in schema definitions.json
GitHub
specification/schemas/definitions.json at 1978f556d8790be2b3bfdc9ff...
Signal K is a JSON-based format for storing and sharing marine data from different sources (e.g. nmea 0183, 2000, seatalk, etc) - SignalK/specification
Teppo Kurki
Teppo Kurki3mo ago
...this has been there since forever, it is in @signalk/signalk-schema keyswithmetadata.json...
Scott Bender
Scott BenderOP3mo ago
probably. Don't think I ever looked until now.
Teppo Kurki
Teppo Kurki3mo ago
GitHub
"Data should be of type number." in metadata description · Issue #6...
Something is picking up erroneously description values that are in definitions.json and they end up in keyswithmetadata.json and in metadata for entries that don't have their own description. O...
Scott Bender
Scott BenderOP3mo ago
but stateOfCharge does have have a description
Teppo Kurki
Teppo Kurki3mo ago
ah my mistake, please update the issue
Want results from more Discord servers?
Add your server