Matti Airas - User Offspring (on GitHub, don) h...
User Offspring (on GitHub, don't know whether he's here) has made several code quality improvement PRs against a few SensESP-related repos. (Thanks!!) Inspired by that, I ran the
clang-tidy static analysis tool against SensESP proper and fixed a ton of warnings. The result is in this PR: https://github.com/SignalK/SensESP/pull/737
The PR does break some old code because the reactesp namespace needs to be explicitly declared whenever the code is not using reactesp (which is a no-no in header files).GitHub
Fix clang-tidy warnings by mairas · Pull Request #737 · SignalK/Sen...
I ran clang-tidy against the SensESP codebase and fixed (most of) the issues. While this overall results in improved code quality and consistency, there are some breaking changes as well. In partic...
3 Replies
Additionally, there are a couple of other noteworthy changes I've planned. First, renaming the ReactESP classes to better reflect their actual behavior:
https://github.com/mairas/ReactESP/pull/29
And possible migration to Android 3:
https://github.com/SignalK/SensESP/issues/738
GitHub
Rename classes by mairas · Pull Request #29 · mairas/ReactESP
Given that at its core ReactESP implements an async event loop, the implementation class names could be clearer. This PR renames the classes as follows:
ReactESP -> EventLoop
*Reaction -&...
GitHub
Migrate to ESP-IDF 5.x and Arduino 3.x · Issue #738 · SignalK/SensE...
The Espressif and PlatformIO are in an unfortunate staring contest wrt. supporting Arduino Core 3 and ESP-IDF 5.x in PlatformIO. As a result, the ESP32 Arduino Core in PlatformIO isn't getting ...
Unknown User•4mo ago
Message Not Public
Sign In & Join Server To View
Right, thanks. I fixed that in the repo.