new feature "needs approval" triggered by kodiakhq merges
(I'm seeing a slight variation of this issue... not quite the same so I didn't want to put this in the other "needs approval" thread.)
I'm the only member of my team, and i'm the author of the PR that got merged, but railway still wants me to approve my own commit.
There's hardly any UI / feedback indicating what's going on, except that the deployments list has started showing these github profile images (see attached) indicating that there's two authors of the PR - but the UI doesn't show which authors or how it is deciding that an approval is needed.
The UI shows my email as the one that needs approval - which is the same email I use for railway login / member of my org
My theory is that the reason I'm seeing this is because we're using kodiakhq to merge our PRs, but railway incorrectly shows me as the user that needs approval.
16 Replies
Project ID:
58cd7410-04d6-4c6e-a74d-fa7c78455231Project ID 58cd7410-04d6-4c6e-a74d-fa7c78455231
to answer your design question -
the two bubbles, one with a GitHub logo and one with the coloured bubble, the GitHub logo is representing that it is a deployment from GitHub, if your source was for example a docker image, you would have a docker logo.
as for everything else you brought up - @Angelo
Hey @Arnór - we just shipped a fix to the commit accuracy problem. But it seems that you use a bot for merging? If so, that's an edge case we didn't catch, we are going to work on a fix that will make it so that your bot can be the primary actor for deployments on the platform.
Which bot is this one, can you link me?
@Arnór bump
yeah, kodiak, one sec
Kodiak · Automate your GitHub Pull Requests
Automate your GitHub Pull Requests
If you don't mind me asking, what does this do and what benefits it brings you?
it's something you install on github / configure a .toml file, and then set up so once a PR is approved by reviewers, and passes all checks.. it makes sure your branch is up to date with master, and merges with custom settings (if youv'e set up any) for commit message etc
it makes it so you don't really have to monitor your PRs and keep manually updating with master, and prevents people from accidentally merging something they weren't supposed to
it also makes it so that if your contributors don't have merge-permissions on your master/main branch, the branches get merged automatically by kodiak, if all the checks / approvals have been met
i was using it at a larger team, and now i'm just addicted to it
Gotcha, I am going to see if I can add this under the bot users check we got. If not me, then Paulo, our engineer who is working on cleaning up our deployment flows.
The unrelenting battle of big company requests (RBAC) and fast independent developers rages on.
Sorry you've been burned by this.
😄
no problem,.. fully understand
i'm just really greatful for railway - it's been really fantastic for me
I have a crowd of angry people on both sides, appreciate the understanding.
no problem, keep it up
it's no problem to approve the deployments actually.. kind of nice in some ways too. as long as it actually deploys after approving 😄
@angelo So if you don't mind me asking instead - why did you choose an implementation based on matching emails from commit messages to Railway users (wtf) instead of giving the Railway admin the ability to configure a list of privileged committers?
Its done via GH account link, not raw email.
Mind if you make a new thread and I can take care of ya there?
I want to work with you to find a resolution, we aren't doing this out of a sole desire to make money.
I am just curious, no problems, hence wrote in this existing thread
All good my guy.
I wouldn't put it past it for me to do an email match. Luckily, they don't let write code anymore.
Tag me in and I can explain it.