Meaning of red and green in config changes

struggling to see the difference between red and green, is green the latest version the code? more specifically i have put input shaping into the user overrides section and it seems that the changelog does not like it. to keep the IS settings, in the photo should i select ignore or overide?
No description
27 Replies
miklschmidt
miklschmidt5mo ago
Red = deleted Green = added It may make more sense to you if you click the single screen layout option to the right in the header You can for the most part ignore changes to printer.cfg from the configurator Printer.cfg shouldn't need to change, often it's just comments or limits got new defaults etc, which is not useful to you on an already running printer. It can't merge in your custom changes, (automatic conflict resolution is currently an unsolved computer science issue). It does port your klipper config section however, because it's always in a predictable location in the file. There are plans to reduce and eventually eliminate any updates to printer.cfg, but it's still a bit further out. I'll see if i can add a note about this specifically for printer.cfg in the modal
Hydr0s
Hydr0sOP5mo ago
thanks mikl, and sorry for the number of questions, is there a resource online that would allow me to read up on how every part of the conifg works? Like for example if i do hit ignore, does that ignore the clashes or ignore my changes made and revert back? if it ignores the changes that would not be good as input shaper is a change made? im currently designing a heater and surely the settings for this would need to go into the config? to make it simpler i took someones advice and started to use the include command to bring in my custom overrides. is the printer.cfg even the correct place to include the custom changes i make?
miklschmidt
miklschmidt5mo ago
Like for example if i do hit ignore, does that ignore the clashes or ignore my changes made and revert back
If you hit ignore, it'll ignore the changes, meaning it'll leave the file alone.
if it ignores the changes that would not be good as input shaper is a change made
That change is made in RatOS.cfg, different file. Everything important goes into RatOS.cfg Anything the configurator wants to do to printer.cfg is just there for convenience, like comments and duplicated limits etc.
is there a resource online that would allow me to read up on how every part of the conifg works?
Not yet no. Well besides the klipper docs that explains how klipper configuration works.
im currently designing a heater and surely the settings for this would need to go into the config?
Printer.cfg for custom stuff, you can do whatever you want in there.
Hydr0s
Hydr0sOP5mo ago
ahh okay, from now on i will edit ratos.cfg for things like putting in IS, adding chamber heaters ect, and ill use the [include] command to do it thanks
miklschmidt
miklschmidt5mo ago
to make it simpler i took someones advice and started to use the include command to bring in my custom overrides.
That's fine, but you could just ignore changes to printer.cfg, it's highly unlikely you'll need them.
is the printer.cfg even the correct place to include the custom changes i make?
Yes, printer.cfg is where all your custom stuff goes. nonononono 😄
Hydr0s
Hydr0sOP5mo ago
wait sorry i get it make changes to printer.cfg getting confused
miklschmidt
miklschmidt5mo ago
You got it 👍
Hydr0s
Hydr0sOP5mo ago
i guess what ive not been sure is you keep saying to hit ignore wait
miklschmidt
miklschmidt5mo ago
Yes, ignore changes to printer.cfg
Hydr0s
Hydr0sOP5mo ago
i get it ok when we were saying ignore i thought ignore the changes meant it would ignore them and use the original but it acc means ignore the change and keep my changes got it completely now
miklschmidt
miklschmidt5mo ago
It's just convenience stuff. If it wants to make changes to printer.cfg it's because it wants to update some comments or some defaults changed etc, there's rarely any reason to not ignore those on a running printer.
Hydr0s
Hydr0sOP5mo ago
this is very ironic as 2 years ago i wrote my dissertation on designing a corexy from scratch and i configured everything on klipper
miklschmidt
miklschmidt5mo ago
It was not supposed to add stuff to printer.cfg at all, but i had to or otherwise people would be too confused Oh i should probably make this more clear in the interface
Hydr0s
Hydr0sOP5mo ago
i think that would be good
miklschmidt
miklschmidt5mo ago
I need to somehow communicate that what it shows is what the configurator wants to apply to your files. I'll change the title to something like "RatOS wants to make the following changes to Printer.cfg"
Hydr0s
Hydr0sOP5mo ago
good idea
miklschmidt
miklschmidt5mo ago
and add a note specifically in the printer.cfg window, that changes to printer.cfg is rarely needed on running printers and can be ignored.
Hydr0s
Hydr0sOP5mo ago
and maybe instead of ignore use keep original, and overwrite
miklschmidt
miklschmidt5mo ago
Yes this is good "Keep existing" maybe
Hydr0s
Hydr0sOP5mo ago
yep something along those lines
miklschmidt
miklschmidt5mo ago
So users don't think "original" means "RatOS" 😄
Hydr0s
Hydr0sOP5mo ago
otherwise you have built a fantastic software, and i really hope more people use it so much more functionality than stock klipper
miklschmidt
miklschmidt5mo ago
This is the worst it'll ever be! 🙂
Hydr0s
Hydr0sOP5mo ago
and much sexier 😉
miklschmidt
miklschmidt5mo ago
I have plans to get everything out of printer.cfg an into the configuration interface as well as make dedicated pages for toolhead settings etc so that you don't have to go through the wizard for common changes.
Hydr0s
Hydr0sOP5mo ago
i know you must be swamped but hopefully after the vcore 4s have been out in the wild and the edge cases have been covered youll get a lot less questions, you helge and cruz
miklschmidt
miklschmidt5mo ago
Depends on how much new stuff we keep adding 😄 For example i just pushed IS modelling and peak detection to the realtime analysis tool a few days ago (as well as significant memory and performance improvements) Noone really knows how to use that thing yet
Want results from more Discord servers?
Add your server