signalk-derived-data plugin is a mess
There are many issues open, number of PR and nothing gets done about it.
Thanks
63 Replies
You are welcome to help out
Actually, I take that back.
There are PRs
You can create your own. That way you won’t have to complain to us.
I can. But why?
it’s a published plugin. Users use it
needs to be fixed for them. Or not?
You do realize that the people that work on this stuff donate their free time and might have a lot on their plates?
You should think about how you treat us and speak to us
I can promise you that I won’t lift a finger to help anyone that does what you are doing.
I do donate my free time too. And I work on opensource projects on my free time free of charge. I haven’t received any money from it. What does make you special apart from me to talk to me like that?
lol
exactly
So you want to be treated with respect? But you don’t think you should treat others with respect?
I didn’t treat you or anyone with disrespect. You did that to me. I reported a bug
Say you think saying that something I created and maintain “is a mess” is respectful?
Maybe next time, try offering a solution instead of just complaining
Solution is to check for null and exact 0 in magnetic variation and do not trust it. Do not use 0 for magnetic variation in further calculations
I didn’t even see your new issue.
It it is kinda in the same vane
I was actually just talking about your “question” here.
I paid for your software Whilhelm. Not that I need it. As a support gesture. I do not make any money whatsoever for open source projects I make. Saying something is a mess when it it a mess is stating a fact. Facts can’t be offensive. You attack me personally by saying you won’t leave a finger for what I report regardless of what it is. Do you see difference???
I just merged a bunch of PRs and published a new version yesterday, so ”nothing gets done” is clearly not true
Well it’s still buggy
I’ve built out of it just few minutes ago and tested
If somebody finds your communication offensive simply saying that ”this is a fact” does not make it less offensive or motivate the other person to spend time on it
I didn’t attack anyone personally. Instead I was attacked personally for bringing up the issue
If you know the fix why are you not submitting pull requests, only very short issues?
I just stated a fact
Fix is a trivial null and 0 check. As someone who didn’t work on it, it’s more time for me than the author to fix it
So therefore, it can’t be offensive. Right?
Your fact is singling me out for reporting the issue and saying you do not help people like me
Just for me saying there is an issue
now you are putting words in my mouth
I never mentioned the issue you opened, I had not even seen it at that point
you clearly said create your own version of that plugin instead of fixing original
Yes I did.
That’s not the right thing to do
It’s better to fix the original
Signal K software base is pretty large and has a lot of details. An issue like the one you posted, without easy steps to reproduce the problem or a test case, is asking for somebody else to take the time to figure out if there is a problem and create the fix. Then calling the plugin ”a mess” is not really stating a fact but your opinion and will more probably cause the authors less than more motivation to work on your problem
I would be happy to see if the user pointed to a mess in my code. I would work on fixing it instead of attacking that user
Do you see the difference?
I would pay attention even if a user is not right.
Yes, fixing the plugin is clearly the better solution. I also have pretty many issues that I could or should be fixing - very short issues with no details to help me and calling the olugin a mess are extremely demotivating
I provided details in GitHub bug report
Only after i asked
I was attacked before I was asked for details
I have not attacked you
That is beside the point
Your original issue is lacking helpful detail. It forces somebody else to spend time on it to figure it out. If you want to help and get the issue fixed please be helpful - think about how you could make fixing the issue as easy as possible for the author
when you asked for details I provided them
In few minutes
Only after i asked for them. See the difference?
And you did not address the test case part
I can’t read minds. Ask. You get response
Please reread what i wrote above. Provide details before somebody needs to ask
my dudes the best way to deal with someone like this is kick/ban and move on
ban might work both ways
That’s for your help
thanks
@mgrouch calling other people’s work “a mess” is not constructive or respectful
Is that enough to be banned?
No, just very demotivated to work with you on my part
Some people suggest ban
You seem have no issue with that
My motivations come from delivering something good and taking others any feedback
Which is usually negative feedback in software development because people complain about issues. And it’s all good
We all do our best, with the time and ability we each have. And we only do it for fun. Maybe rename you original post to”…need some love”.
Need some love or get banned
It’s crazy a
Good night guys…
So far we have never banned anyone
Suggestion to ban me got upvotes
What does that tell you?
not a friendly place to provide feedback
That’s one way to look at it
Seen anything like this on any other threads here?
We get tons of feedback here
I’ve seen from you to me previously on Slack. Calling my software crap and so on. Turned out I plugged NMEA 2000 wires opposite on two devices. They still were talking to each other but NMEA bus had other issues. Wasn’t even my software issue
What in the world are you talking about?
Number of months we were troubleshooting canboatjs issues. With my esp32 gateway and other stuff. There was canboatjs fix to be done. And I plugged wires wrong.
Number of issues were found then
You had no filter for your own words about my software then
So what’s the big deal about ‘mess’ now?
Would it be possible to take an issue template into a use, which would force to describe issue more clearly and consistent way?
E.g. this could give some idea what to expect from issue reporter to fill in.
https://github.com/bluenviron/mediamtx/blob/main/.github/ISSUE_TEMPLATE/bug.md
Until issue it is filed correct way, it is not processed either.
Generic server/plugin template and how-to-use-it would be great. I could take part to this work gladly.
Just to leave this here: Many thanks to everyone dedicating time and effort into this great project, in particular Teppo and Scott.
i think mgroush's choice of words is completely off the mark. but it's frustrating how many uncorrected bugs lie dormant in SignalK. Wouldn't it be good to rethink the way core developers work? So that the issues would be fixed at some point?
Remember that none of the core developers get paid for their contributions, at least so far. People who volunteer their free time are rarely willing to accept external orders. Basically, it's "scratch your own itch".
What we need is more people willing to contribute. Working on some of the bugs is a good way to get acquainted with the codebase.
How can more contributors help if the core developer PRs don't merge?
I think there is ample evidence of both PRs getting merged and some getting abandoned. Some critisim is warranted, but the situation is not like nothing gets merged and core developers are pro contributions
@BlackSea your wording is a bit ambiguous - do you mean that ”PRs made by core developers don’t get merged” or that ”PRs in general don’t get merged by core developers” - or something else?
I mean the second case
I think you come a long way with a well reasoned issue and a good PR that solves the issue. It is not often just a matter of accepting PRs without looking into the nitty gritty.