F
Filament2mo ago
Ace

Broken Github Action For Managing Issues

This will be weird to write because it's about an issue I had while trying to report a different issue. I promise this isn't frustration or "salt" but a legitimate concern. I just spent about an hour creating a GitHub bug report for an issue I found. When I submitted it, there was an action that auto-closed it because it felt the repro steps section wasn't detailed enough and invited me to edit my original answer. I spent another 30 minutes rewriting the issue in excruciating detail, only for nothing to change on save. After several unsuccessful attempts at editing, including changing the title, I decided to look up the workflow and see exactly what it wanted from me. Even though it is valid according to GitHub, if you include a header in the reproduction steps section, the regex used in that action will fail because it detects it as a new section in the response. I used headers in my original post because my steps were split into one general set and one for the reproduction repo I linked. I removed the headers and replaced them with simple, bold text in hopes of getting my ticket re-opened, but there was no change. At this point, I pulled up the actions tab and saw that the action runner handling my edit had an error. I tried changing a few more things to ensure this wasn't something I could affect, but each time was the same error. I think I've exhausted everything I can do from my side of things short of recreating the GH Issue and hoping it doesn't look like I'm just spamming the same thing repeatedly. Issue in question: https://github.com/filamentphp/filament/issues/13555#issuecomment-2226140142 Failed Action Runs after Edits Were Made: - https://github.com/filamentphp/filament/actions/runs/9912307845 - https://github.com/filamentphp/filament/actions/runs/9912310217 - https://github.com/filamentphp/filament/actions/runs/9912345413
GitHub
MorphOneOfMany Relationship Building Query Improperly with Select ·...
A collection of beautiful full-stack components for Laravel. The perfect starting point for your next app. Using Livewire, Alpine.js and Tailwind CSS. - MorphOneOfMany Relationship Building Query I...
GitHub
MorphOneOfMany Relationship Building Query Improperly with Select ·...
A collection of beautiful full-stack components for Laravel. The perfect starting point for your next app. Using Livewire, Alpine.js and Tailwind CSS. - MorphOneOfMany Relationship Building Query I...
GitHub
MorphOneOfMany Relationship Building Query Improperly with Select ·...
A collection of beautiful full-stack components for Laravel. The perfect starting point for your next app. Using Livewire, Alpine.js and Tailwind CSS. - MorphOneOfMany Relationship Building Query I...
GitHub
MorphOneOfMany Relationship Building Query Improperly with Select ·...
Package filament/filament Package Version v3.2.92 Laravel Version v11.15.0 Livewire Version No response PHP Version PHP 8.2.21 | PHP 8.3.9 Problem description Models with MorphOneOfMany (and probab...
Solution:
Hey, thanks for reporting that issue. I reopened it manually. Sorry for the trouble.
Jump to solution
5 Replies
Solution
Dennis Koch
Dennis Koch2mo ago
Hey, thanks for reporting that issue. I reopened it manually. Sorry for the trouble.
Dennis Koch
Dennis Koch2mo ago
@Dan Harrin Can we improve the action? I just make the wording clearer, that all it needs is a valid reproduction repo?
Ace
Ace2mo ago
No worries. I was more concerned that this would sound like whining about my issue being rejected, honestly. Thanks for re-opening the issue on that side.
Dennis Koch
Dennis Koch2mo ago
Yeah no worries. It shouldn't be that complicated. We just want to prevent issues without a reproduction repo (and people go to lenths to avoid this) 😅
Ace
Ace2mo ago
That's fair. I'll clean up my mess on that side now that I know why it thought it was too short. My initial steps were much less terse and made more sense. I initially saw that it was looking for reproSteps.length < 25 and thought that was 25 lines, not 25 characters, so I went a little overboard.
Want results from more Discord servers?
Add your server