Drizzle Team•5mo ago

Conditional returning, returning wrong types

Condtionals in returning are not returning the correct types.

10 Replies

rphlmr ⚡•5mo ago

can you share you tsconfig? https://drizzle.run/qo0r3rrcoclg9owbazwjiiy5

Drizzle Run

Conditional returning - Drizzle Run

rphlmr ⚡•5mo ago

But even if I can't reproduce the undefined, I note that the return type does not keep the 'optional' part of the returning obj

lordbinbashOP•5mo ago

tsconfig -

{
  "compilerOptions": {
    "target": "ES2022",
    "lib": ["dom", "dom.iterable", "ES2022"],
    "allowJs": true,
    "checkJs": true,
    "skipLibCheck": true,
    "strict": true,
    "forceConsistentCasingInFileNames": true,
    "noEmit": true,
    "esModuleInterop": true,
    "module": "ESNext",
    "moduleResolution": "Bundler",
    "moduleDetection": "force",
    "resolveJsonModule": true,
    "isolatedModules": true,
    "jsx": "preserve",
    "incremental": true,
    "noUncheckedIndexedAccess": true,
    "verbatimModuleSyntax": true,
    "noImplicitOverride": true,
    "plugins": [{ "name": "next" }],
    "paths": { "@/*": ["./*"] }
  },
  "include": [
    "next-env.d.ts",
    ".next/types/**/*.ts",
    ".eslintrc.cjs",
    "**/*.ts",
    "**/*.tsx",
    "**/*.cjs",
    "**/*.mjs"
  ],
  "exclude": ["node_modules", ".next"]
}

{
  "compilerOptions": {
    "target": "ES2022",
    "lib": ["dom", "dom.iterable", "ES2022"],
    "allowJs": true,
    "checkJs": true,
    "skipLibCheck": true,
    "strict": true,
    "forceConsistentCasingInFileNames": true,
    "noEmit": true,
    "esModuleInterop": true,
    "module": "ESNext",
    "moduleResolution": "Bundler",
    "moduleDetection": "force",
    "resolveJsonModule": true,
    "isolatedModules": true,
    "jsx": "preserve",
    "incremental": true,
    "noUncheckedIndexedAccess": true,
    "verbatimModuleSyntax": true,
    "noImplicitOverride": true,
    "plugins": [{ "name": "next" }],
    "paths": { "@/*": ["./*"] }
  },
  "include": [
    "next-env.d.ts",
    ".next/types/**/*.ts",
    ".eslintrc.cjs",
    "**/*.ts",
    "**/*.tsx",
    "**/*.cjs",
    "**/*.mjs"
  ],
  "exclude": ["node_modules", ".next"]
}

Yeah this seems wrong

const user: {
  id: number;
  age: number;
}

const user: {
  id: number;
  age: number;
}

rphlmr ⚡•5mo ago

The undefined inference is due to noUncheckedIndexedAccess. Without it it should be "good" You may want this option in TS, but the drawback is that now you have to check that array items are not undefined And for that I think it is a Drizzle bug because the object passed to returning is correctly infered

rphlmr ⚡•5mo ago

(from one of my projects)

lordbinbashOP•5mo ago

Yeah not too worried about the undefined thing, was just playing around and noticed some weird behaviour. But in the case of a conditional returning, the return type is a drizzle issue?

rphlmr ⚡•5mo ago

for this no

rphlmr ⚡•5mo ago

but for the missing optional flag (z?: number) yes I guess I missed your 2nd screenshot sorry, I am looking at it 2nd screenshot is bug yeah. Pretty sure it is related

lordbinbashOP•5mo ago

I'm more just worried about the type saying something exists, when it may or may not exist 🥶

rphlmr ⚡•5mo ago

I will return everything and forget everything you have discovered 😂 I will try to open an issue about that, thx!

Gaming

Programming

Conditional returning, returning wrong types