Signal K•5mo ago

Freeboard-SK v2.8.1

Freeboard-SK v2.8.1 Contains fix for Alarms not able to be cleared. https://github.com/SignalK/freeboard-sk/releases/tag/v2.8.1

5 Replies

Владимир Калачихин•5mo ago

It's work, but: This doc says: " To clear the alarm condition, send:

{
  "context": "vessels.urn:mrn:signalk:uuid:c0d79334-4e25-4245-8892-54e8ccc8021d",
  "updates": [
    {
      "source": {...},
      "timestamp": "2017-08-15T16:00:05.538Z",
      "values": [
        {
          "path": "notifications.mob",
          "value": null
        }
      ]
    }
  ]
}

{
  "context": "vessels.urn:mrn:signalk:uuid:c0d79334-4e25-4245-8892-54e8ccc8021d",
  "updates": [
    {
      "source": {...},
      "timestamp": "2017-08-15T16:00:05.538Z",
      "values": [
        {
          "path": "notifications.mob",
          "value": null
        }
      ]
    }
  ]
}

" but you send

"value":{
  "state":"normal",
  "method":[],
  "message":""
}

"value":{
  "state":"normal",
  "method":[],
  "message":""
}

It's contrary to documentation and prevents other plugins from knowing that the alarm has cancelled.

AdrianP•5mo ago

I agree and this was the operation prior to the recent update (aligned with spec), but it has been changed based on advice re a proposed alarm clearing functionality for the server. @Scott Bender @David Godin may be able to elaborate.

Scott Bender•5mo ago

I don’t think that is necessarily contrary. “normal” is a valid state for notifications, so plugins and clients should be able to handle it. I think it may be historical, early on you could not send null for a value. The fact of the matter is that most plugins (including all of my numerous plugins) and even n2k-mapper clear notifications by setting the state. Also WilhelmSK and Kip. Another important point is that when a notification is cleared there could be a new message to go along with it. “The fridge temperature is now normal” for example. WilhelmSK will show that message in phone notifications when the state goes to “normal” @AdrianP you should probably preserve the message or use PUT to the notification state.

Владимир Калачихин•5mo ago

“normal” is a valid state for notifications, so plugins and clients should be able to handle it

Where is this documented?

Another important point is that when a notification is cleared there could be a new message to go along with it

A new notification and cancel notification are two different things. My point: The doc above says: " To clear the alarm condition, send: ... "value": null". The Freeboard-SK v2.8.1 sends a not null value when performing the "cancel alarm" action. That is, it does not cancel the alarm, but sets a different state of alarm. This contradicts the available documentation. I don't know any other documentation.

Scott Bender•5mo ago

https://github.com/SignalK/specification/blob/1978f556d8790be2b3bfdc9fffcf82a9a913e3c2/schemas/definitions.json#L513

GitHub

specification/schemas/definitions.json at 1978f556d8790be2b3bfdc9ff...

Signal K is a JSON-based format for storing and sharing marine data from different sources (e.g. nmea 0183, 2000, seatalk, etc) - SignalK/specification

Gaming

Programming

Freeboard-SK v2.8.1