Mara's Developper Corner•7mo ago

Refresh all published notes doesn't seem to work

On the left you can see the updated note in Obsidian and on the right you can see what's in the repo. For some reason it doesn't detect this as a change and I can't upload all the notes that have been changed

23 Replies

fr3fouOP•7mo ago

{
  "github": {
    "branch": "new",
    "automaticallyMergePR": false,
    "dryRun": {
      "enable": false,
      "folderName": "github-publisher"
    },
    "tokenPath": "%configDir%/plugins/%pluginID%/env",
    "api": {
      "tiersForApi": "Github Free/Pro/Team (default)",
      "hostname": ""
    },
    "workflow": {
      "commitMessage": "[PUBLISHER] Merge",
      "name": ""
    },
    "verifiedRepo": true
  },
  "upload": {
    "behavior": "yaml",
    "defaultName": "src/content/blog",
    "rootFolder": "src/content",
    "yamlFolderKey": "type",
    "frontmatterTitle": {
      "enable": false,
      "key": "slug"
    },
    "replaceTitle": [
      {
        "regex": "/\\s+/g",
        "replacement": "-",
        "type": "title"
      }
    ],
    "replacePath": [],
    "autoclean": {
      "includeAttachments": true,
      "enable": true,
      "excluded": []
    },
    "folderNote": {
      "enable": false,
      "rename": "index.md",
      "addTitle": {
        "enable": false,
        "key": "title"
      }
    },
    "metadataExtractorPath": ""
  },
  "conversion": {
    "hardbreak": false,
    "dataview": true,
    "censorText": [
      {
        "entry": "/!\\[\\[(.*\\.((mov)|(mp4)|(webm)))\\]\\]/gi",
        "replace": "![$1](/videos/$1)",
        "flags": "",
        "after": false
      },
      {
        "entry": "/banner: \"\\[\\[(.*)\\]\\]\"/gi",
        "replace": "banner: ../../assets/$1",
        "flags": "",
        "after": false
      },
      {
        "entry": "/cardCover: \"\\[\\[(.*)\\]\\]\"/gi",
        "replace": "cardCover: ../../assets/$1",
        "flags": "",
        "after": false
      }
    ],
    "tags": {
      "inline": false,
      "exclude": [],
      "fields": []
    },
    "links": {
      "internal": true,
      "unshared": false,
      "wiki": true,
      "slugify": "strict"
    }
  },
  "embed": {
    "attachments": true,
    "overrideAttachments": [
      {
        "path": "/.*(mov|webm|mp4)$/",
        "destination": "/public/videos/{{name}}",
        "forcePush": false
      }
    ],
    "keySendFile": [
      "banner",
      "cardCover"
    ],
    "notes": false,
    "folder": "src/assets",
    "convertEmbedToLinks": "keep",
    "charConvert": "->",
    "unHandledObsidianExt": [],
    "sendSimpleLinks": true,
    "useObsidianFolder": false
  },
  "plugin": {
    "shareKey": "share",
    "excludedFolder": [
      "Journals"
    ],
    "copyLink": {
      "enable": true,
      "links": "...",
      "removePart": [],
      "transform": {
        "toUri": true,
        "slugify": "strict",
        "applyRegex": []
      }
    },
    "setFrontmatterKey": "Set"
  },
  "tabsId": "plugin-settings"
}

{
  "github": {
    "branch": "new",
    "automaticallyMergePR": false,
    "dryRun": {
      "enable": false,
      "folderName": "github-publisher"
    },
    "tokenPath": "%configDir%/plugins/%pluginID%/env",
    "api": {
      "tiersForApi": "Github Free/Pro/Team (default)",
      "hostname": ""
    },
    "workflow": {
      "commitMessage": "[PUBLISHER] Merge",
      "name": ""
    },
    "verifiedRepo": true
  },
  "upload": {
    "behavior": "yaml",
    "defaultName": "src/content/blog",
    "rootFolder": "src/content",
    "yamlFolderKey": "type",
    "frontmatterTitle": {
      "enable": false,
      "key": "slug"
    },
    "replaceTitle": [
      {
        "regex": "/\\s+/g",
        "replacement": "-",
        "type": "title"
      }
    ],
    "replacePath": [],
    "autoclean": {
      "includeAttachments": true,
      "enable": true,
      "excluded": []
    },
    "folderNote": {
      "enable": false,
      "rename": "index.md",
      "addTitle": {
        "enable": false,
        "key": "title"
      }
    },
    "metadataExtractorPath": ""
  },
  "conversion": {
    "hardbreak": false,
    "dataview": true,
    "censorText": [
      {
        "entry": "/!\\[\\[(.*\\.((mov)|(mp4)|(webm)))\\]\\]/gi",
        "replace": "![$1](/videos/$1)",
        "flags": "",
        "after": false
      },
      {
        "entry": "/banner: \"\\[\\[(.*)\\]\\]\"/gi",
        "replace": "banner: ../../assets/$1",
        "flags": "",
        "after": false
      },
      {
        "entry": "/cardCover: \"\\[\\[(.*)\\]\\]\"/gi",
        "replace": "cardCover: ../../assets/$1",
        "flags": "",
        "after": false
      }
    ],
    "tags": {
      "inline": false,
      "exclude": [],
      "fields": []
    },
    "links": {
      "internal": true,
      "unshared": false,
      "wiki": true,
      "slugify": "strict"
    }
  },
  "embed": {
    "attachments": true,
    "overrideAttachments": [
      {
        "path": "/.*(mov|webm|mp4)$/",
        "destination": "/public/videos/{{name}}",
        "forcePush": false
      }
    ],
    "keySendFile": [
      "banner",
      "cardCover"
    ],
    "notes": false,
    "folder": "src/assets",
    "convertEmbedToLinks": "keep",
    "charConvert": "->",
    "unHandledObsidianExt": [],
    "sendSimpleLinks": true,
    "useObsidianFolder": false
  },
  "plugin": {
    "shareKey": "share",
    "excludedFolder": [
      "Journals"
    ],
    "copyLink": {
      "enable": true,
      "links": "...",
      "removePart": [],
      "transform": {
        "toUri": true,
        "slugify": "strict",
        "applyRegex": []
      }
    },
    "setFrontmatterKey": "Set"
  },
  "tabsId": "plugin-settings"
}

fr3fouOP•7mo ago

using the "Refresh published and upload new notes" yields this result instead

fr3fouOP•7mo ago

I don't seem to be rate limited

fr3fouOP•7mo ago

there are 2 errors when running the refresh published and upload new notes command

fr3fouOP•7mo ago

deleting the newly created branch also makes no difference I'm running version v7.2.6

Mara•7mo ago

That's not the first time I see this :fronk: Did you try with only one note ? How much note do you want to push ? Github maybe throw an error if the two file are exact, but that strange, I never encounter this issue. At last I just have "no change where made" in GitHub Also, it's possible that the Obsidian cache wasn't updated (I read the note from the cache)

fr3fouOP•7mo ago

tried with 1, 2 and 3 notes

Mara•7mo ago

Pretty strange, I tried on my side without error. The only error was because my token wasn't good. Note that the token is not tested with testing repo (at last, it's not tested for pushing note) Maybe it's something like that?

fr3fouOP•7mo ago

it works fine when doing publish single current active note or when doing publish all notes

Mara•7mo ago

Well, by memory, the notes are compared by dates But it should be okay as I don't put any threshold like 1h min etc

const vaultEditedTime = new Date(fileInVault.stat.mtime);
                    if (repoEditedTime && vaultEditedTime > repoEditedTime) {
                        logs(
                            { settings: this.settings },
                            `edited file : ${fileInVault.path} / ${vaultEditedTime} vs ${repoEditedTime}`
                        );
                        newFiles.push(fileInVault);
                    }

const vaultEditedTime = new Date(fileInVault.stat.mtime);
                    if (repoEditedTime && vaultEditedTime > repoEditedTime) {
                        logs(
                            { settings: this.settings },
                            `edited file : ${fileInVault.path} / ${vaultEditedTime} vs ${repoEditedTime}`
                        );
                        newFiles.push(fileInVault);
                    }

So maybe the date are not detected? update: can repro!

Mara•7mo ago

do you have also an 422 error ? @fr3fou

Mara•7mo ago

Okay, in fact, it says "Found one note to refresh" but in fact, there was none so it crash this seems to happend with excalidraw or maybe "forced" files

fr3fouOP•7mo ago

yep

Mara•7mo ago

Do you have an excalidraw file ? (or "do you have a exported excalidraw file") (sorry for the ping @fr3fou )

fr3fouOP•7mo ago

in one of the notes, yes but i replaced it with an svg and it has happened before when i didn't use any excalidraw embeddings

Mara•7mo ago

hmm, strange It doesn't happens with "normal" attachments I will push a beta, go check if this happens If I didn't found the culprit, i will probably set an error handle for that case

fr3fouOP•7mo ago

oki, ill see if i can reproduce it

Mara•7mo ago

Little question, regarding the change you try: it's a change made in the frontmatter only?

fr3fouOP•7mo ago

it was both – i added a frontmatter checkbox and removed an image from the body

Mara•7mo ago

Hmm, sometimes I get the error, but it's more a struggle of the API than on my side

Gaming

Programming

Refresh all published notes doesn't seem to work