C#•2mo ago

✅ is it okay to use try/catch for logic behavior?

for example here, what is better and why

private string GetHost(string endpoint)
{
    try
    {
        var myUri = new Uri(endpoint as string);
        return myUri.Host;
    }
    catch
    {
        return endpoint;
    }
}

private string GetHost(string endpoint)
{
    try
    {
        var myUri = new Uri(endpoint as string);
        return myUri.Host;
    }
    catch
    {
        return endpoint;
    }
}

private string GetHost(string endpoint)                               
{                                                                     
    return Uri.TryCreate(endpoint, UriKind.Absolute, out var validUri)
        ? validUri.Host                                               
        : endpoint;                                                   
}

private string GetHost(string endpoint)                               
{                                                                     
    return Uri.TryCreate(endpoint, UriKind.Absolute, out var validUri)
        ? validUri.Host                                               
        : endpoint;                                                   
}

10 Replies

Angius•2mo ago

The Try.... pattern is preferred Not only is it more concise to write and easier to read, it's also more performant

SWEETPONY•2mo ago

is it because the Try.... pattern doesn't throw exceptions?

Angius•2mo ago

Well, yes

FusedQyou•2mo ago

Huh? I thought throwing exceptions for expectable behavior is not a good idea?

Angius•2mo ago

That is also true

FusedQyou•2mo ago

Because exceptions are slow and meant for actual invalid operations

Angius•2mo ago

Exceptions should be exceptional

FusedQyou•2mo ago

Then why would Uri.TryCreate not be the answer here? I thought you should always try to use the proper methods to filter out possible wrong inputs

Angius•2mo ago

It is the answer here, yes

SWEETPONY•2mo ago

thanks for helping me

Gaming

Programming

✅ is it okay to use try/catch for logic behavior?