C#•6mo ago

✅ EF CORE, get request wont return related object

42 Replies

Venture

c#
using System.ComponentModel.DataAnnotations;
using System.ComponentModel.DataAnnotations.Schema;

namespace HTXL_Back_end.Models;

[Table("Venture")]
public class Venture
{
    [Key]
    [DatabaseGenerated(DatabaseGeneratedOption.Identity)]
    public Guid? Id { get; set; }
    
    public string Name { get; set; }

    public Portfolio? Portfolio { get; set; }
}

c#
using System.ComponentModel.DataAnnotations;
using System.ComponentModel.DataAnnotations.Schema;

namespace HTXL_Back_end.Models;

[Table("Venture")]
public class Venture
{
    [Key]
    [DatabaseGenerated(DatabaseGeneratedOption.Identity)]
    public Guid? Id { get; set; }
    
    public string Name { get; set; }

    public Portfolio? Portfolio { get; set; }
}

Pobiega•6mo ago

can you show the code that makes the actual query? and is Portfolio here an owned entity, or a normal relational object?

restingphantom•6mo ago

c#

// GET: api/Venture
        [HttpGet]
        public async Task<ActionResult<IEnumerable<Venture>>> GetVentures()
        {
          if (_context.Ventures == null)
          {
              return NotFound();
          }

            return await _context.Ventures.ToListAsync();
        }

c#

// GET: api/Venture
        [HttpGet]
        public async Task<ActionResult<IEnumerable<Venture>>> GetVentures()
        {
          if (_context.Ventures == null)
          {
              return NotFound();
          }

            return await _context.Ventures.ToListAsync();
        }

venture has one or zero portfolios

Pobiega•6mo ago

ok, I see no include - this is probably just a missed include call

restingphantom•6mo ago

i saw something on that on stack overflow

Pobiega•6mo ago

try await _context.Ventures.Include(x => x.Portfolio).ToListAsync();

restingphantom•6mo ago

i just didnt understand where to put it yes that works

Pobiega•6mo ago

EF doesnt fetch relational objects by default, you need to explicitly state that you want them included

restingphantom•6mo ago

would it also be possible to have some of the portfolio relations being returned like that

Pobiega•6mo ago

yep! .ThenInclude(x => ...)

Angius•6mo ago

But, ideally, you should .Select() instead

Pobiega•6mo ago

^ the ideal way to do this, especially in a web api, is to .Select into a DTO you dont want to return your actual entity models directly to the user

restingphantom•6mo ago

I know, but for my Proof of concept its fine for now

Pobiega•6mo ago

sure thing. then .Include(...).ThenInclude(...) will work

Angius•6mo ago

For a proof of concept I'd be selecting into anonymous objects tbh Defining them later Rather than including all over the place

leowest•6mo ago

also Guid? I dont think u want that on a pk

Pobiega•6mo ago

why not? perfectly fine oh, nullable

leowest•6mo ago

nullable Guid?

Pobiega•6mo ago

😄 yeah remove the nullability

leowest•6mo ago

:catgun:

Angius•6mo ago

Sequential IDs gang represent

restingphantom•6mo ago

Guid gets set in the db

Pobiega•6mo ago

vogen ids all the way baby yeah but its nullable remove the nullability and you're fine

restingphantom•6mo ago

yeah, otherwise it will set it to necisairy in the db and then I wont be able to post without ID

leowest•6mo ago

yes and they are pk so they should never be null

Pobiega•6mo ago

guid is a value type, it has a default non-null value (0000-000000...)

restingphantom•6mo ago

c#
 return await _context.Ventures
            .Include(x => x.Portfolio)
            .ThenInclude(x => x.Tech1)
            .Include(x => x.Portfolio)
            .ThenInclude( x => x.Tech2)
            .ToListAsync();

c#
 return await _context.Ventures
            .Include(x => x.Portfolio)
            .ThenInclude(x => x.Tech1)
            .Include(x => x.Portfolio)
            .ThenInclude( x => x.Tech2)
            .ToListAsync();

btw like this?

Angius•6mo ago

Tech2 💀 Not a list?

leowest•6mo ago

consider reading https://learn.microsoft.com/en-us/ef/core/performance/efficient-querying#project-only-properties-you-need

restingphantom•6mo ago

that name isnt my choise

leowest•6mo ago

specially with that many include

restingphantom•6mo ago

😅

Angius•6mo ago

Name is whatever, schema seems bad

restingphantom•6mo ago

how do you mean?

Angius•6mo ago

What if I want to list 67 skills?

restingphantom•6mo ago

skills?

Angius•6mo ago

Uh, techs

restingphantom•6mo ago

ow no thats also what I thought when I saw that tech one is technology one and has sub technologies called tech2 so you choose category tech1 sub category tech2

Angius•6mo ago

That makes more sense then Though the naming sucks ass

restingphantom•6mo ago

yup, I know but thats how my internship did it

c#
public async Task<ActionResult<IEnumerable<Venture>>> GetVentures()
    {
        if (_context.Ventures == null) return NotFound();

        return await _context.Ventures
            .Include(x => x.Portfolio)
            .Include(x => x.Portfolio).ThenInclude(x => x.Tech1)
            .Include(x => x.Portfolio).ThenInclude(x => x.Tech2)
            .Include(x => x.Portfolio).ThenInclude(x => x.Sdgs)
            .Include(x => x.Portfolio).ThenInclude(x => x.Industry)
            .Include(x => x.Portfolio).ThenInclude(x => x.Investments)
            .Include(x => x.Portfolio).ThenInclude(x => x.Investments).ThenInclude(x => x.InevestmentType)
            .Include(x => x.Portfolio).ThenInclude(x => x.Investments).ThenInclude(x => x.Series)
            .ToListAsync();
    }

c#
public async Task<ActionResult<IEnumerable<Venture>>> GetVentures()
    {
        if (_context.Ventures == null) return NotFound();

        return await _context.Ventures
            .Include(x => x.Portfolio)
            .Include(x => x.Portfolio).ThenInclude(x => x.Tech1)
            .Include(x => x.Portfolio).ThenInclude(x => x.Tech2)
            .Include(x => x.Portfolio).ThenInclude(x => x.Sdgs)
            .Include(x => x.Portfolio).ThenInclude(x => x.Industry)
            .Include(x => x.Portfolio).ThenInclude(x => x.Investments)
            .Include(x => x.Portfolio).ThenInclude(x => x.Investments).ThenInclude(x => x.InevestmentType)
            .Include(x => x.Portfolio).ThenInclude(x => x.Investments).ThenInclude(x => x.Series)
            .ToListAsync();
    }

I feel like there is a better way of doing this

Angius•6mo ago

Yes A select

restingphantom•6mo ago

aha let me try ill add that later Thnx everyone

Gaming

Programming

✅ EF CORE, get request wont return related object